Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add gdb to the build #56990
This optionally adds gdb to the Rust build, allowing gdb to be
If gdb is not checked out, nothing changes.
The build is perhaps a bit chatty, as gdb's "make" and "make install"
rust-gdb is modified to prefer the gdb installed by rustup. This is
The built gdb requires Python 2.7 as a shared library (other
Two of the Linux dist builds are updated to build gdb. More could be
If gdb is built as part of the build, and if no other gdb was
Thanks for this! On the technical side this looks pretty reasonable to me.
I'm somewhat hesitant to merge this though because I don't feel like it's tenable to keep adding large tools like this to our distribution. In the limit I don't think we are currently equipped via our current infrastructure to ship what's amounting to an entire toolchain distribution strategy (linker, debugger, compiler, libraries, tooling, etc). We're already feeling lots of pain on CI with timings, and although sccache can accelerate the build here it'll inevitably be yet more to build on builders already bleeding for time.
I think the end goal here is great and we should move towards it, but I'm just not sure that we're ready for this just yet. I think we need to figure out a strategy that doesn't bottleneck absolutely everything on this one repository for distributing releases.
Would you be up for postponing this until there's been a chance to chat more with the dev tools team as well as the infrastructure team?
Ok! I'll put this on the infra team agenda to talk about, and @nrc you might be interested in this for the dev-tools agenda too!
I'm gonna reopen this temporarily at least because I'd also like to use our try builds to analyze how long it takes to build gdb
Click to expand the log.