Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually run compiletest tests on CI #57010

Merged
merged 2 commits into from Dec 24, 2018

Conversation

phansch
Copy link
Member

@phansch phansch commented Dec 20, 2018

I was assuming that #56792 would
have resulted in compiletest tests being executed on CI. However, I
couldn't find any mentions of the unit test names in any CI logs.

This adds the compiletest test execution to the checktools.sh script.

I was assuming that rust-lang#56792 would
have resulted in compiletest tests being executed in CI. However, I
couldn't find any mentions of the unit test names in any CI logs.

This adds the compiletest test execution to the checktools.sh script.
@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 20, 2018
@phansch
Copy link
Member Author

phansch commented Dec 20, 2018

checktools.sh may not be the best place to put it. I'm not sure what Dockerfile would fit better, though.

@Mark-Simulacrum
Copy link
Member

Let's throw this in the mingw-check builder, that should work

This way, checktools.sh continues to be used only for tools that are
published later on.
@kennytm
Copy link
Member

kennytm commented Dec 24, 2018

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 24, 2018

📌 Commit 0493c99 has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 24, 2018
Centril added a commit to Centril/rust that referenced this pull request Dec 24, 2018
…, r=kennytm

Actually run compiletest tests on CI

I was assuming that rust-lang#56792 would
have resulted in compiletest tests being executed on CI. However, I
couldn't find any mentions of the unit test names in any CI logs.

This adds the compiletest test execution to the checktools.sh script.
bors added a commit that referenced this pull request Dec 24, 2018
Rollup of 10 pull requests

Successful merges:

 - #55470 (box: Add documentation for `From` impls)
 - #56242 (Add missing link in docs)
 - #56944 (bootstrap: Link LLVM as a dylib with ThinLTO)
 - #56978 (Add `std::os::fortanix_sgx` module)
 - #56985 (Allow testing pointers for inboundedness while forbidding dangling pointers)
 - #56986 (rustc: Move jemalloc from rustc_driver to rustc)
 - #57010 (Actually run compiletest tests on CI)
 - #57021 (Enable emission of alignment attrs for pointer params)
 - #57074 (Fix recursion limits)
 - #57085 (librustc_codegen_llvm: Don't eliminate empty structs in C ABI on linux-sparc64)

Failed merges:

r? @ghost
@bors bors merged commit 0493c99 into rust-lang:master Dec 24, 2018
@phansch
Copy link
Member Author

phansch commented Dec 24, 2018

This seems to have extended the time to complete the mingw-check run by ~20 minutes, in case anyone is having an eye on CI time.

@phansch phansch deleted the run_compiletest_tests_on_ci branch December 24, 2018 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants