/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize Duration::{as_millis, as_micros, as_nanos} #57124

Merged
merged 1 commit into from Dec 27, 2018
+5 −8

Conversation

Reviewers

@Centril Centril

Assignees

@Centril Centril

Labels
S-waiting-on-bors T-libs relnotes
Projects
None yet
Milestone
No milestone
5 participants
@sunjay @rust-highfive @Centril @bors @TimNN
@sunjay
Copy link
Member

sunjay commented Dec 25, 2018

Fixes #50202. 🎉

This is the stabilization PR for the duration_as_u128 feature. I have never made one of these before so please let me know if I missed a step. I followed the guide in the Rust Forge and also found some old stabilization PRs (1, 2) for similar features to base my work on.

@rust-highfive rust-highfive assigned TimNN Dec 25, 2018

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Dec 25, 2018

r? @TimNN

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review label Dec 25, 2018

@sunjay sunjay referenced this pull request Dec 25, 2018

Closed

Tracking Issue: Duration::{as_nanos, as_micros, as_millis} #50202

@Centril Centril added the relnotes label Dec 25, 2018

@Centril

Centril approved these changes Dec 25, 2018
View changes

Copy link
Contributor

Centril left a comment

Looks good; I'll r+ when tree-close is over.

@Centril Centril assigned Centril and unassigned TimNN Dec 26, 2018

@Centril

This comment has been minimized.

Sign in to view
Copy link
Contributor

Centril commented Dec 26, 2018

@bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Dec 26, 2018

📌 Commit fc32fba has been approved by Centril
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Dec 26, 2018

🌲 The tree is currently closed for pull requests below priority 500, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors and removed S-waiting-on-review labels Dec 26, 2018

@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Dec 26, 2018

☔️ The latest upstream changes (presumably #57108) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author and removed S-waiting-on-bors labels Dec 26, 2018

@sunjay
Stabilize duration_as_u128
Loading status checks…
1e82618

@sunjay sunjay force-pushed the sunjay:stable_duration_as_u128 branch from fc32fba to 1e82618 Dec 26, 2018

@sunjay

This comment has been minimized.

Sign in to view
Copy link
Member

sunjay commented Dec 26, 2018

Fixed the merge conflict.
@Centril

This comment has been minimized.

Sign in to view
Copy link
Contributor

Centril commented Dec 26, 2018

@bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Dec 26, 2018

📌 Commit 1e82618 has been approved by Centril

@bors bors added S-waiting-on-bors and removed S-waiting-on-author labels Dec 26, 2018

@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Dec 26, 2018

⌛️ Testing commit 1e82618 with merge 79bbce4...

bors added a commit that referenced this pull request Dec 26, 2018

@bors
Auto merge of #57124 - sunjay:stable_duration_as_u128, r=Centril 
Stabilize Duration::{as_millis, as_micros, as_nanos}

Fixes #50202. 🎉

This is the stabilization PR for the `duration_as_u128` feature. I have never made one of these before so please let me know if I missed a step. I followed the [guide in the Rust Forge](https://forge.rust-lang.org/stabilization-guide.html) and also found some old stabilization PRs ([1](#57002), [2](#56207)) for similar features to base my work on.
Loading status checks…
79bbce4
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Dec 27, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: Centril
Pushing 79bbce4 to master...

@bors bors merged commit 1e82618 into rust-lang:master Dec 27, 2018
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@sunjay sunjay deleted the sunjay:stable_duration_as_u128 branch Dec 27, 2018

@sunjay

This comment has been minimized.

Sign in to view
Copy link
Member

sunjay commented Dec 27, 2018

🎉

@Centril Centril added the T-libs label Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment