New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize Duration::{as_millis, as_micros, as_nanos} #57124

Merged
merged 1 commit into from Dec 27, 2018

Conversation

Projects
None yet
5 participants
@sunjay
Copy link
Member

sunjay commented Dec 25, 2018

Fixes #50202. 馃帀

This is the stabilization PR for the duration_as_u128 feature. I have never made one of these before so please let me know if I missed a step. I followed the guide in the Rust Forge and also found some old stabilization PRs (1, 2) for similar features to base my work on.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Dec 25, 2018

r? @TimNN

(rust_highfive has picked a reviewer for you, use r? to override)

@Centril
Copy link
Contributor

Centril left a comment

Looks good; I'll r+ when tree-close is over.

@Centril Centril assigned Centril and unassigned TimNN Dec 26, 2018

@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Dec 26, 2018

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 26, 2018

馃搶 Commit fc32fba has been approved by Centril

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 26, 2018

馃尣 The tree is currently closed for pull requests below priority 500, this pull request will be tested once the tree is reopened

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 26, 2018

鈽旓笍 The latest upstream changes (presumably #57108) made this pull request unmergeable. Please resolve the merge conflicts.

@sunjay sunjay force-pushed the sunjay:stable_duration_as_u128 branch from fc32fba to 1e82618 Dec 26, 2018

@sunjay

This comment has been minimized.

Copy link
Member

sunjay commented Dec 26, 2018

Fixed the merge conflict.

@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Dec 26, 2018

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 26, 2018

馃搶 Commit 1e82618 has been approved by Centril

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 26, 2018

鈱涳笍 Testing commit 1e82618 with merge 79bbce4...

bors added a commit that referenced this pull request Dec 26, 2018

Auto merge of #57124 - sunjay:stable_duration_as_u128, r=Centril
Stabilize Duration::{as_millis, as_micros, as_nanos}

Fixes #50202. 馃帀

This is the stabilization PR for the `duration_as_u128` feature. I have never made one of these before so please let me know if I missed a step. I followed the [guide in the Rust Forge](https://forge.rust-lang.org/stabilization-guide.html) and also found some old stabilization PRs ([1](#57002), [2](#56207)) for similar features to base my work on.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 27, 2018

鈽锔 Test successful - status-appveyor, status-travis
Approved by: Centril
Pushing 79bbce4 to master...

@bors bors merged commit 1e82618 into rust-lang:master Dec 27, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@sunjay sunjay deleted the sunjay:stable_duration_as_u128 branch Dec 27, 2018

@sunjay

This comment has been minimized.

Copy link
Member

sunjay commented Dec 27, 2018

馃帀

@Centril Centril added the T-libs label Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment