Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak unicode escape diagnostics #57210

Merged
merged 3 commits into from Jan 1, 2019
Merged

Tweak unicode escape diagnostics #57210

merged 3 commits into from Jan 1, 2019

Conversation

estebank
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 30, 2018
@rust-highfive

This comment has been minimized.

@estebank
Copy link
Contributor Author

r? @zackmdavis

src/libsyntax/parse/lexer/mod.rs Outdated Show resolved Hide resolved
error: incorrect unicode escape sequence
--> $DIR/format-string-error-2.rs:77:20
|
LL | println!("/x7B}/u8 {", 1);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait ... the .rs file source line said println!("\x7B}\u8 {", 1); (with backslashes), why are there forward slashes in the output here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zackmdavis can't find the PR, but UI tests normalize backslashes to forward slashes for Windows' sake to avoid further differences across platforms when running tests. It always makes me recoil for a second until I remember that that's a thing.

@zackmdavis
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Dec 31, 2018

📌 Commit 30961c9 has been approved by zackmdavis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 31, 2018
@bors
Copy link
Contributor

bors commented Jan 1, 2019

⌛ Testing commit 30961c9 with merge 573d6fae1133ce2bf1a18e84c1088665a5e6c6b9...

@bors
Copy link
Contributor

bors commented Jan 1, 2019

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 1, 2019
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-aux of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[01:44:51] [TIMING] ToolBuild { compiler: Compiler { stage: 0, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", tool: "cargotest", path: "src/tools/cargotest", mode: ToolBootstrap, is_optional_tool: false, source_type: InTree, extra_features: [] } -- 1.090
[01:44:51] testing https://github.com/servo/webrender
[01:44:51] Initialized empty Git repository in /checkout/obj/build/ct/webrender/.git/
[01:44:51] fatal: Could not parse object '57250b2b8fa63934f80e5376a29f7dcb3f759ad6'.
[01:45:11] fatal: unable to access 'https://github.com/servo/webrender/': Could not resolve host: github.com
[01:45:11] thread 'main' panicked at 'assertion failed: status.success()', src/tools/cargotest/main.rs:114:13
[01:45:11] 
[01:45:11] 
[01:45:11] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/cargotest" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "/checkout/obj/build/ct"
[01:45:11] expected success, got: exit code: 101
[01:45:11] expected success, got: exit code: 101
[01:45:11] 
[01:45:11] 
[01:45:11] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/test/pretty src/test/run-pass/pretty src/test/run-fail/pretty src/test/run-pass-valgrind/pretty src/test/run-pass-fulldeps/pretty src/test/run-fail-fulldeps/pretty src/tools/cargo src/tools/cargotest
[01:45:11] Build completed unsuccessfully in 0:32:36
[01:45:11] make: *** [check-aux] Error 1
[01:45:11] Makefile:50: recipe for target 'check-aux' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0d4c545e
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Tue Jan  1 06:33:00 UTC 2019
---
travis_time:end:01e0a2d0:start=1546324382719902488,finish=1546324382728210395,duration=8307907
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:35cfe1fa
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:start:crashlog
obj/cores/core.3732.!checkout!obj!build!x86_64-unknown-linux-gnu!stage2!bin!rustc
[New LWP 3738]
[New LWP 3732]
warning: Could not load shared library symbols for 8 libraries, e.g. /lib/x86_64-linux-gnu/libc.so.6.
Use the "info sharedlibrary" command to see the complete listing.
Do you need "set solib-search-path" or "set sysroot"?
Core was generated by `rustc --crate-name foo src/lib.rs --color never --crate-type lib --emit=dep-inf'.
Program terminated with signal SIGABRT, Aborted.
#0  0x00007f19d15de428 in ?? ()
#0  0x00007f19d15de428 in ?? ()
#1  0x00007f19d15e002a in ?? ()
#2  0x0000000000000020 in ?? ()
#3  0x0000000000000000 in ?? ()
travis_time:end:35cfe1fa:start=1546324382736187809,finish=1546324384191833083,duration=1455645274
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:14dc15b8
travis_time:start:14dc15b8
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:01360c97
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@zackmdavis
Copy link
Member

[01:45:11] fatal: unable to access 'https://github.com/servo/webrender/': Could not resolve host: github.com

Sounds fake.

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 1, 2019
@bors
Copy link
Contributor

bors commented Jan 1, 2019

⌛ Testing commit 30961c9 with merge 7a2779a...

bors added a commit that referenced this pull request Jan 1, 2019
Tweak unicode escape diagnostics
@bors
Copy link
Contributor

bors commented Jan 1, 2019

☀️ Test successful - status-appveyor, status-travis
Approved by: zackmdavis
Pushing 7a2779a to master...

@bors bors merged commit 30961c9 into rust-lang:master Jan 1, 2019
@estebank estebank deleted the str-err branch November 9, 2023 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants