New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak unicode escape diagnostics #57210

Merged
merged 3 commits into from Jan 1, 2019

Conversation

Projects
None yet
5 participants
@estebank
Copy link
Contributor

estebank commented Dec 30, 2018

No description provided.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Dec 30, 2018

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Dec 30, 2018

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:11c5baf5:start=1546133273515156763,finish=1546133328701575845,duration=55186419082
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---

[00:03:06] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:03:07] tidy error: /checkout/src/libsyntax_ext/format.rs:846: line longer than 100 chars
[00:03:08] some tidy checks failed
[00:03:08] 
[00:03:08] 
[00:03:08] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:03:08] 
[00:03:08] 
[00:03:08] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:03:08] Build completed unsuccessfully in 0:00:45
[00:03:08] Build completed unsuccessfully in 0:00:45
[00:03:08] make: *** [tidy] Error 1
[00:03:08] Makefile:69: recipe for target 'tidy' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:03775e54
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Sun Dec 30 01:32:05 UTC 2018
---
travis_time:end:0a01693c:start=1546133525835808712,finish=1546133525840754378,duration=4945666
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0ca6318e
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0ac734e1
travis_time:start:0ac734e1
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0b6b4aa8
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@estebank estebank force-pushed the estebank:str-err branch from 5a8535c to 644dbd1 Dec 30, 2018

@estebank

This comment has been minimized.

Copy link
Contributor

estebank commented Dec 30, 2018

Show resolved Hide resolved src/libsyntax/parse/lexer/mod.rs Outdated
error: incorrect unicode escape sequence
--> $DIR/format-string-error-2.rs:77:20
|
LL | println!("/x7B}/u8 {", 1);

This comment has been minimized.

@zackmdavis

zackmdavis Dec 31, 2018

Member

Wait ... the .rs file source line said println!("\x7B}\u8 {", 1); (with backslashes), why are there forward slashes in the output here?

This comment has been minimized.

@estebank

estebank Dec 31, 2018

Contributor

@zackmdavis can't find the PR, but UI tests normalize backslashes to forward slashes for Windows' sake to avoid further differences across platforms when running tests. It always makes me recoil for a second until I remember that that's a thing.

@estebank estebank force-pushed the estebank:str-err branch from 644dbd1 to 30961c9 Dec 31, 2018

@zackmdavis

This comment has been minimized.

Copy link
Member

zackmdavis commented Dec 31, 2018

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 31, 2018

📌 Commit 30961c9 has been approved by zackmdavis

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 1, 2019

⌛️ Testing commit 30961c9 with merge 573d6fa...

bors added a commit that referenced this pull request Jan 1, 2019

Auto merge of #57210 - estebank:str-err, r=zackmdavis
Tweak unicode escape diagnostics
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 1, 2019

💔 Test failed - status-travis

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jan 1, 2019

The job x86_64-gnu-aux of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[01:44:51] [TIMING] ToolBuild { compiler: Compiler { stage: 0, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", tool: "cargotest", path: "src/tools/cargotest", mode: ToolBootstrap, is_optional_tool: false, source_type: InTree, extra_features: [] } -- 1.090
[01:44:51] testing https://github.com/servo/webrender
[01:44:51] Initialized empty Git repository in /checkout/obj/build/ct/webrender/.git/
[01:44:51] fatal: Could not parse object '57250b2b8fa63934f80e5376a29f7dcb3f759ad6'.
[01:45:11] fatal: unable to access 'https://github.com/servo/webrender/': Could not resolve host: github.com
[01:45:11] thread 'main' panicked at 'assertion failed: status.success()', src/tools/cargotest/main.rs:114:13
[01:45:11] 
[01:45:11] 
[01:45:11] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/cargotest" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "/checkout/obj/build/ct"
[01:45:11] expected success, got: exit code: 101
[01:45:11] expected success, got: exit code: 101
[01:45:11] 
[01:45:11] 
[01:45:11] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/test/pretty src/test/run-pass/pretty src/test/run-fail/pretty src/test/run-pass-valgrind/pretty src/test/run-pass-fulldeps/pretty src/test/run-fail-fulldeps/pretty src/tools/cargo src/tools/cargotest
[01:45:11] Build completed unsuccessfully in 0:32:36
[01:45:11] make: *** [check-aux] Error 1
[01:45:11] Makefile:50: recipe for target 'check-aux' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0d4c545e
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Tue Jan  1 06:33:00 UTC 2019
---
travis_time:end:01e0a2d0:start=1546324382719902488,finish=1546324382728210395,duration=8307907
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:35cfe1fa
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:start:crashlog
obj/cores/core.3732.!checkout!obj!build!x86_64-unknown-linux-gnu!stage2!bin!rustc
[New LWP 3738]
[New LWP 3732]
warning: Could not load shared library symbols for 8 libraries, e.g. /lib/x86_64-linux-gnu/libc.so.6.
Use the "info sharedlibrary" command to see the complete listing.
Do you need "set solib-search-path" or "set sysroot"?
Core was generated by `rustc --crate-name foo src/lib.rs --color never --crate-type lib --emit=dep-inf'.
Program terminated with signal SIGABRT, Aborted.
#0  0x00007f19d15de428 in ?? ()
#0  0x00007f19d15de428 in ?? ()
#1  0x00007f19d15e002a in ?? ()
#2  0x0000000000000020 in ?? ()
#3  0x0000000000000000 in ?? ()
travis_time:end:35cfe1fa:start=1546324382736187809,finish=1546324384191833083,duration=1455645274
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:14dc15b8
travis_time:start:14dc15b8
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:01360c97
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@zackmdavis

This comment has been minimized.

Copy link
Member

zackmdavis commented Jan 1, 2019

[01:45:11] fatal: unable to access 'https://github.com/servo/webrender/': Could not resolve host: github.com

Sounds fake.

@bors retry

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 1, 2019

⌛️ Testing commit 30961c9 with merge 7a2779a...

bors added a commit that referenced this pull request Jan 1, 2019

Auto merge of #57210 - estebank:str-err, r=zackmdavis
Tweak unicode escape diagnostics
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 1, 2019

☀️ Test successful - status-appveyor, status-travis
Approved by: zackmdavis
Pushing 7a2779a to master...

@bors bors merged commit 30961c9 into rust-lang:master Jan 1, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment