New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize cfg_target_vendor #57465

Merged
merged 2 commits into from Jan 14, 2019

Conversation

Projects
None yet
8 participants
@jethrogb
Copy link
Contributor

jethrogb commented Jan 9, 2019

This stabilizes the use of cfg(target_vendor = "...") and removes the corresponding cfg_target_vendor feature. Other unstable cfgs remain behind their existing feature gates.

This functionality was added back in 2015 in #28612 to complete the coverage of target tuples (<arch><sub>-<vendor>-<os>-<env>). RFC 131 governs the target specification, not including target_vendor seems to have just been an oversight. target_os, target_family, and target_arch are stable as of 1.0.0. target_env was also not mentioned in RFC 131, was added in #24777, never behind a feature_gate, and insta-stable at 1.1.0.

The functionality is tested in test/run-pass/cfg/cfg-target-vendor.rs.

Closes #29718

Show resolved Hide resolved src/libsyntax/feature_gate.rs
@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Jan 9, 2019

@rust-lang rust-lang deleted a comment from rust-highfive Jan 9, 2019

@Centril Centril added the relnotes label Jan 9, 2019

@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Jan 9, 2019

@jethrogb Please file a documentation issue against the https://github.com/rust-lang-nursery/reference/ and link to this PR. Also, if you can help with adjusting the reference that would be good.

@jethrogb

This comment has been minimized.

Copy link
Contributor

jethrogb commented Jan 9, 2019

@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Jan 9, 2019

@jethrogb OK; but the possible values are outdated and will need to be updated.

@jethrogb

This comment has been minimized.

Copy link
Contributor

jethrogb commented Jan 9, 2019

I've filed rust-lang-nursery/reference#502 but I think it's entirely orthogonal to this PR.

@joshtriplett

This comment has been minimized.

Copy link
Member

joshtriplett commented Jan 9, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 9, 2019

📌 Commit 224020c has been approved by joshtriplett

@joshtriplett

This comment has been minimized.

Copy link
Member

joshtriplett commented Jan 9, 2019

On second thought, let's make sure people have a chance to confirm that this should be stabilized. I'll r+ if this goes through.

@bors r-
@rfcbot merge

@rfcbot

This comment has been minimized.

Copy link

rfcbot commented Jan 9, 2019

Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@bors

This comment was marked as resolved.

Copy link
Contributor

bors commented Jan 12, 2019

☔️ The latest upstream changes (presumably #57532) made this pull request unmergeable. Please resolve the merge conflicts.

@scottmcm

This comment has been minimized.

Copy link
Member

scottmcm commented Jan 14, 2019

To anyone else on lang wondering why,

Users will be needing this to distinguish between the in-tree x86_64-fortanix-unknown-sgx target and other all(target_arch = "x86_64", target_env = "sgx") targets, see #57231. Can this be moved to FCP for stabilization? ~ #29718 (comment)

@rfcbot reviewed

@rfcbot

This comment has been minimized.

Copy link

rfcbot commented Jan 14, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Jan 14, 2019

@jethrogb Now that we're in FCP, per Josh's comment, #57465 (comment), I think we can ship this. Can you rebase first tho?

@jethrogb

This comment has been minimized.

Copy link
Contributor

jethrogb commented Jan 14, 2019

@Centril are you planning to merge this today for 1.33?

@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Jan 14, 2019

@jethrogb Yes, hopefully at least; we have 1 day to master=>beta promotion, so it should be sufficient time to merge this PR.

@bors p=1

@jethrogb jethrogb force-pushed the jethrogb:jb/stablize-cfg-target-vendor branch from 224020c to 972bba7 Jan 14, 2019

@jethrogb

This comment has been minimized.

Copy link
Contributor

jethrogb commented Jan 14, 2019

Ok cool, wasn't sure if you wanted to wait for FCP or not. Rebased.

@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Jan 14, 2019

@bors r=joshtriplett,Centril

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 14, 2019

📌 Commit 972bba7 has been approved by joshtriplett,Centril

Centril added a commit to Centril/rust that referenced this pull request Jan 14, 2019

Rollup merge of rust-lang#57465 - jethrogb:jb/stablize-cfg-target-ven…
…dor, r=joshtriplett,Centril

Stabilize cfg_target_vendor

This stabilizes the use of `cfg(target_vendor = "...")` and removes the corresponding `cfg_target_vendor` feature. Other unstable cfgs remain behind their existing feature gates.

This functionality was added back in 2015 in rust-lang#28612 to complete the coverage of target tuples (`<arch><sub>-<vendor>-<os>-<env>`). [RFC 131](https://github.com/rust-lang/rfcs/blob/master/text/0131-target-specification.md) governs the target specification, not including `target_vendor` seems to have just been an oversight. `target_os`, `target_family`, and `target_arch` are stable as of 1.0.0. `target_env` was also not mentioned in RFC 131, was added in rust-lang#24777, never behind a feature_gate, and insta-stable at 1.1.0.

The functionality is tested in [test/run-pass/cfg/cfg-target-vendor.rs](https://github.com/rust-lang/rust/blob/master/src/test/run-pass/cfg/cfg-target-vendor.rs).

Closes rust-lang#29718

Centril added a commit to Centril/rust that referenced this pull request Jan 14, 2019

Rollup merge of rust-lang#57465 - jethrogb:jb/stablize-cfg-target-ven…
…dor, r=joshtriplett,Centril

Stabilize cfg_target_vendor

This stabilizes the use of `cfg(target_vendor = "...")` and removes the corresponding `cfg_target_vendor` feature. Other unstable cfgs remain behind their existing feature gates.

This functionality was added back in 2015 in rust-lang#28612 to complete the coverage of target tuples (`<arch><sub>-<vendor>-<os>-<env>`). [RFC 131](https://github.com/rust-lang/rfcs/blob/master/text/0131-target-specification.md) governs the target specification, not including `target_vendor` seems to have just been an oversight. `target_os`, `target_family`, and `target_arch` are stable as of 1.0.0. `target_env` was also not mentioned in RFC 131, was added in rust-lang#24777, never behind a feature_gate, and insta-stable at 1.1.0.

The functionality is tested in [test/run-pass/cfg/cfg-target-vendor.rs](https://github.com/rust-lang/rust/blob/master/src/test/run-pass/cfg/cfg-target-vendor.rs).

Closes rust-lang#29718

Centril added a commit to Centril/rust that referenced this pull request Jan 14, 2019

Rollup merge of rust-lang#57465 - jethrogb:jb/stablize-cfg-target-ven…
…dor, r=joshtriplett,Centril

Stabilize cfg_target_vendor

This stabilizes the use of `cfg(target_vendor = "...")` and removes the corresponding `cfg_target_vendor` feature. Other unstable cfgs remain behind their existing feature gates.

This functionality was added back in 2015 in rust-lang#28612 to complete the coverage of target tuples (`<arch><sub>-<vendor>-<os>-<env>`). [RFC 131](https://github.com/rust-lang/rfcs/blob/master/text/0131-target-specification.md) governs the target specification, not including `target_vendor` seems to have just been an oversight. `target_os`, `target_family`, and `target_arch` are stable as of 1.0.0. `target_env` was also not mentioned in RFC 131, was added in rust-lang#24777, never behind a feature_gate, and insta-stable at 1.1.0.

The functionality is tested in [test/run-pass/cfg/cfg-target-vendor.rs](https://github.com/rust-lang/rust/blob/master/src/test/run-pass/cfg/cfg-target-vendor.rs).

Closes rust-lang#29718

Centril added a commit to Centril/rust that referenced this pull request Jan 14, 2019

Rollup merge of rust-lang#57465 - jethrogb:jb/stablize-cfg-target-ven…
…dor, r=joshtriplett,Centril

Stabilize cfg_target_vendor

This stabilizes the use of `cfg(target_vendor = "...")` and removes the corresponding `cfg_target_vendor` feature. Other unstable cfgs remain behind their existing feature gates.

This functionality was added back in 2015 in rust-lang#28612 to complete the coverage of target tuples (`<arch><sub>-<vendor>-<os>-<env>`). [RFC 131](https://github.com/rust-lang/rfcs/blob/master/text/0131-target-specification.md) governs the target specification, not including `target_vendor` seems to have just been an oversight. `target_os`, `target_family`, and `target_arch` are stable as of 1.0.0. `target_env` was also not mentioned in RFC 131, was added in rust-lang#24777, never behind a feature_gate, and insta-stable at 1.1.0.

The functionality is tested in [test/run-pass/cfg/cfg-target-vendor.rs](https://github.com/rust-lang/rust/blob/master/src/test/run-pass/cfg/cfg-target-vendor.rs).

Closes rust-lang#29718

bors added a commit that referenced this pull request Jan 14, 2019

Auto merge of #57592 - Centril:rollup, r=Centril
Rollup of 6 pull requests

Successful merges:

 - #57232 (Parallelize and optimize parts of HIR map creation)
 - #57418 (MetadataOnlyCodegenBackend: run the collector only once)
 - #57465 (Stabilize cfg_target_vendor)
 - #57477 (clarify resolve typo suggestion)
 - #57556 (privacy: Fix private-in-public check for existential types)
 - #57584 (Remove the `connect_timeout_unroutable` test.)

Failed merges:

r? @ghost
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 14, 2019

⌛️ Testing commit 972bba7 with merge d106808...

@bors bors merged commit 972bba7 into rust-lang:master Jan 14, 2019

1 check was pending

homu Testing commit 972bba7071d0e6b04194fa3c1108b991262dd502 with merge d10680818b2a0aabb76e6a07098e031b31707fcc...
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment