New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide suggestion for invalid boolean cast #57481

Merged
merged 1 commit into from Jan 15, 2019

Conversation

Projects
None yet
6 participants
@euclio
Copy link
Contributor

euclio commented Jan 9, 2019

Also, don't suggest comparing to zero for non-numeric expressions.

provide suggestion for invalid boolean cast
Also, don't suggest comparing to zero for non-numeric expressions.
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jan 9, 2019

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@cramertj

This comment has been minimized.

Copy link
Member

cramertj commented Jan 9, 2019

@rust-highfive rust-highfive assigned estebank and unassigned cramertj Jan 9, 2019

@estebank

This comment has been minimized.

Copy link
Contributor

estebank commented Jan 9, 2019

r=me once travis' green.

@estebank

This comment has been minimized.

Copy link
Contributor

estebank commented Jan 9, 2019

@bors try

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 9, 2019

⌛️ Trying commit 565c39d with merge 9cd4bcc...

bors added a commit that referenced this pull request Jan 9, 2019

Auto merge of #57481 - euclio:bool-cast-suggestion, r=<try>
provide suggestion for invalid boolean cast

Also, don't suggest comparing to zero for non-numeric expressions.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 10, 2019

☀️ Test successful - checks-travis
State: approved= try=True

@estebank

This comment has been minimized.

Copy link
Contributor

estebank commented Jan 10, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 10, 2019

📌 Commit 565c39d has been approved by estebank

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 10, 2019

⌛️ Testing commit 565c39d with merge d15431f...

bors added a commit that referenced this pull request Jan 10, 2019

Auto merge of #57481 - euclio:bool-cast-suggestion, r=estebank
provide suggestion for invalid boolean cast

Also, don't suggest comparing to zero for non-numeric expressions.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 10, 2019

💔 Test failed - status-appveyor

@pietroalbini

This comment has been minimized.

Copy link
Member

pietroalbini commented Jan 10, 2019

@bors retry
AppVeyor... what's wrong with you today?

Centril added a commit to Centril/rust that referenced this pull request Jan 14, 2019

Rollup merge of rust-lang#57481 - euclio:bool-cast-suggestion, r=este…
…bank

provide suggestion for invalid boolean cast

Also, don't suggest comparing to zero for non-numeric expressions.

bors added a commit that referenced this pull request Jan 14, 2019

Auto merge of #57599 - Centril:rollup, r=Centril
Rollup of 5 pull requests

Successful merges:

 - #57442 (Simplify `ConstValue::ScalarPair`)
 - #57480 (Clean up and fix a bug in query plumbing)
 - #57481 (provide suggestion for invalid boolean cast)
 - #57540 (Modify some parser diagnostics to continue evaluating beyond the parser)
 - #57570 (Querify local `plugin_registrar_fn` and `proc_macro_decls_static`)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Jan 14, 2019

Rollup merge of rust-lang#57481 - euclio:bool-cast-suggestion, r=este…
…bank

provide suggestion for invalid boolean cast

Also, don't suggest comparing to zero for non-numeric expressions.

Centril added a commit to Centril/rust that referenced this pull request Jan 14, 2019

Rollup merge of rust-lang#57481 - euclio:bool-cast-suggestion, r=este…
…bank

provide suggestion for invalid boolean cast

Also, don't suggest comparing to zero for non-numeric expressions.

bors added a commit that referenced this pull request Jan 14, 2019

Auto merge of #57607 - Centril:rollup, r=Centril
Rollup of 8 pull requests

Successful merges:

 - #57043 (Fix poor worst case performance of set intersection)
 - #57480 (Clean up and fix a bug in query plumbing)
 - #57481 (provide suggestion for invalid boolean cast)
 - #57540 (Modify some parser diagnostics to continue evaluating beyond the parser)
 - #57570 (Querify local `plugin_registrar_fn` and `proc_macro_decls_static`)
 - #57572 (Unaccept `extern_in_paths`)
 - #57585 (Recover from item trailing semicolon)
 - #57589 (Add a debug_assert to Vec::set_len)

Failed merges:

r? @ghost

@bors bors merged commit 565c39d into rust-lang:master Jan 15, 2019

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
homu Test failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment