New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the IP address in the `connect_timeout_unroutable` test. #57506

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@nnethercote
Copy link
Contributor

nnethercote commented Jan 11, 2019

Because the current address is reachable on some machines, which causes
the test to fail.

Fixes #44698, fixes #50065.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jan 11, 2019

r? @dtolnay

(rust_highfive has picked a reviewer for you, use r? to override)

@nnethercote

This comment has been minimized.

Copy link
Contributor

nnethercote commented Jan 11, 2019

I can't guarantee this will work universally, for reasons explained in the comment. But it fixes the test failure for my Ubuntu 18.04 box.

@nnethercote

This comment has been minimized.

Copy link
Contributor

nnethercote commented Jan 11, 2019

#44698 has some extra info. @RalfJung said changing to 192.0.2.2 didn't fix the problem, which is disappointing. @bobtwinkles suggested "disabling it on non-CI builds by default" -- what would that look like?

Change the IP address in the `connect_timeout_unroutable` test.
Because the current address is reachable on some machines, which causes
the test to fail.

Fixes #44698, #50065.

@nnethercote nnethercote force-pushed the nnethercote:fix-connect_timeout_unroutable branch from f4c2405 to ca26d44 Jan 11, 2019

@dtolnay

This comment has been minimized.

Copy link
Member

dtolnay commented Jan 11, 2019

@rust-highfive rust-highfive assigned sfackler and unassigned dtolnay Jan 11, 2019

@nagisa

This comment has been minimized.

Copy link
Contributor

nagisa commented Jan 11, 2019

This test should just go. There are so many ways this could do something else for any IP that it makes no sense to test for it without mocking out the system call.

@nnethercote

This comment has been minimized.

Copy link
Contributor

nnethercote commented Jan 13, 2019

This test should just go.

I filed #57584, which removes the test, as an alternative. I'll let @sfackler decide which approach is better.

@nnethercote

This comment has been minimized.

Copy link
Contributor

nnethercote commented Jan 14, 2019

@sfackler approved #57584, so I'll close this.

@nnethercote nnethercote deleted the nnethercote:fix-connect_timeout_unroutable branch Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment