New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't unwrap unexpected tokens in `format!` #57522

merged 1 commit into from Jan 12, 2019


None yet
6 participants
Copy link

euclio commented Jan 11, 2019

Fixes #57512.


This comment has been minimized.

Copy link

rust-highfive commented Jan 11, 2019

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)


This comment has been minimized.

Copy link

varkor commented Jan 11, 2019

@bors r+ rollup


This comment has been minimized.

Copy link

bors commented Jan 11, 2019

📌 Commit 020e1f5 has been approved by varkor

--> $DIR/
LL | format!("s", foo = foo, bar); //~ ERROR expected `=`
| ^^^ expected `=`

This comment has been minimized.


estebank Jan 11, 2019


It'd be nice if this had a custom diagnostic explaining that named format arguments must come after positional format arguments :)

Centril added a commit to Centril/rust that referenced this pull request Jan 12, 2019

Rollup merge of rust-lang#57522 - euclio:format-ice, r=varkor
don't unwrap unexpected tokens in `format!`

Fixes rust-lang#57512.

bors added a commit that referenced this pull request Jan 12, 2019

Auto merge of #57542 - Centril:rollup, r=Centril
Rollup of 26 pull requests

Successful merges:

 - #56425 (Redo the docs for Vec::set_len)
 - #56906 (Issue #56905)
 - #57042 (Don't call `FieldPlacement::count` when count is too large)
 - #57175 (Stabilize `let` bindings and destructuring in constants and const fn)
 - #57192 (Change std::error::Error trait documentation to talk about `source` instead of `cause`)
 - #57296 (Fixed the link to the ? operator)
 - #57368 (Use CMAKE_{C,CXX}_COMPILER_LAUNCHER for ccache)
 - #57400 (Rustdoc: update Source Serif Pro and replace Heuristica italic)
 - #57417 (rustdoc: use text-based doctest parsing if a macro is wrapping main)
 - #57433 (Add link destination for `read-ownership`)
 - #57434 (Remove `CrateNum::Invalid`.)
 - #57441 (Supporting backtrace for x86_64-fortanix-unknown-sgx.)
 - #57450 (actually take a slice in this example)
 - #57459 (Reference tracking issue for inherent associated types in diagnostic)
 - #57463 (docs: Fix some 'second-edition' links)
 - #57466 (Remove outdated comment)
 - #57493 (use structured suggestion when casting a reference)
 - #57498 (make note of one more normalization that Paths do)
 - #57499 (note that FromStr does not work for borrowed types)
 - #57505 (Remove submodule step from README)
 - #57510 (Add a profiles section to the manifest)
 - #57511 (Fix undefined behavior)
 - #57519 (Correct for 1.32.0)
 - #57522 (don't unwrap unexpected tokens in `format!`)
 - #57530 (Fixing a typographical error.)
 - #57535 (Stabilise irrefutable if-let and while-let patterns)

Failed merges:

r? @ghost

@bors bors merged commit 020e1f5 into rust-lang:master Jan 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment