New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Querify local `plugin_registrar_fn` and `proc_macro_decls_static` #57570

Merged
merged 3 commits into from Jan 15, 2019

Conversation

Projects
None yet
5 participants
@Xanewok
Copy link
Member

Xanewok commented Jan 13, 2019

Instead of calculating them as part of the Session, we do that in the query system.
It's also nice that these queries are already defined for external crates - here, we provide the queries for the local crate.

r? @nikomatsakis

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 13, 2019

☔️ The latest upstream changes (presumably #51487) made this pull request unmergeable. Please resolve the merge conflicts.

Xanewok added some commits Jan 12, 2019

Retain original pass order
It shouldn't matter, but hey - better safe than sorry!

@Xanewok Xanewok force-pushed the Xanewok:querify-some branch from 9399fb9 to 707a9a0 Jan 13, 2019

@Zoxc

This comment has been minimized.

Copy link
Contributor

Zoxc commented Jan 14, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 14, 2019

📌 Commit 707a9a0 has been approved by Zoxc

Centril added a commit to Centril/rust that referenced this pull request Jan 14, 2019

Rollup merge of rust-lang#57570 - Xanewok:querify-some, r=Zoxc
Querify local `plugin_registrar_fn` and `proc_macro_decls_static`

Instead of calculating them as part of the `Session`, we do that in the query system.
It's also nice that these queries are already defined for external crates - here, we provide the queries for the local crate.

r? @nikomatsakis

bors added a commit that referenced this pull request Jan 14, 2019

Auto merge of #57599 - Centril:rollup, r=Centril
Rollup of 5 pull requests

Successful merges:

 - #57442 (Simplify `ConstValue::ScalarPair`)
 - #57480 (Clean up and fix a bug in query plumbing)
 - #57481 (provide suggestion for invalid boolean cast)
 - #57540 (Modify some parser diagnostics to continue evaluating beyond the parser)
 - #57570 (Querify local `plugin_registrar_fn` and `proc_macro_decls_static`)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Jan 14, 2019

Rollup merge of rust-lang#57570 - Xanewok:querify-some, r=Zoxc
Querify local `plugin_registrar_fn` and `proc_macro_decls_static`

Instead of calculating them as part of the `Session`, we do that in the query system.
It's also nice that these queries are already defined for external crates - here, we provide the queries for the local crate.

r? @nikomatsakis

Centril added a commit to Centril/rust that referenced this pull request Jan 14, 2019

Rollup merge of rust-lang#57570 - Xanewok:querify-some, r=Zoxc
Querify local `plugin_registrar_fn` and `proc_macro_decls_static`

Instead of calculating them as part of the `Session`, we do that in the query system.
It's also nice that these queries are already defined for external crates - here, we provide the queries for the local crate.

r? @nikomatsakis

bors added a commit that referenced this pull request Jan 14, 2019

Auto merge of #57607 - Centril:rollup, r=Centril
Rollup of 8 pull requests

Successful merges:

 - #57043 (Fix poor worst case performance of set intersection)
 - #57480 (Clean up and fix a bug in query plumbing)
 - #57481 (provide suggestion for invalid boolean cast)
 - #57540 (Modify some parser diagnostics to continue evaluating beyond the parser)
 - #57570 (Querify local `plugin_registrar_fn` and `proc_macro_decls_static`)
 - #57572 (Unaccept `extern_in_paths`)
 - #57585 (Recover from item trailing semicolon)
 - #57589 (Add a debug_assert to Vec::set_len)

Failed merges:

r? @ghost

@bors bors merged commit 707a9a0 into rust-lang:master Jan 15, 2019

@Xanewok Xanewok deleted the Xanewok:querify-some branch Jan 16, 2019

Centril added a commit to Centril/rust that referenced this pull request Jan 19, 2019

Rollup merge of rust-lang#57573 - Xanewok:querify-entry-fn, r=Zoxc
Querify `entry_fn`

Analogous to rust-lang#57570 but this will also require few fixups in Miri so I decided to separate that (and it seems [CI doesn't let us break tools anymore](rust-lang#57392 (comment))? Or was that because it was a rollup PR?)

r? @nikomatsakis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment