Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a debug_assert to Vec::set_len #57589

Merged
merged 1 commit into from Jan 15, 2019

Conversation

Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors T-libs
Projects
None yet
Milestone
No milestone
5 participants
@scottmcm @rust-highfive @Mark-Simulacrum @alexcrichton @bors
@scottmcm
Copy link
Member

scottmcm commented Jan 14, 2019

Following the precedent of #52972, which found llogiq/bytecount#42.

(This may well make a test fail; let's see what Travis says.)

@rust-highfive rust-highfive assigned Mark-Simulacrum Jan 14, 2019

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Jan 14, 2019

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review label Jan 14, 2019

@scottmcm scottmcm added the T-libs label Jan 14, 2019

@Mark-Simulacrum

This comment has been minimized.

Sign in to view
Copy link
Member

Mark-Simulacrum commented Jan 14, 2019

r? @alexcrichton

@rust-highfive rust-highfive assigned alexcrichton and unassigned Mark-Simulacrum Jan 14, 2019

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Jan 14, 2019

@bors: r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jan 14, 2019

📌 Commit 1fd971c has been approved by alexcrichton

@bors bors added S-waiting-on-bors and removed S-waiting-on-review labels Jan 14, 2019

Centril added a commit to Centril/rust that referenced this pull request Jan 14, 2019

@Centril
Rollup merge of rust-lang#57589 - scottmcm:vec-set_len-debug_assert, … 
…r=alexcrichton

Add a debug_assert to Vec::set_len

Following the precedent of rust-lang#52972, which found llogiq/bytecount#42.

(This may well make a test fail; let's see what Travis says.)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
c1f0f04

Centril added a commit to Centril/rust that referenced this pull request Jan 14, 2019

@Centril
Rollup merge of rust-lang#57589 - scottmcm:vec-set_len-debug_assert, … 
…r=alexcrichton

Add a debug_assert to Vec::set_len

Following the precedent of rust-lang#52972, which found llogiq/bytecount#42.

(This may well make a test fail; let's see what Travis says.)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
8a62e39

@Centril Centril referenced this pull request Jan 14, 2019

Merged

Rollup of 8 pull requests #57607

bors added a commit that referenced this pull request Jan 14, 2019

@bors
Auto merge of #57607 - Centril:rollup, r=Centril 
Rollup of 8 pull requests

Successful merges:

 - #57043 (Fix poor worst case performance of set intersection)
 - #57480 (Clean up and fix a bug in query plumbing)
 - #57481 (provide suggestion for invalid boolean cast)
 - #57540 (Modify some parser diagnostics to continue evaluating beyond the parser)
 - #57570 (Querify local `plugin_registrar_fn` and `proc_macro_decls_static`)
 - #57572 (Unaccept `extern_in_paths`)
 - #57585 (Recover from item trailing semicolon)
 - #57589 (Add a debug_assert to Vec::set_len)

Failed merges:

r? @ghost
Loading status checks…
aea9f0a

@bors bors merged commit 1fd971c into rust-lang:master Jan 15, 2019

@scottmcm scottmcm deleted the scottmcm:vec-set_len-debug_assert branch Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.