Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the edition guide to the bookshelf #57980

Merged
merged 1 commit into from Jan 31, 2019

Conversation

Reviewers

@QuietMisdreavus QuietMisdreavus

Assignees

@QuietMisdreavus QuietMisdreavus

Labels
S-waiting-on-bors
Projects
None yet
Milestone
No milestone
5 participants
@siddharthasahu @rust-highfive @QuietMisdreavus @Centril @bors
@siddharthasahu
Copy link
Contributor

siddharthasahu commented Jan 29, 2019

No description provided.

@siddharthasahu
Add link to the edition guide.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
84a89aa

@rust-highfive rust-highfive assigned QuietMisdreavus Jan 29, 2019

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Jan 29, 2019

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @QuietMisdreavus (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review label Jan 29, 2019

@QuietMisdreavus

QuietMisdreavus approved these changes Jan 29, 2019
View changes

Copy link
Member

QuietMisdreavus left a comment

Oh wow, i didn't even realize we were hosting this but didn't have it in the bookshelf listing! Thanks for adding the link!
@QuietMisdreavus

This comment has been minimized.

Sign in to view
Copy link
Member

QuietMisdreavus commented Jan 29, 2019

r=me when travis is green. (It's probably not necessary to wait, but i do this out of habit. >_>)

@siddharthasahu siddharthasahu changed the title Add link to the edition guide from the docs root page Add the edition guide to the bookshelf Jan 29, 2019

@siddharthasahu

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

siddharthasahu commented Jan 29, 2019

Ah, bookshelf. I edited the title accordingly.
@Centril

This comment has been minimized.

Sign in to view
Copy link
Contributor

Centril commented Jan 30, 2019

@bors r=QuietMisdreavus rollup
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jan 30, 2019

📌 Commit 84a89aa has been approved by QuietMisdreavus

@bors bors added S-waiting-on-bors and removed S-waiting-on-review labels Jan 30, 2019

Centril added a commit to Centril/rust that referenced this pull request Jan 30, 2019

@Centril
Rollup merge of rust-lang#57980 - siddharthasahu:patch-1, r=QuietMisd… 
…reavus

Add the edition guide to the bookshelf
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
e3617ae

@Centril Centril referenced this pull request Jan 30, 2019

Closed

Rollup of 6 pull requests #57995

bors added a commit that referenced this pull request Jan 30, 2019

@bors
Auto merge of #57995 - Centril:rollup, r=Centril 
Rollup of 6 pull requests

Successful merges:

 - #57008 (suggest `|` when `,` founds in invalid match value)
 - #57106 (Mark str::trim.* functions as #[must_use].)
 - #57920 (use `SOURCE_DATE_EPOCH` for man page time if set)
 - #57934 (Introduce into_raw_non_null on Rc and Arc)
 - #57971 (SGX target: improve panic & exit handling)
 - #57980 (Add the edition guide to the bookshelf)

Failed merges:

r? @ghost
Loading status checks…
2a7ef24

Centril added a commit to Centril/rust that referenced this pull request Jan 30, 2019

@Centril
Rollup merge of rust-lang#57980 - siddharthasahu:patch-1, r=QuietMisd… 
…reavus

Add the edition guide to the bookshelf
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
20fcb16

Centril added a commit to Centril/rust that referenced this pull request Jan 30, 2019

@Centril
Rollup merge of rust-lang#57980 - siddharthasahu:patch-1, r=QuietMisd… 
…reavus

Add the edition guide to the bookshelf
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
776ac40

@Centril Centril referenced this pull request Jan 30, 2019

Closed

Rollup of 12 pull requests #58014

bors added a commit that referenced this pull request Jan 30, 2019

@bors
Auto merge of #58014 - Centril:rollup, r=Centril 
Rollup of 12 pull requests

Successful merges:

 - #57008 (suggest `|` when `,` founds in invalid match value)
 - #57106 (Mark str::trim.* functions as #[must_use].)
 - #57920 (use `SOURCE_DATE_EPOCH` for man page time if set)
 - #57934 (Introduce into_raw_non_null on Rc and Arc)
 - #57971 (SGX target: improve panic & exit handling)
 - #57980 (Add the edition guide to the bookshelf)
 - #57984 (Improve bug message in check_ty)
 - #57987 (Fix some AArch64 typos)
 - #57999 (Add MOVBE x86 CPU feature)
 - #58000 (Fixes and cleanups)
 - #58007 (Don't panic when accessing enum variant ctor using `Self` in match)
 - #58008 (Pass correct arguments to places_conflict)

Failed merges:

r? @ghost
Loading status checks…
cc70cf9

Centril added a commit to Centril/rust that referenced this pull request Jan 31, 2019

@Centril
Rollup merge of rust-lang#57980 - siddharthasahu:patch-1, r=QuietMisd… 
…reavus

Add the edition guide to the bookshelf
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
9b3aedf

@Centril Centril referenced this pull request Jan 31, 2019

Merged

Rollup of 12 pull requests #58016

bors added a commit that referenced this pull request Jan 31, 2019

@bors
Auto merge of #58016 - Centril:rollup, r=Centril 
Rollup of 12 pull requests

Successful merges:

 - #57008 (suggest `|` when `,` founds in invalid match value)
 - #57106 (Mark str::trim.* functions as #[must_use].)
 - #57920 (use `SOURCE_DATE_EPOCH` for man page time if set)
 - #57934 (Introduce into_raw_non_null on Rc and Arc)
 - #57971 (SGX target: improve panic & exit handling)
 - #57980 (Add the edition guide to the bookshelf)
 - #57984 (Improve bug message in check_ty)
 - #57999 (Add MOVBE x86 CPU feature)
 - #58000 (Fixes and cleanups)
 - #58005 (update docs for fix_start/end_matches)
 - #58007 (Don't panic when accessing enum variant ctor using `Self` in match)
 - #58008 (Pass correct arguments to places_conflict)

Failed merges:

r? @ghost
Loading status checks…
f40aaa6

@bors bors merged commit 84a89aa into rust-lang:master Jan 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.