Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow #[repr(align(x))] on enums (#57996) #57998

Merged
merged 4 commits into from Feb 7, 2019

Conversation

Projects
None yet
9 participants
@niklasf
Copy link
Contributor

niklasf commented Jan 30, 2019

Tracking issue: #57996

Implements an extension of RFC 1358 behind a feature flag (repr_align_enum). Originally introduced here for structs: #39999.

It seems like only HIR-level changes are required, since enums are already aware of their alignment (due to alignment of their limbs).

cc @bitshifter

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jan 30, 2019

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Jan 31, 2019

@rust-highfive rust-highfive assigned nagisa and unassigned steveklabnik Jan 31, 2019

@Centril Centril removed the I-nominated label Jan 31, 2019

@aturon

This comment has been minimized.

Copy link
Member

aturon commented Jan 31, 2019

We discussed this PR briefly in the Lang Team meeting today. Folks generally feel comfortable with this addition (especially since it's unstable). The one question was: is this equivalent to wrapping in a struct with an alignment? Modulo clarifying that part of the spec, we are 👍

@niklasf

This comment has been minimized.

Copy link
Contributor Author

niklasf commented Jan 31, 2019

Awesome.

is this equivalent to wrapping in a struct with an alignment?

Yes, that is the intent. I added this to the docs.

@Centril Centril removed the T-lang label Jan 31, 2019

@nagisa

This comment has been minimized.

Copy link
Contributor

nagisa commented Feb 1, 2019

This needs a codegen test IMO. Otherwise looks good.

@niklasf

This comment has been minimized.

Copy link
Contributor Author

niklasf commented Feb 1, 2019

Makes sense. Added a very basic codegen test (a6fd6ec).

@nagisa

This comment has been minimized.

Copy link
Contributor

nagisa commented Feb 5, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 5, 2019

📌 Commit a6fd6ec has been approved by nagisa

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 6, 2019

⌛️ Testing commit a6fd6ec with merge ff672da...

bors added a commit that referenced this pull request Feb 6, 2019

Auto merge of #57998 - niklasf:align-enum, r=nagisa
Allow #[repr(align(x))] on enums (#57996)

Tracking issue: #57996

Implements an extension of [RFC 1358](https://github.com/rust-lang/rfcs/blob/master/text/1358-repr-align.md) behind a feature flag (`repr_align_enum`). Originally introduced here for structs: #39999.

It seems like only HIR-level changes are required, since enums are already aware of their alignment (due to alignment of their limbs).

cc @bitshifter
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 6, 2019

💔 Test failed - status-appveyor

@kennytm

This comment has been minimized.

Copy link
Member

kennytm commented Feb 6, 2019

@bors retry #58025

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 6, 2019

⌛️ Testing commit a6fd6ec with merge 631a162...

bors added a commit that referenced this pull request Feb 6, 2019

Auto merge of #57998 - niklasf:align-enum, r=nagisa
Allow #[repr(align(x))] on enums (#57996)

Tracking issue: #57996

Implements an extension of [RFC 1358](https://github.com/rust-lang/rfcs/blob/master/text/1358-repr-align.md) behind a feature flag (`repr_align_enum`). Originally introduced here for structs: #39999.

It seems like only HIR-level changes are required, since enums are already aware of their alignment (due to alignment of their limbs).

cc @bitshifter
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 6, 2019

💔 Test failed - status-appveyor

@kennytm

This comment has been minimized.

Copy link
Member

kennytm commented Feb 6, 2019

@bors retry #58160

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 7, 2019

⌛️ Testing commit a6fd6ec with merge 825f355...

bors added a commit that referenced this pull request Feb 7, 2019

Auto merge of #57998 - niklasf:align-enum, r=nagisa
Allow #[repr(align(x))] on enums (#57996)

Tracking issue: #57996

Implements an extension of [RFC 1358](https://github.com/rust-lang/rfcs/blob/master/text/1358-repr-align.md) behind a feature flag (`repr_align_enum`). Originally introduced here for structs: #39999.

It seems like only HIR-level changes are required, since enums are already aware of their alignment (due to alignment of their limbs).

cc @bitshifter
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 7, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: nagisa
Pushing 825f355 to master...

@bors bors merged commit a6fd6ec into rust-lang:master Feb 7, 2019

1 check passed

homu Test successful
Details

@bors bors referenced this pull request Feb 7, 2019

Open

Object safe for dispatch #57545

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.