New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize std::error::Error::type_id #58048

Merged
merged 1 commit into from Feb 2, 2019

Conversation

Projects
None yet
4 participants
@SimonSapin
Copy link
Contributor

SimonSapin commented Feb 1, 2019

This should have been part of #57834

FCP: #27745 (comment)

Stabilize std::error::Error::type_id
This should have been part of #57834

FCP: #27745 (comment)
@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Feb 1, 2019

r? @Centril

@bors r+ rollup

@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Feb 1, 2019

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 1, 2019

📌 Commit cc1e05f has been approved by Centril

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 2, 2019

⌛️ Testing commit cc1e05f with merge 3d35a9b...

bors added a commit that referenced this pull request Feb 2, 2019

Auto merge of #58048 - SimonSapin:error_type_id, r=Centril
Stabilize std::error::Error::type_id

This should have been part of #57834

FCP: #27745 (comment)
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 2, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Centril
Pushing 3d35a9b to master...

@bors bors merged commit cc1e05f into rust-lang:master Feb 2, 2019

1 check passed

homu Test successful
Details
@@ -197,9 +197,7 @@ pub trait Error: Debug + Display {

/// Get the `TypeId` of `self`
#[doc(hidden)]

This comment has been minimized.

@sfackler

sfackler Feb 10, 2019

Member

We should remove the doc(hidden), right?

This comment has been minimized.

@SimonSapin

SimonSapin Feb 10, 2019

Author Contributor

Hmm that’s a good point. Why was this hidden in the first place? It has been since the method was first added in #24793. @aturon, do you remember?

@SimonSapin SimonSapin deleted the SimonSapin:error_type_id branch Feb 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment