Join GitHub today
deprecate before_exec in favor of unsafe pre_exec #58059
Thanks for this @RalfJung!
In terms of rollout I think we'll want to schedule this to be stabilized in the future when the replacement,
In the documentation of
For other small pieces, could the formatting be updated where necessary to account for this change? There's a few argument lists out of sync and the tests aren't quite indented in an idiomatic way.
For the actual name itself and the plan, let's...
@rfcbot fcp merge
Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged team members:
No concerns currently listed.
Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!
See this document for info about what commands tagged team members can give me.
So I should change
It already says that this is deprecated? I clarified the wording a bit, but I do not understand what you are asking here.
I do not see it, what are you referring to?
I ran rustfmt.
alexcrichton left a comment
That's at least what I'm led to believe! We can always tweak it if this ends up not being the case.
Er sorry what I mean is to label it as "schedule to be deprecated" as we're going to have a number of months before it's actually deprecated, and I figured it'd be good to head off any confused users asking why it says it's deprecated but it's not actually labled or warned as deprecated yet.
AFAIK this will be labelled as deprecated in the docs even if the version is still in the future. That's the point, actually: so that people read the docs do not add new uses.
So, this shouldn't be confusing.
added a commit
this pull request
Feb 15, 2019
Click to expand the log.