Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message and docs for non-UTF-8 bytes in stdio on Windows #58136

Merged
merged 1 commit into from Feb 7, 2019

Conversation

Projects
None yet
5 participants
@abonander
Copy link
Contributor

abonander commented Feb 4, 2019

This should make debugging problems like abonander/multipart#106 significantly more straightforward in the future.

cc #23344, @retep998 @alexcrichton

Not sure who do r? so I'll let rust-highfive pick one.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Feb 4, 2019

r? @dtolnay

(rust_highfive has picked a reviewer for you, use r? to override)

@abonander abonander force-pushed the abonander:doc-win-stdio-unicode branch from 7cfc1c3 to 27c8dfd Feb 4, 2019

@abonander abonander changed the title Improve error message and docs for writing non-UTF-8 bytes to stdio on Windows Improve error message and docs for non-UTF-8 bytes in stdio on Windows Feb 4, 2019

@dtolnay

dtolnay approved these changes Feb 6, 2019

Copy link
Member

dtolnay left a comment

Thanks!

@dtolnay

This comment has been minimized.

Copy link
Member

dtolnay commented Feb 6, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 6, 2019

📌 Commit 27c8dfd has been approved by dtolnay

@abonander

This comment has been minimized.

Copy link
Contributor Author

abonander commented Feb 6, 2019

@dtolnay this does touch the docs for all the stdio types and module functions. I expected to bikeshed the wording a little though I'm satisfied with it myself.

@dtolnay

This comment has been minimized.

Copy link
Member

dtolnay commented Feb 6, 2019

I think the wording is okay too. Feel free to r? another reviewer if you'd like a third opinion.

@abonander

This comment has been minimized.

Copy link
Contributor Author

abonander commented Feb 6, 2019

No, if you think it's fine then by all means. I just haven't had a PR merged without nits before so I was a bit thrown off.

kennytm added a commit to kennytm/rust that referenced this pull request Feb 7, 2019

Rollup merge of rust-lang#58136 - abonander:doc-win-stdio-unicode, r=…
…dtolnay

Improve error message and docs for non-UTF-8 bytes in stdio on Windows

This should make debugging problems like abonander/multipart#106 significantly more straightforward in the future.

cc rust-lang#23344, @retep998 @alexcrichton

Not sure who do r? so I'll let rust-highfive pick one.

bors added a commit that referenced this pull request Feb 7, 2019

Auto merge of #58254 - kennytm:rollup, r=kennytm
Rollup of 23 pull requests

Successful merges:

 - #58118 (Transition libtest to 2018 edition)
 - #58119 (libproc_macro => 2018)
 - #58123 (Avoid some bounds checks in binary_heap::{PeekMut,Hole})
 - #58124 (libsyntax_pos => 2018)
 - #58133 (libsyntax_ext => 2018)
 - #58136 (Improve error message and docs for non-UTF-8 bytes in stdio on Windows)
 - #58156 (update submodule: rust-installer from 27dec6c to ccdc47b)
 - #58192 (Do not ICE in codegen when using a extern_type static)
 - #58193 (Move librustc to 2018)
 - #58210 (Make an assert debug-only in `find_constraint_paths_between_regions`.)
 - #58217 (librustc_tsan => 2018)
 - #58218 (librustc_msan => 2018)
 - #58219 (librustc_asan => 2018)
 - #58220 (libprofiler_builtins => 2018)
 - #58223 (librustc_lsan => 2018)
 - #58225 (librustc_fs_util => 2018)
 - #58228 (librustc_plugin => 2018)
 - #58236 (librustc_resolve => 2018)
 - #58237 (Fix broken grammar in iter::from_fn() docs)
 - #58239 (librustc_apfloat => 2018)
 - #58240 (librustc_errors => 2018)
 - #58241 (librustc_llvm => 2018)
 - #58242 (Document the one TyKind that isn't documented)

Failed merges:

 - #58185 (Remove images' url to make it work even without internet connection)

r? @ghost

@bors bors merged commit 27c8dfd into rust-lang:master Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.