New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EraseRegionsVisitor since mir implements TypeFoldable #58187

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@spastorino
Copy link
Member

spastorino commented Feb 5, 2019

r? @nikomatsakis /cc @arielb1

@Zoxc

This comment has been minimized.

Copy link
Contributor

Zoxc commented Feb 5, 2019

This does look less efficient since that visitor just mutates the Mir.

@Zoxc

This comment has been minimized.

Copy link
Contributor

Zoxc commented Feb 5, 2019

@bors try

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 5, 2019

⌛️ Trying commit d18d614 with merge 57090e4...

bors added a commit that referenced this pull request Feb 5, 2019

Auto merge of #58187 - spastorino:remove_erase_regions_visitor, r=<try>
Remove EraseRegionsVisitor since mir implements TypeFoldable

r? @nikomatsakis /cc @arielb1
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 6, 2019

☀️ Test successful - checks-travis
State: approved= try=True

@Zoxc

This comment has been minimized.

Copy link
Contributor

Zoxc commented Feb 6, 2019

@rust-timer

This comment has been minimized.

Copy link

rust-timer commented Feb 6, 2019

Success: Queued 57090e4 with parent 4b1e39b, comparison URL.

@rust-timer

This comment has been minimized.

Copy link

rust-timer commented Feb 6, 2019

Finished benchmarking try commit 57090e4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment