New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest removing parentheses surrounding lifetimes #58198

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@igorsdv
Copy link

igorsdv commented Feb 5, 2019

Fixes #57386.

r? @estebank

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Feb 5, 2019

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Feb 5, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:0cdf709e:start=1549400769581177439,finish=1549400770575416737,duration=994239298
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[00:05:55] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "--message-format" "json"
[00:05:55] expected success, got: exit code: 101
[00:05:55] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap build
[00:05:55] Build completed unsuccessfully in 0:02:16
[00:05:55] make: *** [all] Error 1
[00:05:55] Makefile:18: recipe for target 'all' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:2171e9b8
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Tue Feb  5 21:12:17 UTC 2019
---
travis_time:end:07365b64:start=1549401138518453108,finish=1549401138522788058,duration=4334950
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:2dbcffcc
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:1b196104
travis_time:start:1b196104
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:06ee5903
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Show resolved Hide resolved src/libsyntax/parse/parser.rs Outdated

@igorsdv igorsdv force-pushed the igorsdv:suggest-removing-parentheses-surrounding-lifetimes branch from 7db8c28 to f753d30 Feb 7, 2019

@oli-obk

This comment has been minimized.

Copy link
Contributor

oli-obk commented Feb 18, 2019

@bors r=estebank rollup

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 18, 2019

📌 Commit f753d30 has been approved by estebank

@oli-obk

This comment has been minimized.

Copy link
Contributor

oli-obk commented Feb 18, 2019

@igorsdv Unfortunately github does not send us notifications when a PR has been force pushed. In order to get a faster review after force pushing, you can leave a comment on the PR.

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Feb 18, 2019

Rollup merge of rust-lang#58198 - igorsdv:suggest-removing-parenthese…
…s-surrounding-lifetimes, r=estebank

Suggest removing parentheses surrounding lifetimes

Fixes rust-lang#57386.

r? @estebank

bors added a commit that referenced this pull request Feb 19, 2019

Auto merge of #58566 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
Rollup of 16 pull requests

Successful merges:

 - #55632 (Deny the `overflowing_literals` lint for all editions)
 - #56470 (Modify doctest's auto-`fn main()` to allow `Result`s)
 - #58198 (Suggest removing parentheses surrounding lifetimes)
 - #58199 (Add better error message for partial move)
 - #58303 (Improve stability tags display)
 - #58336 (Fix search results interactions)
 - #58392 (Use less explicit shifting in std::net::ip)
 - #58528 (Don't use an allocation for ItemId in StmtKind)
 - #58530 (Monomorphize less code in fs::{read|write})
 - #58534 (Mention capping forbid lints)
 - #58536 (Remove UB in pointer tests)
 - #58539 (Add alias methods to PathBuf for underlying OsString (#58234))
 - #58544 (Fix doc for rustc "-g" flag)
 - #58545 (Add regression test for a specialization-related ICE (#39448))
 - #58551 (Explain a panic in test case net::tcp::tests::double_bind )
 - #58555 (Add a note about 2018e if someone uses `try {` in 2015e)

Failed merges:

r? @ghost

bors added a commit that referenced this pull request Feb 19, 2019

Auto merge of #58566 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
Rollup of 16 pull requests

Successful merges:

 - #55632 (Deny the `overflowing_literals` lint for all editions)
 - #56470 (Modify doctest's auto-`fn main()` to allow `Result`s)
 - #58198 (Suggest removing parentheses surrounding lifetimes)
 - #58199 (Add better error message for partial move)
 - #58303 (Improve stability tags display)
 - #58336 (Fix search results interactions)
 - #58392 (Use less explicit shifting in std::net::ip)
 - #58528 (Don't use an allocation for ItemId in StmtKind)
 - #58530 (Monomorphize less code in fs::{read|write})
 - #58534 (Mention capping forbid lints)
 - #58536 (Remove UB in pointer tests)
 - #58539 (Add alias methods to PathBuf for underlying OsString (#58234))
 - #58544 (Fix doc for rustc "-g" flag)
 - #58545 (Add regression test for a specialization-related ICE (#39448))
 - #58551 (Explain a panic in test case net::tcp::tests::double_bind )
 - #58555 (Add a note about 2018e if someone uses `try {` in 2015e)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Feb 20, 2019

Rollup merge of rust-lang#58198 - igorsdv:suggest-removing-parenthese…
…s-surrounding-lifetimes, r=estebank

Suggest removing parentheses surrounding lifetimes

Fixes rust-lang#57386.

r? @estebank

bors added a commit that referenced this pull request Feb 20, 2019

Auto merge of #58594 - Centril:rollup, r=Centril
Rollup of 12 pull requests

Successful merges:

 - #55632 (Deny the `overflowing_literals` lint for all editions)
 - #57656 (Deprecate the unstable Vec::resize_default)
 - #57997 (Wrap write_bytes in a function. Move docs)
 - #58059 (deprecate before_exec in favor of unsafe pre_exec)
 - #58122 (RangeInclusive internal iteration performance improvement.)
 - #58198 (Suggest removing parentheses surrounding lifetimes)
 - #58353 (Check the Self-type of inherent associated constants)
 - #58476 (Remove `LazyTokenStream`.)
 - #58511 (Const to op simplification)
 - #58555 (Add a note about 2018e if someone uses `try {` in 2015e)
 - #58588 (remove a bit of dead code)
 - #58589 (cleanup macro after 2018 transition)

Failed merges:

r? @ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment