New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated RELEASES.md for 1.33.0 #58227

Open
wants to merge 13 commits into
base: master
from

Conversation

@Aaronepower
Copy link
Contributor

Aaronepower commented Feb 6, 2019

Show resolved Hide resolved RELEASES.md Outdated
Show resolved Hide resolved RELEASES.md Outdated
Show resolved Hide resolved RELEASES.md Outdated
Show resolved Hide resolved RELEASES.md
Show resolved Hide resolved RELEASES.md Outdated
Show resolved Hide resolved RELEASES.md Outdated
Show resolved Hide resolved RELEASES.md Outdated
Show resolved Hide resolved RELEASES.md Outdated
Update RELEASES.md
Co-Authored-By: Aaronepower <Aaronepower@users.noreply.github.com>
Show resolved Hide resolved RELEASES.md Outdated
Show resolved Hide resolved RELEASES.md Outdated
Show resolved Hide resolved RELEASES.md Outdated
Show resolved Hide resolved RELEASES.md Outdated
Show resolved Hide resolved RELEASES.md Outdated
Show resolved Hide resolved RELEASES.md Outdated
Show resolved Hide resolved RELEASES.md Outdated
Show resolved Hide resolved RELEASES.md Outdated
Show resolved Hide resolved RELEASES.md
Show resolved Hide resolved RELEASES.md
@imp

This comment has been minimized.

Copy link

imp commented Feb 12, 2019

Shouldn't this mention a deprecation for trim_left, trim_right, trim_left_matches and trim_right_matches?

Centril and others added some commits Feb 12, 2019

Update RELEASES.md
Co-Authored-By: Aaronepower <Aaronepower@users.noreply.github.com>
Update RELEASES.md
Co-Authored-By: Aaronepower <Aaronepower@users.noreply.github.com>
Update RELEASES.md
Co-Authored-By: Aaronepower <Aaronepower@users.noreply.github.com>
Update RELEASES.md
Co-Authored-By: Aaronepower <Aaronepower@users.noreply.github.com>
Show resolved Hide resolved RELEASES.md Outdated
@lzutao

This comment has been minimized.

Copy link
Contributor

lzutao commented Feb 12, 2019

I think using passive voice is more appropriate. For example, change

You can now import an item from a module as an _.

to

Item from a module can now be imported as an _.

@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Feb 12, 2019

We use active voice everywhere else so we should stick to it; moreover, if you say "Item..." you need to say "An item..." or "Items from modules...".

Update RELEASES.md
Co-Authored-By: Aaronepower <Aaronepower@users.noreply.github.com>
@Aaronepower

This comment has been minimized.

Copy link
Contributor Author

Aaronepower commented Feb 13, 2019

@lzutao Using an active voice also more clearly shows that the RELEASES.md document is an editorialized list of what the Rust team thinks people should know about, which is not definitive list of every contribution to the release itself.

Aaronepower added some commits Feb 20, 2019

Show resolved Hide resolved RELEASES.md Outdated
Update RELEASES.md
Co-Authored-By: Aaronepower <Aaronepower@users.noreply.github.com>
Show resolved Hide resolved RELEASES.md Outdated
Show resolved Hide resolved RELEASES.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment