Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated RELEASES.md for 1.33.0 #58227

Merged
merged 14 commits into from Feb 23, 2019

Conversation

Reviewers

@nikic nikic

@Centril Centril

@jethrogb jethrogb

@jonas-schievink jonas-schievink

@Mark-Simulacrum Mark-Simulacrum

@mark-i-m mark-i-m

@niklasad1 niklasad1

@tspiteri tspiteri

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors T-release beta-accepted
Projects
None yet
Milestone
No milestone
@XAMPPRocky
Copy link
Contributor

XAMPPRocky commented Feb 6, 2019

Rendered

r? @Mark-Simulacrum

cc @rust-lang/release
@XAMPPRocky
Updated RELEASES.md for 1.33.0
Loading status checks…
50be479

@rust-highfive rust-highfive assigned Mark-Simulacrum Feb 6, 2019

@rust-highfive rust-highfive added the S-waiting-on-review label Feb 6, 2019

@Mark-Simulacrum

Mark-Simulacrum reviewed Feb 6, 2019
View changes

Show resolved Hide resolved RELEASES.md Outdated
@jonas-schievink

jonas-schievink reviewed Feb 6, 2019
View changes

Show resolved Hide resolved RELEASES.md Outdated
Show resolved Hide resolved RELEASES.md Outdated
Show resolved Hide resolved RELEASES.md
Show resolved Hide resolved RELEASES.md Outdated
Aaron Power
Update RELEASES.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6c71e7d
@mark-i-m

mark-i-m reviewed Feb 7, 2019
View changes

Show resolved Hide resolved RELEASES.md Outdated
@nikic

nikic reviewed Feb 7, 2019
View changes

Show resolved Hide resolved RELEASES.md Outdated

@kennytm kennytm added the beta-nominated label Feb 8, 2019

@pietroalbini pietroalbini added beta-accepted T-release labels Feb 8, 2019

@tspiteri

tspiteri reviewed Feb 8, 2019
View changes

Show resolved Hide resolved RELEASES.md Outdated
@mark-i-m Aaronepower
Update RELEASES.md 
Co-Authored-By: Aaronepower <Aaronepower@users.noreply.github.com>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fb3ae57
@Centril

Centril reviewed Feb 11, 2019
View changes

Show resolved Hide resolved RELEASES.md Outdated
Show resolved Hide resolved RELEASES.md Outdated
Show resolved Hide resolved RELEASES.md Outdated
Show resolved Hide resolved RELEASES.md Outdated
Show resolved Hide resolved RELEASES.md Outdated
Show resolved Hide resolved RELEASES.md Outdated
Show resolved Hide resolved RELEASES.md Outdated
Show resolved Hide resolved RELEASES.md Outdated
Show resolved Hide resolved RELEASES.md
Show resolved Hide resolved RELEASES.md
@imp

This comment has been minimized.

Sign in to view
Copy link

imp commented Feb 12, 2019

Shouldn't this mention a deprecation for trim_left, trim_right, trim_left_matches and trim_right_matches?

Centril and others added some commits Feb 12, 2019

@Centril Aaronepower
Update RELEASES.md 
Co-Authored-By: Aaronepower <Aaronepower@users.noreply.github.com>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
73921f6
@Centril Aaronepower
Update RELEASES.md 
Co-Authored-By: Aaronepower <Aaronepower@users.noreply.github.com>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8a026f1
@Centril Aaronepower
Update RELEASES.md 
Co-Authored-By: Aaronepower <Aaronepower@users.noreply.github.com>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4c0a3d5
@Centril Aaronepower
Update RELEASES.md 
Co-Authored-By: Aaronepower <Aaronepower@users.noreply.github.com>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ee3371e
@Centril

Centril reviewed Feb 12, 2019
View changes

Show resolved Hide resolved RELEASES.md Outdated
@lzutao

This comment has been minimized.

Sign in to view
Copy link
Contributor

lzutao commented Feb 12, 2019

I think using passive voice is more appropriate. For example, change

You can now import an item from a module as an _.

to

Item from a module can now be imported as an _.
@Centril

This comment has been minimized.

Sign in to view
Copy link
Contributor

Centril commented Feb 12, 2019 •
edited

We use active voice everywhere else so we should stick to it; moreover, if you say "Item..." you need to say "An item..." or "Items from modules...".
@Centril Aaronepower
Update RELEASES.md 
Co-Authored-By: Aaronepower <Aaronepower@users.noreply.github.com>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a496450
@XAMPPRocky

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

XAMPPRocky commented Feb 13, 2019

@lzutao Using an active voice also more clearly shows that the RELEASES.md document is an editorialized list of what the Rust team thinks people should know about, which is not definitive list of every contribution to the release itself.

Aaron Power added some commits Feb 20, 2019

Aaron Power
Update RELEASES.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2621564
Aaron Power
Update RELEASES.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d072510
@tspiteri

tspiteri reviewed Feb 20, 2019
View changes

Show resolved Hide resolved RELEASES.md Outdated
@tspiteri Aaronepower
Update RELEASES.md 
Co-Authored-By: Aaronepower <Aaronepower@users.noreply.github.com>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
42d749c
@Centril

Centril reviewed Feb 20, 2019
View changes

Show resolved Hide resolved RELEASES.md Outdated
Aaron Power
Update RELEASES.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8060eb4

Aaron Power and others added some commits Feb 21, 2019

Aaron Power
Update RELEASES.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0ab2aed
@Centril
Update RELEASES.md
Loading status checks…
fda51c2
@Centril

This comment has been minimized.

Sign in to view
Copy link
Contributor

Centril commented Feb 22, 2019

@bors r+ p=9
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Feb 22, 2019

📌 Commit fda51c2 has been approved by Centril

@bors bors added S-waiting-on-bors and removed S-waiting-on-review labels Feb 22, 2019

@Centril Centril referenced this pull request Feb 22, 2019

Closed

[BETA] Universe leak check #58641

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Feb 22, 2019

@XAMPPRocky @Mark-Simulacrum
Updated RELEASES.md for 1.33.0 
Cherry-picked (and squashed) from rust-lang#58227.
60477e7

@Mark-Simulacrum Mark-Simulacrum referenced this pull request Feb 22, 2019

Merged

Beta rollups #58656

@pietroalbini pietroalbini removed the beta-nominated label Feb 22, 2019

bors added a commit that referenced this pull request Feb 22, 2019

@bors
Auto merge of #58656 - Mark-Simulacrum:beta-rollups, r=pietroalbini 
Beta rollups

 - #58649
 - #58592
 - #58574
 - #58227
 - #58056
 - #57859
 - #57710

A few of these are via #58641.

r? @pietroalbini
Loading status checks…
864a406

nikomatsakis added a commit to Mark-Simulacrum/rust that referenced this pull request Feb 22, 2019

@XAMPPRocky @nikomatsakis
Updated RELEASES.md for 1.33.0 
Cherry-picked (and squashed) from rust-lang#58227.
fdd5467

bors added a commit that referenced this pull request Feb 23, 2019

@bors
Auto merge of #58656 - Mark-Simulacrum:beta-rollups, r=pietroalbini 
Beta rollups

 - #58649
 - #58592
 - #58574
 - #58227
 - #58056
 - #57859
 - #57710

A few of these are via #58641.

r? @pietroalbini
Loading status checks…
bb2d0ea
@Centril

This comment has been minimized.

Sign in to view
Copy link
Contributor

Centril commented Feb 23, 2019

@bors p=0

Will include in a rollup.

Centril added a commit to Centril/rust that referenced this pull request Feb 23, 2019

@Centril
Rollup merge of rust-lang#58227 - Aaronepower:master, r=Centril 
Updated RELEASES.md for 1.33.0

[Rendered](https://github.com/Aaronepower/rust/blob/master/RELEASES.md)

r? @Mark-Simulacrum

cc @rust-lang/release
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
fc517c7

@Centril Centril referenced this pull request Feb 23, 2019

Closed

Rollup of 16 pull requests #58665

bors added a commit that referenced this pull request Feb 23, 2019

@bors
Auto merge of #58665 - Centril:rollup, r=Centril 
Rollup of 16 pull requests

Successful merges:

 - #58122 (RangeInclusive internal iteration performance improvement.)
 - #58199 (Add better error message for partial move)
 - #58216 ( Set secure flags when opening a named pipe on Windows )
 - #58227 (Updated RELEASES.md for 1.33.0)
 - #58353 (Check the Self-type of inherent associated constants)
 - #58453 (SGX target: fix panic = abort)
 - #58454 (Refactor Windows stdio and remove stdin double buffering )
 - #58476 (Remove `LazyTokenStream`.)
 - #58526 (Special suggestion for illegal unicode curly quote pairs)
 - #58595 (Turn duration consts into associated consts)
 - #58609 (Allow Self::Module to be mutated.)
 - #58628 (Optimise vec![false; N] to zero-alloc)
 - #58642 (rustdoc: support methods on primitives in intra-doc links)
 - #58643 (Don't generate minification variables if minification disabled)
 - #58648 (Update tests to account for cross-platform testing and miri.)
 - #58654 (Do not underflow after resetting unmatched braces count)

Failed merges:

r? @ghost
Loading status checks…
3c5b77f

Centril added a commit to Centril/rust that referenced this pull request Feb 23, 2019

@Centril
Rollup merge of rust-lang#58227 - Aaronepower:master, r=Centril 
Updated RELEASES.md for 1.33.0

[Rendered](https://github.com/Aaronepower/rust/blob/master/RELEASES.md)

r? @Mark-Simulacrum

cc @rust-lang/release
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
3cf56ef

@Centril Centril referenced this pull request Feb 23, 2019

Closed

Rollup of 15 pull requests #58666

bors added a commit that referenced this pull request Feb 23, 2019

@bors
Auto merge of #58666 - Centril:rollup, r=Centril 
Rollup of 15 pull requests

Successful merges:

 - #58122 (RangeInclusive internal iteration performance improvement.)
 - #58199 (Add better error message for partial move)
 - #58216 ( Set secure flags when opening a named pipe on Windows )
 - #58227 (Updated RELEASES.md for 1.33.0)
 - #58353 (Check the Self-type of inherent associated constants)
 - #58453 (SGX target: fix panic = abort)
 - #58476 (Remove `LazyTokenStream`.)
 - #58526 (Special suggestion for illegal unicode curly quote pairs)
 - #58595 (Turn duration consts into associated consts)
 - #58609 (Allow Self::Module to be mutated.)
 - #58628 (Optimise vec![false; N] to zero-alloc)
 - #58642 (rustdoc: support methods on primitives in intra-doc links)
 - #58643 (Don't generate minification variables if minification disabled)
 - #58648 (Update tests to account for cross-platform testing and miri.)
 - #58654 (Do not underflow after resetting unmatched braces count)

Failed merges:

r? @ghost
Loading status checks…
b7c23ce

Centril added a commit to Centril/rust that referenced this pull request Feb 23, 2019

@Centril
Rollup merge of rust-lang#58227 - Aaronepower:master, r=Centril 
Updated RELEASES.md for 1.33.0

[Rendered](https://github.com/Aaronepower/rust/blob/master/RELEASES.md)

r? @Mark-Simulacrum

cc @rust-lang/release
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
7c226e4

@Centril Centril referenced this pull request Feb 23, 2019

Closed

Rollup of 16 pull requests #58668

Centril added a commit to Centril/rust that referenced this pull request Feb 23, 2019

@Centril
Rollup merge of rust-lang#58227 - Aaronepower:master, r=Centril 
Updated RELEASES.md for 1.33.0

[Rendered](https://github.com/Aaronepower/rust/blob/master/RELEASES.md)

r? @Mark-Simulacrum

cc @rust-lang/release
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
abd6f50

@Centril Centril referenced this pull request Feb 23, 2019

Merged

Rollup of 16 pull requests #58669

bors added a commit that referenced this pull request Feb 23, 2019

@bors
Auto merge of #58669 - Centril:rollup, r=Centril 
Rollup of 16 pull requests

Successful merges:

 - #58100 (Transition librustdoc to Rust 2018)
 - #58122 (RangeInclusive internal iteration performance improvement.)
 - #58199 (Add better error message for partial move)
 - #58227 (Updated RELEASES.md for 1.33.0)
 - #58353 (Check the Self-type of inherent associated constants)
 - #58453 (SGX target: fix panic = abort)
 - #58476 (Remove `LazyTokenStream`.)
 - #58526 (Special suggestion for illegal unicode curly quote pairs)
 - #58595 (Turn duration consts into associated consts)
 - #58609 (Allow Self::Module to be mutated.)
 - #58628 (Optimise vec![false; N] to zero-alloc)
 - #58643 (Don't generate minification variables if minification disabled)
 - #58648 (Update tests to account for cross-platform testing and miri.)
 - #58654 (Do not underflow after resetting unmatched braces count)
 - #58658 (Add expected/provided byte alignments to validation error message)
 - #58667 (Reduce Miri-related Code Repetition `like (n << amt) >> amt`)

Failed merges:

r? @ghost
Loading status checks…
103db7f

bors added a commit that referenced this pull request Feb 23, 2019

@bors
Auto merge of #58669 - Centril:rollup, r=Centril 
Rollup of 16 pull requests

Successful merges:

 - #58100 (Transition librustdoc to Rust 2018)
 - #58122 (RangeInclusive internal iteration performance improvement.)
 - #58199 (Add better error message for partial move)
 - #58227 (Updated RELEASES.md for 1.33.0)
 - #58353 (Check the Self-type of inherent associated constants)
 - #58453 (SGX target: fix panic = abort)
 - #58476 (Remove `LazyTokenStream`.)
 - #58526 (Special suggestion for illegal unicode curly quote pairs)
 - #58595 (Turn duration consts into associated consts)
 - #58609 (Allow Self::Module to be mutated.)
 - #58628 (Optimise vec![false; N] to zero-alloc)
 - #58643 (Don't generate minification variables if minification disabled)
 - #58648 (Update tests to account for cross-platform testing and miri.)
 - #58654 (Do not underflow after resetting unmatched braces count)
 - #58658 (Add expected/provided byte alignments to validation error message)
 - #58667 (Reduce Miri-related Code Repetition `like (n << amt) >> amt`)

Failed merges:

r? @ghost
Loading status checks…
7f19f16

@bors bors merged commit fda51c2 into rust-lang:master Feb 23, 2019

@jethrogb

jethrogb reviewed Feb 26, 2019
View changes

RELEASES.md
Language
--------
- [You can now use the `cfg(target_vendor)` attribute.][57465] E.g.
`#[cfg(target_vendor="linux")] fn main() { println!("Hello Linux!"); }`

This comment has been minimized.

Sign in to view
Copy link
@jethrogb

jethrogb Feb 26, 2019

Contributor

I don't think this example makes sense. Maybe use one of the vendors shown in the reference?

This comment has been minimized.

Sign in to view
Copy link
@Centril

Centril Feb 26, 2019

Contributor

cc @Mark-Simulacrum -- presumably we don't want to change this now because we already promoted beta=>stable... but we could merge it into nightly for posterity?

This comment has been minimized.

Sign in to view
Copy link
@Mark-Simulacrum

Mark-Simulacrum Feb 26, 2019

Member

PRs are welcome!
@niklasad1

niklasad1 reviewed Feb 26, 2019
View changes

RELEASES.md

Compatibility Notes
-------------------
- The methods `str::{trim_left, trim_right, trim_left_matches, trim_right_matches}`

This comment has been minimized.

Sign in to view
Copy link
@niklasad1

niklasad1 Feb 26, 2019 •
edited

Well, I think it is also worth mentioning #[rustc_deprecated(since = "1.33.0", reason = "replaced by Error::source, which can support downcasting

@Centril Centril referenced this pull request Feb 28, 2019

Closed

Update RELEASES to include missing feature #58790

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.