New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add librustc, librustc_plugin, and libsyntax to rust-src distribution. #58269

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@taeguk
Copy link

taeguk commented Feb 7, 2019

Fixes #58268.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Feb 7, 2019

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@oli-obk

This comment has been minimized.

Copy link
Contributor

oli-obk commented Feb 7, 2019

cc @rust-lang/compiler

@eddyb has concerns about including the plugin crate

@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Feb 8, 2019

It doesn't seem like a good idea to facilitate using librustc_plugin more in user-space.

@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Feb 8, 2019

r? @eddyb

@rust-highfive rust-highfive assigned eddyb and unassigned alexcrichton Feb 8, 2019

@eddyb

This comment has been minimized.

Copy link
Member

eddyb commented Feb 13, 2019

Yeah, my question is why librustc_plugin specifically? Everything else makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment