Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign uprustc_codegen_llvm: use opaque LLVM structs for `extern type`. #58271
Conversation
rust-highfive
assigned
matthewjasper
Feb 7, 2019
This comment has been minimized.
This comment has been minimized.
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
label
Feb 7, 2019
This comment has been minimized.
This comment has been minimized.
@bors try |
This comment has been minimized.
This comment has been minimized.
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This comment has been minimized.
This comment has been minimized.
added a commit
that referenced
this pull request
Feb 7, 2019
This comment has been minimized.
This comment has been minimized.
|
bors
added
S-waiting-on-author
and removed
S-waiting-on-review
labels
Feb 7, 2019
This comment has been minimized.
This comment has been minimized.
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This comment has been minimized.
This comment has been minimized.
@Mark-Simulacrum Ohh, the coredump backtraces are nice! |
This comment has been minimized.
This comment has been minimized.
You could manually enable an ALT builder for llvm asserts, neither one that's run so far has them enabled. |
This comment has been minimized.
This comment has been minimized.
The LLVM assertion failure is:
|
eddyb commentedFeb 7, 2019
Mostly an experiment, @RalfJung suggested it could be used to inform LLVM that for e.g.:
BAR
does not have a known size, and therefore nothing can be assumed about the validity of accesses at arbitrary offsets.