New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc-workspace-hack => 2018 #58288

Merged
merged 1 commit into from Feb 12, 2019

Conversation

Projects
None yet
4 participants
@taiki-e
Copy link
Contributor

taiki-e commented Feb 8, 2019

Transitions rustc-workspace-hack to Rust 2018; cc #58099

r? @alexcrichton

@taiki-e

This comment has been minimized.

Copy link
Contributor Author

taiki-e commented Feb 8, 2019

I think that #![deny(rust_2018_idioms)] is unnecessary because lib.rs is blank and it has a comment "intentionally left blank".

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Feb 11, 2019

@bors: r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 11, 2019

📌 Commit 36806b5 has been approved by alexcrichton

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Feb 11, 2019

@bors: rollup

@Centril Centril referenced this pull request Feb 11, 2019

Open

Tracking issue for Transitioning crates to Rust 2018 #58099

72 of 77 tasks complete

Centril added a commit to Centril/rust that referenced this pull request Feb 12, 2019

Rollup merge of rust-lang#58288 - taiki-e:rustc-workspace-hack-2018, …
…r=alexcrichton

rustc-workspace-hack => 2018

Transitions `rustc-workspace-hack` to Rust 2018; cc rust-lang#58099

r? @alexcrichton

bors added a commit that referenced this pull request Feb 12, 2019

Auto merge of #58389 - Centril:rollup, r=Centril
Rollup of 11 pull requests

Successful merges:

 - #58105 (libarena => 2018)
 - #58111 (libterm => 2018)
 - #58287 (rustc-std-workspace-core => 2018)
 - #58288 (rustc-workspace-hack => 2018)
 - #58300 (librustc_typeck => 2018)
 - #58313 (Use `?` in librustc macros)
 - #58318 (libserialize => 2018)
 - #58322 (librustc_codegen_ssa => 2018)
 - #58342 (Revert removed #![feature(nll)])
 - #58367 (Remove two dead functions.)
 - #58382 (docs: remove "experimental" wording from std::os::unix)

Failed merges:

r? @ghost

@bors bors merged commit 36806b5 into rust-lang:master Feb 12, 2019

@taiki-e taiki-e deleted the taiki-e:rustc-workspace-hack-2018 branch Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment