New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librustc_typeck => 2018 #58300

Merged
merged 1 commit into from Feb 12, 2019

Conversation

Projects
None yet
6 participants
@taiki-e
Copy link
Contributor

taiki-e commented Feb 8, 2019

Transitions librustc_typeck to Rust 2018; cc #58099

TODO: elided_lifetimes_in_paths

r? @Centril

@petrochenkov

This comment has been minimized.

Copy link
Contributor

petrochenkov commented Feb 8, 2019

Any crate that uses TyCtxt more than few times should opt out of elided_lifetimes_in_paths IMO.
TyCtxt<'_, '_, '_> is not the way to go.

@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Feb 8, 2019

@petrochenkov We can leave that change out of this PR cause I just want to get all crates migrated... However, Formatter or TyCxt will become distinctly unidiomatic and hopefully quite deprecated soon and I don't think that rustc should block that.

@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Feb 8, 2019

@rust-highfive rust-highfive assigned petrochenkov and unassigned Centril Feb 8, 2019

@petrochenkov

This comment has been minimized.

Copy link
Contributor

petrochenkov commented Feb 9, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 9, 2019

📋 Looks like this PR is still in progress, ignoring approval.

Hint: Remove [WIP] from this PR's title when it is ready for review.

@petrochenkov petrochenkov changed the title [WIP] librustc_typeck => 2018 librustc_typeck => 2018 Feb 9, 2019

@petrochenkov

This comment has been minimized.

Copy link
Contributor

petrochenkov commented Feb 9, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 9, 2019

📌 Commit fe27623 has been approved by petrochenkov

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Feb 10, 2019

Rollup merge of rust-lang#58300 - taiki-e:librustc_typeck-2018, r=pet…
…rochenkov

librustc_typeck => 2018

Transitions `librustc_typeck` to Rust 2018; cc rust-lang#58099

TODO: elided_lifetimes_in_paths

r? @Centril

bors added a commit that referenced this pull request Feb 10, 2019

Auto merge of #58338 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
Rollup of 17 pull requests

Successful merges:

 - #57259 (Update reference of rlibc crate to compiler-builtins crate)
 - #57740 (Use `to_ne_bytes` for converting IPv4Addr to octets)
 - #58085 (Implement more detailed self profiling)
 - #58103 (Make -Zdump-mir dump shims)
 - #58129 (MaybeUninit: some docs, rename into_inner -> into_initialized, return &mut from set)
 - #58151 (Partially HirId-ify rustc)
 - #58152 (Partially HirIdify mir)
 - #58153 (Partially Hiridify typeck)
 - #58203 (rustdoc: display sugared return types for async functions)
 - #58258 (Reduce the size of `hir::Expr`.)
 - #58262 (Add #[must_use] message to Fn* traits)
 - #58272 (Cut down on number formating code size)
 - #58276 (Improve the error messages for missing stability attributes)
 - #58295 (std::sys::unix::stdio: explain why we do into_raw)
 - #58297 (Cleanup JS a bit)
 - #58300 (librustc_typeck => 2018)
 - #58332 (operand-to-place copies should never be overlapping)

Failed merges:

 - #58167 (HirId-ify hir::BodyId)

r? @ghost

pietroalbini added a commit to pietroalbini/rust that referenced this pull request Feb 10, 2019

Rollup merge of rust-lang#58300 - taiki-e:librustc_typeck-2018, r=pet…
…rochenkov

librustc_typeck => 2018

Transitions `librustc_typeck` to Rust 2018; cc rust-lang#58099

TODO: elided_lifetimes_in_paths

r? @Centril

bors added a commit that referenced this pull request Feb 10, 2019

Auto merge of #58348 - pietroalbini:rollup, r=pietroalbini
Rollup of 19 pull requests

Successful merges:

 - #57259 (Update reference of rlibc crate to compiler-builtins crate)
 - #57740 (Use `to_ne_bytes` for converting IPv4Addr to octets)
 - #57926 (Tiny expansion to docs for `core::convert`.)
 - #58129 (MaybeUninit: some docs, rename into_inner -> into_initialized, return &mut from set)
 - #58151 (Partially HirId-ify rustc)
 - #58152 (Partially HirIdify mir)
 - #58153 (Partially Hiridify typeck)
 - #58157 (Add Cargo.lock automatically adding message)
 - #58203 (rustdoc: display sugared return types for async functions)
 - #58262 (Add #[must_use] message to Fn* traits)
 - #58295 (std::sys::unix::stdio: explain why we do into_raw)
 - #58297 (Cleanup JS a bit)
 - #58300 (librustc_typeck => 2018)
 - #58313 (Use `?` in librustc macros)
 - #58322 (librustc_codegen_ssa => 2018)
 - #58324 (miri: give non-generic functions a stable address)
 - #58332 (operand-to-place copies should never be overlapping)
 - #58345 (When there are multiple filenames, print what got interpreted as filenames)
 - #58346 (rpath computation: explain why we pop())

Failed merges:

r? @ghost
@pietroalbini

This comment has been minimized.

Copy link
Member

pietroalbini commented Feb 11, 2019

@bors rollup

@Centril Centril referenced this pull request Feb 11, 2019

Open

Tracking issue for Transitioning crates to Rust 2018 #58099

73 of 77 tasks complete

Centril added a commit to Centril/rust that referenced this pull request Feb 12, 2019

Rollup merge of rust-lang#58300 - taiki-e:librustc_typeck-2018, r=pet…
…rochenkov

librustc_typeck => 2018

Transitions `librustc_typeck` to Rust 2018; cc rust-lang#58099

TODO: elided_lifetimes_in_paths

r? @Centril

bors added a commit that referenced this pull request Feb 12, 2019

Auto merge of #58389 - Centril:rollup, r=Centril
Rollup of 11 pull requests

Successful merges:

 - #58105 (libarena => 2018)
 - #58111 (libterm => 2018)
 - #58287 (rustc-std-workspace-core => 2018)
 - #58288 (rustc-workspace-hack => 2018)
 - #58300 (librustc_typeck => 2018)
 - #58313 (Use `?` in librustc macros)
 - #58318 (libserialize => 2018)
 - #58322 (librustc_codegen_ssa => 2018)
 - #58342 (Revert removed #![feature(nll)])
 - #58367 (Remove two dead functions.)
 - #58382 (docs: remove "experimental" wording from std::os::unix)

Failed merges:

r? @ghost

@bors bors merged commit fe27623 into rust-lang:master Feb 12, 2019

@taiki-e taiki-e deleted the taiki-e:librustc_typeck-2018 branch Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment