New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetic improvements to doc comments #58341

Merged
merged 5 commits into from Feb 12, 2019

Conversation

Projects
None yet
9 participants
@alexreg
Copy link
Contributor

alexreg commented Feb 10, 2019

This has been factored out from #58036 to only include changes to documentation comments (throughout the rustc codebase).

r? @steveklabnik

Once you're happy with this, maybe we could get it through with r=1, so it doesn't constantly get invalidated? (I'm not sure this will be an issue, but just in case...) Anyway, thanks for your advice so far!

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Feb 10, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:0fa43db4:start=1549775499837352556,finish=1549775502865067410,duration=3027714854
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[01:05:05] .................................................................................................... 2400/5380
[01:05:10] .................................................................................................... 2500/5380
[01:05:14] .................................................................................................... 2600/5380
[01:05:18] .................................................................................................... 2700/5380
[01:05:23] .............................................................................................F...... 2800/5380
[01:05:32] .................................................................................................... 3000/5380
[01:05:35] .................................................................................................... 3100/5380
[01:05:40] .................................................................................................... 3200/5380
[01:05:44] ................................i................................................................... 3300/5380
---
[01:07:13] ---- [ui] ui/issues/issue-48636.rs stdout ----
[01:07:13] diff of stderr:
[01:07:13] 
[01:07:13] 3    |
[01:07:13] 4 LL |     x: u8
[01:07:13] 5    |          - help: missing comma here: `,`
[01:07:13] - LL |     /// The id of the parent core
[01:07:13] + LL |     /// The ID of the parent core
[01:07:13] 8    |
[01:07:13] 8    |
[01:07:13] 9    = help: doc comments must come before what they document, maybe a comment was intended with `//`?
[01:07:13] 
[01:07:13] The actual stderr differed from the expected stderr.
[01:07:13] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-48636/issue-48636.stderr
[01:07:13] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-48636/issue-48636.stderr
[01:07:13] To update references, rerun the tests and pass the `--bless` flag
[01:07:13] To only update this specific test, also pass `--test-args issues/issue-48636.rs`
[01:07:13] error: 1 errors occurred comparing output.
[01:07:13] status: exit code: 1
[01:07:13] status: exit code: 1
[01:07:13] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/issues/issue-48636.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-48636/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-48636/auxiliary" "-A" "unused"
[01:07:13] ------------------------------------------
[01:07:13] 
[01:07:13] ------------------------------------------
[01:07:13] stderr:
[01:07:13] stderr:
[01:07:13] ------------------------------------------
[01:07:13] {"message":"found a documentation comment that doesn't document anything","code":{"code":"E0585","explanation":"\nA documentation comment that doesn't document anything was found.\n\nErroneous code example:\n\n```compile_fail,E0585\nfn main() {\n    // The following doc comment will fail:\n    /// This is a useless doc comment!\n}\n```\n\nDocumentation comments need to be followed by items, including functions,\ntypes, modules, etc. Examples:\n\n```\n/// I'm documenting the following struct:\nstruct Foo;\n\n/// I'm documenting the following function:\nfn foo() {}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/issues/issue-48636.rs","byte_start":63,"byte_end":92,"line_start":7,"line_end":7,"column_start":5,"column_end":34,"is_primary":true,"text":[{"text":"    /// The ID of the parent core","highlight_start":5,"highlight_end":34}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"doc comments must come before what they document, maybe a comment was intended with `//`?","code":null,"level":"help","spans":[],"children":[],"rendered":null},{"message":"missing comma here","code":null,"level":"help","spans":[{"file_name":"/checkout/src/test/ui/issues/issue-48636.rs","byte_start":58,"byte_end":58,"line_start":6,"line_end":6,"column_start":10,"column_end":10,"is_primary":true,"text":[{"text":"    x: u8","highlight_start":10,"highlight_end":10}],"label":null,"suggested_replacement":",","suggestion_applicability":"MachineApplicable","expansion":null}],"children":[],"rendered":null}],"rendered":"error[E0585]: found a documentation comment that doesn't document anything\n  --> /checkout/src/test/ui/issues/issue-48636.rs:7:5\n   |\nLL |     x: u8\n   |          - help: missing comma here: `,`\nLL |     /// The ID of the parent core\n   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n   |\n   = help: doc comments must come before what they document, maybe a comment was intended with `//`?\n\n"}
[01:07:13] {"message":"For more information about this error, try `rustc --explain E0585`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0585`.\n"}
[01:07:13] 
[01:07:13] ------------------------------------------
[01:07:13] 
---
[01:07:13] 
[01:07:13] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:496:22
[01:07:13] 
[01:07:13] 
[01:07:13] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:07:13] 
[01:07:13] 
[01:07:13] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:07:13] Build completed unsuccessfully in 0:04:46
[01:07:13] Build completed unsuccessfully in 0:04:46
[01:07:13] make: *** [check] Error 1
[01:07:13] Makefile:48: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:2ae73946
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Sun Feb 10 06:19:08 UTC 2019
---
travis_time:end:24bdf4a0:start=1549779550145507766,finish=1549779550150983375,duration=5475609
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:055c4cb8
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:064bb0af
travis_time:start:064bb0af
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0b682471
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@@ -66,7 +66,7 @@ impl Step for Rustc {
});
}

/// Build the compiler.
/// Builds the compiler.

This comment has been minimized.

@petrochenkov

petrochenkov Feb 10, 2019

Contributor

Why is this an improvement rather than a random stylistic change?
What will prevent people from using their preferred form again?

=> controversial

This comment has been minimized.

@alexreg

alexreg Feb 10, 2019

Author Contributor

Not controversial at all. This is the standard/conventional style, to use the present tense, and improves consistency too. What prevents this happening again is people like you and me making sure this is used when reviewing PRs.

This comment has been minimized.

@RalfJung

RalfJung Feb 11, 2019

Member

"Build the compiler" is also present tense, so that's not even the point here. The difference is about using 2nd or 3rd person singular.

But indeed the majority of doc comments seem to be written in 3rd person.

This comment has been minimized.

@petrochenkov

petrochenkov Feb 11, 2019

Contributor

@RalfJung
[ot] I never realized imperative is actually a usual present tense with implicit "you" in English, it's an entirely separate form without a tense in Russian.

This comment has been minimized.

@RalfJung

RalfJung Feb 11, 2019

Member

Yeah same in German... English just has the most boring verbs.^^

I guess it's actually meant to be imperative here, not 2nd person singular. Whatever.

This comment has been minimized.

@alexreg

alexreg Feb 11, 2019

Author Contributor

@RalfJung @petrochenkov Well yes, but it's the imperative mood... the issue is so many verb forms are degenerate in English. In any case, the convention seems to be 3rd person singular present indicative. ;-) I.e., "[This function] builds the compiler." This makes sense to me.

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Feb 10, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:0470b2cc:start=1549820779882253809,finish=1549820852285608571,duration=72403354762
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[00:59:26] .................................................................................................... 2400/5380
[00:59:30] .................................................................................................... 2500/5380
[00:59:34] .................................................................................................... 2600/5380
[00:59:37] .................................................................................................... 2700/5380
[00:59:42] .............................................................................................F...... 2800/5380
[00:59:50] .................................................................................................... 3000/5380
[00:59:53] .................................................................................................... 3100/5380
[00:59:57] .................................................................................................... 3200/5380
[01:00:01] ................................i................................................................... 3300/5380
---
[01:01:21] diff of fixed:
[01:01:21] 
[01:01:21] 8     y: u8,
[01:01:21] 9 }
[01:01:21] 10 //~^^^ ERROR found a documentation comment that doesn't document anything
[01:01:21] 11 fn main() {}
[01:01:21] 12 
[01:01:21] 
[01:01:21] 
[01:01:21] 
[01:01:21] The actual fixed differed from the expected fixed.
[01:01:21] Actual fixed saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-48636/issue-48636.fixed
[01:01:21] To update references, rerun the tests and pass the `--bless` flag
[01:01:21] To only update this specific test, also pass `--test-args issues/issue-48636.rs`
[01:01:21] error: 1 errors occurred comparing output.
[01:01:21] status: exit code: 1
[01:01:21] status: exit code: 1
[01:01:21] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/issues/issue-48636.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-48636/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-48636/auxiliary" "-A" "unused"
[01:01:21] ------------------------------------------
[01:01:21] 
[01:01:21] ------------------------------------------
[01:01:21] stderr:
[01:01:21] stderr:
[01:01:21] ------------------------------------------
[01:01:21] {"message":"found a documentation comment that doesn't document anything","code":{"code":"E0585","explanation":"\nA documentation comment that doesn't document anything was found.\n\nErroneous code example:\n\n```compile_fail,E0585\nfn main() {\n    // The following doc comment will fail:\n    /// This is a useless doc comment!\n}\n```\n\nDocumentation comments need to be followed by items, including functions,\ntypes, modules, etc. Examples:\n\n```\n/// I'm documenting the following struct:\nstruct Foo;\n\n/// I'm documenting the following function:\nfn foo() {}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/issues/issue-48636.rs","byte_start":63,"byte_end":92,"line_start":7,"line_end":7,"column_start":5,"column_end":34,"is_primary":true,"text":[{"text":"    /// The ID of the parent core","highlight_start":5,"highlight_end":34}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"doc comments must come before what they document, maybe a comment was intended with `//`?","code":null,"level":"help","spans":[],"children":[],"rendered":null},{"message":"missing comma here","code":null,"level":"help","spans":[{"file_name":"/checkout/src/test/ui/issues/issue-48636.rs","byte_start":58,"byte_end":58,"line_start":6,"line_end":6,"column_start":10,"column_end":10,"is_primary":true,"text":[{"text":"    x: u8","highlight_start":10,"highlight_end":10}],"label":null,"suggested_replacement":",","suggestion_applicability":"MachineApplicable","expansion":null}],"children":[],"rendered":null}],"rendered":"error[E0585]: found a documentation comment that doesn't document anything\n  --> /checkout/src/test/ui/issues/issue-48636.rs:7:5\n   |\nLL |     x: u8\n   |          - help: missing comma here: `,`\nLL |     /// The ID of the parent core\n   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n   |\n   = help: doc comments must come before what they document, maybe a comment was intended with `//`?\n\n"}
[01:01:21] {"message":"For more information about this error, try `rustc --explain E0585`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0585`.\n"}
[01:01:21] 
[01:01:21] ------------------------------------------
[01:01:21] 
---
[01:01:21] 
[01:01:21] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:496:22
[01:01:21] 
[01:01:21] 
[01:01:21] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:01:21] 
[01:01:21] 
[01:01:21] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:01:21] Build completed unsuccessfully in 0:04:17
[01:01:21] Build completed unsuccessfully in 0:04:17
[01:01:21] Makefile:48: recipe for target 'check' failed
[01:01:21] make: *** [check] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0024e488
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Sun Feb 10 18:49:05 UTC 2019

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@alexreg alexreg force-pushed the alexreg:cosmetic-2-doc-comments branch from a431544 to 4d7303a Feb 10, 2019

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 10, 2019

☔️ The latest upstream changes (presumably #58129) made this pull request unmergeable. Please resolve the merge conflicts.

@alexreg alexreg force-pushed the alexreg:cosmetic-2-doc-comments branch from 4d7303a to f438305 Feb 10, 2019

@alexreg

This comment has been minimized.

Copy link
Contributor Author

alexreg commented Feb 10, 2019

Okay, looks like tests are passing and everything is good to go, in theory...

@alexreg alexreg force-pushed the alexreg:cosmetic-2-doc-comments branch from f438305 to f943296 Feb 10, 2019

@steveklabnik

This comment has been minimized.

Copy link
Member

steveklabnik commented Feb 11, 2019

@bors: r+ p=1

Normally, I would not p=1 this, but given that it's very likely to bit-rot and we're splitting up a massive PR, let's do it. I was gonna do a rollup but there are only two other rollup PRs. It's monday morning, this is fine, imho. If someone strongly disagrees feel free to do something else.

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 11, 2019

📌 Commit f943296 has been approved by steveklabnik

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 11, 2019

⌛️ Testing commit f943296 with merge a0e7721...

bors added a commit that referenced this pull request Feb 11, 2019

Auto merge of #58341 - alexreg:cosmetic-2-doc-comments, r=steveklabnik
Cosmetic improvements to doc comments

This has been factored out from #58036 to only include changes to documentation comments (throughout the rustc codebase).

r? @steveklabnik

Once you're happy with this, maybe we could get it through with r=1, so it doesn't constantly get invalidated? (I'm not sure this will be an issue, but just in case...) Anyway, thanks for your advice so far!
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 11, 2019

💔 Test failed - status-appveyor

@alexreg

This comment has been minimized.

Copy link
Contributor Author

alexreg commented Feb 11, 2019

Thanks @steveklabnik. Those were my thoughts too, essentially. It doesn't have the "importance" of a higher-priority PR, but due to the tendency to bitrot, etc. Looks like like an ephemeral failure with bors though, if I'm not mistaken?

@mati865

This comment has been minimized.

Copy link
Contributor

mati865 commented Feb 11, 2019

Tracking issue for this failure: #58025

It should work after retry.

@rust-lang rust-lang deleted a comment from bors Feb 11, 2019

@rust-lang rust-lang deleted a comment from bors Feb 11, 2019

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 12, 2019

💔 Test failed - checks-travis

@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

rust-highfive commented Feb 12, 2019

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:10:07] Command failed. Attempt 2/5:
[00:10:07] ** Resuming transfer from byte position 30631193
[00:10:07]   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
[00:10:07]                                  Dload  Upload   Total   Spent    Left  Speed
No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Feb 12, 2019

@bors retry

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 12, 2019

⌛️ Testing commit f943296 with merge b244f61...

bors added a commit that referenced this pull request Feb 12, 2019

Auto merge of #58341 - alexreg:cosmetic-2-doc-comments, r=steveklabnik
Cosmetic improvements to doc comments

This has been factored out from #58036 to only include changes to documentation comments (throughout the rustc codebase).

r? @steveklabnik

Once you're happy with this, maybe we could get it through with r=1, so it doesn't constantly get invalidated? (I'm not sure this will be an issue, but just in case...) Anyway, thanks for your advice so far!
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 12, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: steveklabnik
Pushing b244f61 to master...

@RalfJung

This comment has been minimized.

Copy link
Member

RalfJung commented on src/libcore/mem.rs in 99ed06e Feb 14, 2019

You turned this into "zero-initializing" once and into "zero--initializing" another time. Which one is the typo?

This comment has been minimized.

Copy link
Contributor Author

alexreg replied Feb 14, 2019

Oops. Must have been find-and-replace gone wrong. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment