New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check user type annotations for range patterns. #58371

Merged
merged 1 commit into from Feb 14, 2019

Conversation

Projects
None yet
5 participants
@davidtwco
Copy link
Member

davidtwco commented Feb 11, 2019

Fixes #58299.

This PR builds on the fix from #58161 (which fixed miscompilation
caused by the introduction of AscribeUserType patterns for associated
constants) to start checking these patterns are well-formed for ranges
(previous fix just ignored them so that miscompilation wouldn't occur).

r? @arielb1

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Feb 11, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:2e5a6a1c:start=1549885827988098807,finish=1549885905878463550,duration=77890364743
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[01:01:16] .................................................................................................... 700/2948
[01:01:27] .................................................................................................... 800/2948
[01:01:36] .................................................................................................... 900/2948
[01:01:52] .................................................................................................... 1000/2948
[01:02:05] .......................................................F............................................ 1100/2948
[01:02:24] .................................................................................................... 1300/2948
[01:02:36] .................................................................................................... 1400/2948
[01:02:48] .................................................................................................... 1500/2948
[01:02:58] ......................................................................i............................. 1600/2948
---
[01:06:28] 
[01:06:28] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:496:22
[01:06:28] 
[01:06:28] 
[01:06:28] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/run-pass" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "run-pass" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:06:28] 
[01:06:28] 
[01:06:28] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:06:28] Build completed unsuccessfully in 0:10:44
[01:06:28] Build completed unsuccessfully in 0:10:44
[01:06:28] make: *** [check] Error 1
[01:06:28] Makefile:48: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:1636f4a5
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Mon Feb 11 12:58:23 UTC 2019

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@davidtwco davidtwco force-pushed the davidtwco:issue-58299 branch from 1ef561c to 89da53f Feb 11, 2019

@arielb1

This comment has been minimized.

Copy link
Contributor

arielb1 commented Feb 12, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 12, 2019

📌 Commit ca4c842 has been approved by arielb1

@arielb1

This comment has been minimized.

Copy link
Contributor

arielb1 commented Feb 12, 2019

Actually, I'll rather want a comment

@bors r-

@arielb1

This comment has been minimized.

Copy link
Contributor

arielb1 commented Feb 12, 2019

r=me with that comment

Check user type annotations for range patterns.
This commit builds on the fix from #58161 (which fixed miscompilation
caused by the introduction of `AscribeUserType` patterns for associated
constants) to start checking these patterns are well-formed for ranges
(previous fix just ignored them so that miscompilation wouldn't occur).

@davidtwco davidtwco force-pushed the davidtwco:issue-58299 branch from ca4c842 to ee82d09 Feb 12, 2019

@davidtwco

This comment has been minimized.

Copy link
Member Author

davidtwco commented Feb 12, 2019

@bors r=arielb1

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 12, 2019

📌 Commit ee82d09 has been approved by arielb1

Centril added a commit to Centril/rust that referenced this pull request Feb 14, 2019

Rollup merge of rust-lang#58371 - davidtwco:issue-58299, r=arielb1
Check user type annotations for range patterns.

Fixes rust-lang#58299.

This PR builds on the fix from rust-lang#58161 (which fixed miscompilation
caused by the introduction of `AscribeUserType` patterns for associated
constants) to start checking these patterns are well-formed for ranges
(previous fix just ignored them so that miscompilation wouldn't occur).

r? @arielb1

bors added a commit that referenced this pull request Feb 14, 2019

Auto merge of #58455 - Centril:rollup, r=Centril
Rollup of 7 pull requests

Successful merges:

 - #58309 (Add more profiler events)
 - #58347 (Closure bounds fixes)
 - #58365 (Add an option to print the status of incremental tasks / dep nodes after running them)
 - #58371 (Check user type annotations for range patterns.)
 - #58378 (rustc: Implement incremental "fat" LTO)
 - #58407 (specify "upper camel case" in style lint)
 - #58449 (Notify @topecongiro when the state of rustfmt has changed)

Failed merges:

r? @ghost

@bors bors merged commit ee82d09 into rust-lang:master Feb 14, 2019

@davidtwco davidtwco deleted the davidtwco:issue-58299 branch Feb 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment