Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Postpone HirIdification until HirId functions are optimized #58376
Perf took a pretty big hit today and I'm suspecting that one of the HirIdification methods might be the cause, because they aren't optimized yet (some of them convert
Can I get a try+perf run?
added a commit
this pull request
Feb 11, 2019
r=me with a vengeance if you feel it's ready to do so, that's a hell of a lot of green. Can you take the lead on investigating the perf hit?
That being said, in the diff I see a couple of places that are only hot if there has been an error. Those cases could probably be kept without reverting (thinking of https://github.com/rust-lang/rust/pull/58376/files#diff-9d22f4d35c9bd98748f3e1a7cda1b3e7 and https://github.com/rust-lang/rust/pull/58376/files#diff-a4796471067f8f3d7549cb74eca68a4e).