Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destabilize fixed-width const defined atomic integers #58616

Merged
merged 1 commit into from Feb 22, 2019

Conversation

Projects
None yet
6 participants
@vertexclique
Copy link
Contributor

vertexclique commented Feb 21, 2019

With this PR version 1.34.0 onwards const declarations of atomic integers will be unstable.

Destabilize fixed-width const defined atomic integers
* With this PR 1.34.0 onwards const declarations of atomic integers will be
  unstable.
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Feb 21, 2019

r? @dtolnay

(rust_highfive has picked a reviewer for you, use r? to override)

@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Feb 21, 2019

@bors p=50

@dtolnay
Copy link
Member

dtolnay left a comment

Thanks, looks good to me. I confirmed that the three existing stable consts as of rustc 1.33.0-beta, ATOMIC_BOOL_INIT, ATOMIC_ISIZE_INIT, ATOMIC_USIZE_INIT continue to be stable (but deprecated) with this PR, while the unstable as of rustc 1.33.0-beta consts are being reverted to unstable.

@dtolnay

This comment has been minimized.

Copy link
Member

dtolnay commented Feb 21, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 21, 2019

📌 Commit 99d67ca has been approved by dtolnay

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 21, 2019

⌛️ Testing commit 99d67ca with merge 822c226...

bors added a commit that referenced this pull request Feb 21, 2019

Auto merge of #58616 - vertexclique:destabilize-fixed-width-atomic-in…
…tegers, r=dtolnay

Destabilize fixed-width const defined atomic integers

With this PR version 1.34.0 onwards const declarations of atomic integers will be unstable.

* Closes #58089
* Reverts partially: #57425
@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Feb 21, 2019

@bors retry

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Feb 21, 2019

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
Cloning into 'rust-lang/rust'...
travis_time:end:06e6e2c6:start=1550782468421553257,finish=1550782474462258704,duration=6040705447
$ cd rust-lang/rust
$ git checkout -qf 822c2262217f7f34e049930d557af72fc735d731
fatal: reference is not a tree: 822c2262217f7f34e049930d557af72fc735d731
The command "git checkout -qf 822c2262217f7f34e049930d557af72fc735d731" failed and exited with 128 during .
Your build has been stopped.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@scottmcm

This comment has been minimized.

Copy link
Member

scottmcm commented Feb 21, 2019

Awesome, thanks @vertexclique! Great that this is getting in in time so we don't add debt.

@vertexclique

This comment has been minimized.

Copy link
Contributor Author

vertexclique commented Feb 21, 2019

Aye! Better together folks!

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 21, 2019

⌛️ Testing commit 99d67ca with merge 4de1399...

bors added a commit that referenced this pull request Feb 21, 2019

Auto merge of #58616 - vertexclique:destabilize-fixed-width-atomic-in…
…tegers, r=dtolnay

Destabilize fixed-width const defined atomic integers

With this PR version 1.34.0 onwards const declarations of atomic integers will be unstable.

* Closes #58089
* Reverts partially: #57425
@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Feb 21, 2019

@bors retry

@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Feb 22, 2019

@bors treeclosed-

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 22, 2019

⌛️ Testing commit 99d67ca with merge d1f8970...

bors added a commit that referenced this pull request Feb 22, 2019

Auto merge of #58616 - vertexclique:destabilize-fixed-width-atomic-in…
…tegers, r=dtolnay

Destabilize fixed-width const defined atomic integers

With this PR version 1.34.0 onwards const declarations of atomic integers will be unstable.

* Closes #58089
* Reverts partially: #57425
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 22, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: dtolnay
Pushing d1f8970 to master...

@bors bors added the merged-by-bors label Feb 22, 2019

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 22, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: dtolnay
Pushing d1f8970 to master...

@bors bors merged commit 99d67ca into rust-lang:master Feb 22, 2019

1 check passed

homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.