Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a valid name for graphviz graphs #59251

Merged
merged 1 commit into from Mar 24, 2019

Conversation

Projects
None yet
4 participants
@matthewjasper
Copy link
Contributor

commented Mar 17, 2019

Hiridification has broken graphviz output because HirId has a more complex display implemetation than NodeId. Since the id was just used to generate a distinct identifier, we just pull out the various constituent indexed.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Mar 17, 2019

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@petrochenkov

This comment has been minimized.

Copy link
Contributor

commented Mar 17, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Mar 17, 2019

📌 Commit 6430318 has been approved by petrochenkov

sanxiyn added a commit to sanxiyn/rust that referenced this pull request Mar 18, 2019

Rollup merge of rust-lang#59251 - matthewjasper:fix-graphviz, r=petro…
…chenkov

Use a valid name for graphviz graphs

Hiridification has broken graphviz output because `HirId` has a more complex display implemetation than `NodeId`. Since the id was just used to generate a distinct identifier, we just pull out the various constituent indexed.

bors added a commit that referenced this pull request Mar 18, 2019

Auto merge of #59271 - sanxiyn:rollup, r=sanxiyn
Rollup of 8 pull requests

Successful merges:

 - #57729 (extra testing of how NLL handles wildcard type `_`)
 - #58986 ([CI] Update binutils for powerpc64 and powerpc64le)
 - #59084 (Tweak some diagnostic spans)
 - #59106 (Add peer_addr function to UdpSocket)
 - #59116 (Be more discerning on when to attempt suggesting a comma in a macro invocation)
 - #59240 (use the identifier span for missing struct field)
 - #59251 (Use a valid name for graphviz graphs)
 - #59252 (add self to mailmap)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Mar 19, 2019

Rollup merge of rust-lang#59251 - matthewjasper:fix-graphviz, r=petro…
…chenkov

Use a valid name for graphviz graphs

Hiridification has broken graphviz output because `HirId` has a more complex display implemetation than `NodeId`. Since the id was just used to generate a distinct identifier, we just pull out the various constituent indexed.

bors added a commit that referenced this pull request Mar 20, 2019

Auto merge of #59300 - Centril:rollup, r=Centril
Rollup of 10 pull requests

Successful merges:

 - #58902 (Fixes for the generator transform)
 - #58913 (Add new test case for possible bug in BufReader)
 - #58927 (Add default keyword handling in rustdoc)
 - #58995 (Refactor tools/build-mainfest)
 - #59172 (Update and clean up several parts of CONTRIBUTING.md)
 - #59239 (Remove inline assembly from hint::spin_loop)
 - #59251 (Use a valid name for graphviz graphs)
 - #59256 (Make meta-item API compatible with `LocalInternedString::get` soundness fix)
 - #59266 (Do not complain about non-existing fields after parse recovery)
 - #59296 (Do not encode gensymed imports in metadata)

Failed merges:

r? @ghost

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Mar 23, 2019

Rollup merge of rust-lang#59251 - matthewjasper:fix-graphviz, r=petro…
…chenkov

Use a valid name for graphviz graphs

Hiridification has broken graphviz output because `HirId` has a more complex display implemetation than `NodeId`. Since the id was just used to generate a distinct identifier, we just pull out the various constituent indexed.

kennytm added a commit to kennytm/rust that referenced this pull request Mar 24, 2019

Rollup merge of rust-lang#59251 - matthewjasper:fix-graphviz, r=petro…
…chenkov

Use a valid name for graphviz graphs

Hiridification has broken graphviz output because `HirId` has a more complex display implemetation than `NodeId`. Since the id was just used to generate a distinct identifier, we just pull out the various constituent indexed.

bors added a commit that referenced this pull request Mar 24, 2019

Auto merge of #59397 - kennytm:rollup, r=kennytm
Rollup of 9 pull requests

Successful merges:

 - #59213 (Track changes to robots.txt)
 - #59239 (Remove inline assembly from hint::spin_loop)
 - #59242 (make asm diagnostic instruction optional)
 - #59251 (Use a valid name for graphviz graphs)
 - #59296 (Do not encode gensymed imports in metadata)
 - #59328 (Implement specialized nth_back() for Box and Windows.)
 - #59355 (Fix ICE with const generic param in struct)
 - #59366 (Update books)
 - #59377 (Correct minimum system LLVM version in tests)

Failed merges:

r? @ghost

kennytm added a commit to kennytm/rust that referenced this pull request Mar 24, 2019

Rollup merge of rust-lang#59251 - matthewjasper:fix-graphviz, r=petro…
…chenkov

Use a valid name for graphviz graphs

Hiridification has broken graphviz output because `HirId` has a more complex display implemetation than `NodeId`. Since the id was just used to generate a distinct identifier, we just pull out the various constituent indexed.

bors added a commit that referenced this pull request Mar 24, 2019

Auto merge of #59397 - kennytm:rollup, r=kennytm
Rollup of 8 pull requests

Successful merges:

 - #59213 (Track changes to robots.txt)
 - #59239 (Remove inline assembly from hint::spin_loop)
 - #59251 (Use a valid name for graphviz graphs)
 - #59296 (Do not encode gensymed imports in metadata)
 - #59328 (Implement specialized nth_back() for Box and Windows.)
 - #59355 (Fix ICE with const generic param in struct)
 - #59366 (Update books)
 - #59377 (Correct minimum system LLVM version in tests)

bors added a commit that referenced this pull request Mar 24, 2019

Auto merge of #59397 - kennytm:rollup, r=kennytm
Rollup of 7 pull requests

Successful merges:

 - #59213 (Track changes to robots.txt)
 - #59239 (Remove inline assembly from hint::spin_loop)
 - #59251 (Use a valid name for graphviz graphs)
 - #59296 (Do not encode gensymed imports in metadata)
 - #59328 (Implement specialized nth_back() for Box and Windows.)
 - #59355 (Fix ICE with const generic param in struct)
 - #59377 (Correct minimum system LLVM version in tests)

@bors bors merged commit 6430318 into rust-lang:master Mar 24, 2019

@matthewjasper matthewjasper deleted the matthewjasper:fix-graphviz branch Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.