Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: collapse blanket impls in the same way as normal impls #59534

Merged
merged 1 commit into from Mar 30, 2019

Conversation

Projects
None yet
5 participants
@laurmaedje
Copy link
Contributor

laurmaedje commented Mar 29, 2019

If the rustdoc setting Auto-hide trait implementations documentation is activated (on by default), normal trait implementations are collapsed by default.

Blanket impls on the other hand are not collapsed. I'm not sure whether this is intended, but considering that the blanket impls for From, Into, TryFrom, ... are on every type, it would reduce the documentation bloat if these would also be collapsed when the setting is active.

(I'm not really familiar with the codebase and therefore just copied the code for the normal impl collapsing, but I could deduplicate it into a method, of course, too.)

@lzutao

This comment has been minimized.

Copy link
Contributor

lzutao commented Mar 29, 2019

r? @Centril . Highfive doesn't listen.

@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Mar 29, 2019

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Mar 29, 2019

Thanks!

@bors: r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Mar 29, 2019

📌 Commit 9e4ec7a has been approved by GuillaumeGomez

Centril added a commit to Centril/rust that referenced this pull request Mar 29, 2019

Rollup merge of rust-lang#59534 - laurmaedje:collapse-blanket-impls, …
…r=GuillaumeGomez

rustdoc: collapse blanket impls in the same way as normal impls

If the rustdoc setting _Auto-hide trait implementations documentation_ is activated (on by default), normal trait implementations are collapsed by default.

Blanket impls on the other hand are not collapsed. I'm not sure whether this is intended, but considering that the blanket impls for `From`, `Into`, `TryFrom`, ... are on every type, it would reduce the documentation bloat if these would also be collapsed when the setting is active.

(I'm not really familiar with the codebase and therefore just copied the code for the normal impl collapsing, but I could deduplicate it into a method, of course, too.)

bors added a commit that referenced this pull request Mar 30, 2019

Auto merge of #59538 - Centril:rollup, r=Centril
Rollup of 11 pull requests

Successful merges:

 - #59376 (RFC 2008: Enum Variants)
 - #59446 (Fix stack overflow when generating debuginfo for 'recursive' type)
 - #59453 (Recover from parse error in tuple syntax)
 - #59455 (Account for short-hand field syntax when suggesting borrow)
 - #59499 (Fix broken download link in the armhf-gnu image)
 - #59512 (implement `AsRawFd` for stdio locks)
 - #59525 (Whitelist some rustc attrs)
 - #59528 (Improve the dbg! macro docs )
 - #59532 (In doc examples, don't ignore read/write results)
 - #59534 (rustdoc: collapse blanket impls in the same way as normal impls)
 - #59537 (Fix OnceWith docstring.)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Mar 30, 2019

Rollup merge of rust-lang#59534 - laurmaedje:collapse-blanket-impls, …
…r=GuillaumeGomez

rustdoc: collapse blanket impls in the same way as normal impls

If the rustdoc setting _Auto-hide trait implementations documentation_ is activated (on by default), normal trait implementations are collapsed by default.

Blanket impls on the other hand are not collapsed. I'm not sure whether this is intended, but considering that the blanket impls for `From`, `Into`, `TryFrom`, ... are on every type, it would reduce the documentation bloat if these would also be collapsed when the setting is active.

(I'm not really familiar with the codebase and therefore just copied the code for the normal impl collapsing, but I could deduplicate it into a method, of course, too.)

bors added a commit that referenced this pull request Mar 30, 2019

Auto merge of #59550 - Centril:rollup, r=Centril
Rollup of 10 pull requests

Successful merges:

 - #59376 (RFC 2008: Enum Variants)
 - #59453 (Recover from parse error in tuple syntax)
 - #59455 (Account for short-hand field syntax when suggesting borrow)
 - #59499 (Fix broken download link in the armhf-gnu image)
 - #59512 (implement `AsRawFd` for stdio locks)
 - #59525 (Whitelist some rustc attrs)
 - #59528 (Improve the dbg! macro docs )
 - #59532 (In doc examples, don't ignore read/write results)
 - #59534 (rustdoc: collapse blanket impls in the same way as normal impls)
 - #59537 (Fix OnceWith docstring.)

Failed merges:

r? @ghost

@bors bors merged commit 9e4ec7a into rust-lang:master Mar 30, 2019

@laurmaedje laurmaedje deleted the laurmaedje:collapse-blanket-impls branch Mar 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.