Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow closure to unsafe fn coercion #59580

Merged
merged 1 commit into from Mar 31, 2019

Conversation

Projects
None yet
5 participants
@taiki-e
Copy link
Contributor

taiki-e commented Mar 31, 2019

Closes #57883

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Mar 31, 2019

r? @oli-obk

(rust_highfive has picked a reviewer for you, use r? to override)

@Centril
Copy link
Contributor

Centril left a comment

👍

Show resolved Hide resolved src/librustc/ty/context.rs
Show resolved Hide resolved src/librustc/mir/mod.rs
Show resolved Hide resolved src/librustc_typeck/check/coercion.rs
Show resolved Hide resolved src/test/run-pass/typeck-closure-to-unsafe-fn-ptr.rs

@Centril Centril added this to the 1.35 milestone Mar 31, 2019

@taiki-e taiki-e force-pushed the taiki-e:coerce-closure branch from be0a788 to 07021e0 Mar 31, 2019

@oli-obk

This comment has been minimized.

Copy link
Contributor

oli-obk commented Mar 31, 2019

Impl lgtm. Issue suggests that this doesn't need an FCP.

@bors r+

I opened an issue (#59588) talking about my unhappiness with the fact that this PR had to touch three enums. Note that this is absolutely not this PR's fault, but just the way our datastructes are laid out.

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Mar 31, 2019

📌 Commit 07021e0 has been approved by oli-obk

Centril added a commit to Centril/rust that referenced this pull request Mar 31, 2019

bors added a commit that referenced this pull request Mar 31, 2019

Auto merge of #59590 - Centril:rollup, r=Centril
Rollup of 7 pull requests

Successful merges:

 - #58805 (Lint for redundant imports)
 - #59506 (Use platform dependent mcount function)
 - #59519 (rustc_target: factor out common fields of non-Single Variants.)
 - #59580 (Allow closure to unsafe fn coercion)
 - #59581 (Stabilize refcell_replace_swap feature)
 - #59583 (match match match match match)
 - #59587 (Remove #[doc(hidden)] from Error::type_id)

Failed merges:

r? @ghost

@bors bors merged commit 07021e0 into rust-lang:master Mar 31, 2019

@taiki-e taiki-e deleted the taiki-e:coerce-closure branch Mar 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.