Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for shallow borrows #59585

Merged
merged 1 commit into from Apr 2, 2019

Conversation

Projects
None yet
6 participants
@matthewjasper
Copy link
Contributor

commented Mar 31, 2019

  • Don't promote these borrows if we're going to remove them before
    codegen
  • Correctly mark unreachable code
Fixes for shallow borrows
* Don't promote these borrows if we're going to remove them before
  codegen
* Correctly mark unreachable code
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Mar 31, 2019

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

@davidtwco

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

These changes look fine to me but I'm not sure of the context, so
r? @pnkfelix

@rust-highfive rust-highfive assigned pnkfelix and unassigned davidtwco Apr 2, 2019

@pnkfelix

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 2, 2019

📌 Commit 16ee042 has been approved by pnkfelix

Centril added a commit to Centril/rust that referenced this pull request Apr 2, 2019

Rollup merge of rust-lang#59585 - rust-lang:shallow-borrow-fixes, r=p…
…nkfelix

Fixes for shallow borrows

* Don't promote these borrows if we're going to remove them before
  codegen
* Correctly mark unreachable code

@Centril Centril referenced this pull request Apr 2, 2019

Merged

Rollup of 8 pull requests #59632

bors added a commit that referenced this pull request Apr 2, 2019

Auto merge of #59632 - Centril:rollup, r=Centril
Rollup of 8 pull requests

Successful merges:

 - #59262 (Remove duplicated code from Iterator::{ne, lt, le, gt, ge})
 - #59286 (Refactor async fn return type lowering)
 - #59444 (Implement useful steps_between for all integers)
 - #59452 (Speed up rustdoc run a bit)
 - #59533 (Support allocating iterators with arenas)
 - #59585 (Fixes for shallow borrows)
 - #59607 (Renames `EvalErrorKind` to `InterpError`)
 - #59613 (SGX target: convert a bunch of panics to aborts)

Failed merges:

 - #59630 (Shrink `mir::Statement`.)

r? @ghost

@bors bors merged commit 16ee042 into master Apr 2, 2019

@matthewjasper matthewjasper deleted the shallow-borrow-fixes branch Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.