Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign up[do not merge] Test ahash #59592
Conversation
rust-highfive
assigned
nikomatsakis
Mar 31, 2019
This comment has been minimized.
This comment has been minimized.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
label
Mar 31, 2019
Zoxc
force-pushed the
Zoxc:ahash
branch
from
caa0927
to
1dc107d
Mar 31, 2019
This comment has been minimized.
This comment has been minimized.
|
@bors try |
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Mar 31, 2019
This comment has been minimized.
This comment has been minimized.
|
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
added
S-waiting-on-author
and removed
S-waiting-on-review
labels
Mar 31, 2019
Zoxc
force-pushed the
Zoxc:ahash
branch
from
1dc107d
to
b4092e8
Mar 31, 2019
This comment has been minimized.
This comment has been minimized.
|
@bors try |
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Mar 31, 2019
This comment has been minimized.
This comment has been minimized.
|
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This comment has been minimized.
This comment has been minimized.
tkaitchuck
commented
Apr 1, 2019
|
Clever renaming AHasher to FxHasher to update everywhere without making the diff huge.
Could that be related to something aHash is doing that Fx is not, like maybe proc macros? |
This comment has been minimized.
This comment has been minimized.
|
Nah, it's just a linker error. No idea why it appears though. |
This comment has been minimized.
This comment has been minimized.
|
|
Zoxc commentedMar 31, 2019
cc @tkaitchuck