Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrink `mir::Statement`. #59630

Merged
merged 1 commit into from Apr 3, 2019

Conversation

Projects
None yet
5 participants
@nnethercote
Copy link
Contributor

commented Apr 2, 2019

The InlineAsm variant is extremely rare, and mir::Statement often
contributes significantly to peak memory usage.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Apr 2, 2019

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@pnkfelix

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 2, 2019

📌 Commit 3e36c65 has been approved by pnkfelix

@Centril Centril referenced this pull request Apr 2, 2019

Merged

Rollup of 8 pull requests #59632

bors added a commit that referenced this pull request Apr 2, 2019

Auto merge of #59632 - Centril:rollup, r=Centril
Rollup of 8 pull requests

Successful merges:

 - #59262 (Remove duplicated code from Iterator::{ne, lt, le, gt, ge})
 - #59286 (Refactor async fn return type lowering)
 - #59444 (Implement useful steps_between for all integers)
 - #59452 (Speed up rustdoc run a bit)
 - #59533 (Support allocating iterators with arenas)
 - #59585 (Fixes for shallow borrows)
 - #59607 (Renames `EvalErrorKind` to `InterpError`)
 - #59613 (SGX target: convert a bunch of panics to aborts)

Failed merges:

 - #59630 (Shrink `mir::Statement`.)

r? @ghost
@Centril

This comment has been minimized.

Copy link
Contributor

commented Apr 2, 2019

@bors r-

@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 2, 2019

☔️ The latest upstream changes (presumably #59632) made this pull request unmergeable. Please resolve the merge conflicts.

@nnethercote

This comment has been minimized.

Copy link
Contributor Author

commented Apr 2, 2019

@Centril: why did you r-?

@Centril

This comment has been minimized.

Copy link
Contributor

commented Apr 2, 2019

@nnethercote the merge conflict (I knew ahead of time it would conflict before github did)

Shrink `mir::Statement`.
The `InlineAsm` variant is extremely rare, and `mir::Statement` often
contributes significantly to peak memory usage.

@nnethercote nnethercote force-pushed the nnethercote:shrink-mir-Statement branch from 3e36c65 to d00d639 Apr 2, 2019

@nnethercote

This comment has been minimized.

Copy link
Contributor Author

commented Apr 2, 2019

@bors r=pnkfelix

@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 2, 2019

📌 Commit d00d639 has been approved by pnkfelix

Centril added a commit to Centril/rust that referenced this pull request Apr 2, 2019

Rollup merge of rust-lang#59630 - nnethercote:shrink-mir-Statement, r…
…=pnkfelix

Shrink `mir::Statement`.

The `InlineAsm` variant is extremely rare, and `mir::Statement` often
contributes significantly to peak memory usage.

@Centril Centril referenced this pull request Apr 2, 2019

Closed

Rollup of 5 pull requests #59653

bors added a commit that referenced this pull request Apr 3, 2019

Auto merge of #59653 - Centril:rollup-0kr2w0l, r=Centril
Rollup of 5 pull requests

Successful merges:

 - #55448 (Add 'partition_at_index/_by/_by_key' for slices.)
 - #59186 (improve worst-case performance of BTreeSet intersection v3)
 - #59514 (Remove adt_def from projections and downcasts in MIR)
 - #59619 (wasi: Implement more of the standard library)
 - #59630 (Shrink `mir::Statement`.)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Apr 3, 2019

Rollup merge of rust-lang#59630 - nnethercote:shrink-mir-Statement, r…
…=pnkfelix

Shrink `mir::Statement`.

The `InlineAsm` variant is extremely rare, and `mir::Statement` often
contributes significantly to peak memory usage.

@Centril Centril referenced this pull request Apr 3, 2019

Merged

Rollup of 4 pull requests #59657

bors added a commit that referenced this pull request Apr 3, 2019

Auto merge of #59657 - Centril:rollup-w5p98mc, r=Centril
Rollup of 4 pull requests

Successful merges:

 - #55448 (Add 'partition_at_index/_by/_by_key' for slices.)
 - #59186 (improve worst-case performance of BTreeSet intersection v3)
 - #59514 (Remove adt_def from projections and downcasts in MIR)
 - #59630 (Shrink `mir::Statement`.)

Failed merges:

r? @ghost

@bors bors merged commit d00d639 into rust-lang:master Apr 3, 2019

@nnethercote nnethercote deleted the nnethercote:shrink-mir-Statement branch Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.