Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Function arguments should never get promoted #59724
referenced this pull request
Apr 5, 2019
As an experiment, I tried backporting this change to the beta branch, to double-check that it actually addresses the regression.
One potential issue is that the regression tests may not themselves be immediately backportable as written, because I do not think #59044 is in the beta branch. Just a warning.
(commit ccc0cd8 itself does seem to address the key problem in the beta branch.)
@oli-obk @eddyb Regarding the beta-nomination, I do not think we can afford to wait until the next
(To be absolutely clear, I have no personal problem with backporting ccc0cd8 to beta. Though it might be good to explore whether the generalization suggested by @eddyb in their review is what really needs to be backported.)
Click to expand the log.