Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deny rust_2018_idioms globally #60133

Merged
merged 4 commits into from Apr 22, 2019

Conversation

Projects
None yet
7 participants
@phansch
Copy link
Contributor

commented Apr 20, 2019

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Apr 20, 2019

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

commented Apr 20, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:3d357ca3:start=1555760869560415413,finish=1555760870333695020,duration=773279607
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
travis_time:start:test_assembly
Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:13:08] 
[01:13:08] running 9 tests
[01:13:08] iiiiiiiii
[01:13:08] 
[01:13:08]  finished in 0.149
[01:13:08] travis_fold:end:test_assembly

---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:13:24] 
[01:13:24] running 121 tests
[01:13:49] .iiiii...i.....i..i...i..i.i.i..i.ii...i.....i..i....i..........iiii..........i...ii...i.......ii.i. 100/121
[01:13:53] i.i......iii.i.....ii
[01:13:53] 
[01:13:53]  finished in 29.838
[01:13:53] travis_fold:end:test_debuginfo

---
[01:21:26]    Compiling alloc v0.0.0 (/checkout/src/liballoc)
[01:21:27] error: hidden lifetime parameters in types are deprecated
[01:21:27]   --> src/liballoc/../liballoc/tests/cow_str.rs:10:17
[01:21:27]    |
[01:21:27] 10 |     let owned1: Cow<str> = Cow::Owned(String::from("Hi, "));
[01:21:27] 
[01:21:27] error: hidden lifetime parameters in types are deprecated
[01:21:27]   --> src/liballoc/../liballoc/tests/cow_str.rs:11:17
[01:21:27]    |
[01:21:27]    |
[01:21:27] 11 |     let owned2: Cow<str> = Cow::Owned(String::from("Rustaceans!"));
[01:21:27] 
[01:21:27] error: hidden lifetime parameters in types are deprecated
[01:21:27]   --> src/liballoc/../liballoc/tests/cow_str.rs:12:22
[01:21:27]    |
[01:21:27]    |
[01:21:27] 12 |     let owned_empty: Cow<str> = Cow::Owned(String::new());
[01:21:27] 
[01:21:27] error: hidden lifetime parameters in types are deprecated
[01:21:27]   --> src/liballoc/../liballoc/tests/cow_str.rs:39:16
[01:21:27]    |
[01:21:27]    |
[01:21:27] 39 |     let owned: Cow<str> = Cow::Owned(String::from("Hi, "));
[01:21:27] 
[01:21:27] error: hidden lifetime parameters in types are deprecated
[01:21:27]   --> src/liballoc/../liballoc/tests/cow_str.rs:40:22
[01:21:27]    |
[01:21:27]    |
[01:21:27] 40 |     let owned_empty: Cow<str> = Cow::Owned(String::new());
[01:21:27] 
[01:21:27] error: hidden lifetime parameters in types are deprecated
[01:21:27]   --> src/liballoc/../liballoc/tests/cow_str.rs:63:21
[01:21:27]    |
[01:21:27]    |
[01:21:27] 63 |     let mut owned1: Cow<str> = Cow::Owned(String::from("Hi, "));
[01:21:27] 
[01:21:27] error: hidden lifetime parameters in types are deprecated
[01:21:27]   --> src/liballoc/../liballoc/tests/cow_str.rs:64:17
[01:21:27]    |
[01:21:27]    |
[01:21:27] 64 |     let owned2: Cow<str> = Cow::Owned(String::from("Rustaceans!"));
[01:21:27] 
[01:21:27] error: hidden lifetime parameters in types are deprecated
[01:21:27]   --> src/liballoc/../liballoc/tests/cow_str.rs:65:22
[01:21:27]    |
[01:21:27]    |
[01:21:27] 65 |     let owned_empty: Cow<str> = Cow::Owned(String::new());
[01:21:27] 
[01:21:27] error: hidden lifetime parameters in types are deprecated
[01:21:27]    --> src/liballoc/../liballoc/tests/cow_str.rs:104:20
[01:21:27]     |
[01:21:27]     |
[01:21:27] 104 |     let mut owned: Cow<str> = Cow::Owned(String::from("Hi, "));
[01:21:27] 
[01:21:27] error: hidden lifetime parameters in types are deprecated
[01:21:27]    --> src/liballoc/../liballoc/tests/cow_str.rs:105:22
[01:21:27]     |
[01:21:27]     |
[01:21:27] 105 |     let owned_empty: Cow<str> = Cow::Owned(String::new());
[01:21:27] 
[01:21:27] error: hidden lifetime parameters in types are deprecated
[01:21:27]    --> src/liballoc/../liballoc/tests/cow_str.rs:135:17
[01:21:27]     |
[01:21:27]     |
[01:21:27] 135 |     let mut c1: Cow<str> = Cow::Owned(String::with_capacity(25));
[01:21:27] 
[01:21:27] error: hidden lifetime parameters in types are deprecated
[01:21:27]    --> src/liballoc/../liballoc/tests/cow_str.rs:138:13
[01:21:27]     |
[01:21:27]     |
[01:21:27] 138 |     let c2: Cow<str> = Cow::Owned(s);
[01:21:27] 
[01:21:27] error: hidden lifetime parameters in types are deprecated
[01:21:27]   --> src/liballoc/../liballoc/tests/string.rs:57:13
[01:21:27]    |
[01:21:27]    |
[01:21:27] 57 |     let ys: Cow<str> = "hello".into_cow();
[01:21:27] 
[01:21:27] error: hidden lifetime parameters in types are deprecated
[01:21:27]   --> src/liballoc/../liballoc/tests/string.rs:61:13
[01:21:27]    |
[01:21:27]    |
[01:21:27] 61 |     let ys: Cow<str> = "ศไทย中华Việt Nam".into_cow();
[01:21:27] 
[01:21:32] error: aborting due to 14 previous errors
[01:21:32] 
[01:21:32] error: Could not compile `alloc`.
[01:21:32] error: Could not compile `alloc`.
[01:21:32] warning: build failed, waiting for other jobs to finish...
[01:21:39] error: build failed
[01:21:39] 
[01:21:39] 
[01:21:39] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-p" "alloc" "--" "--quiet"
[01:21:39] 
[01:21:39] 
[01:21:39] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:21:39] Build completed unsuccessfully in 0:20:00
[01:21:39] Build completed unsuccessfully in 0:20:00
[01:21:39] make: *** [check] Error 1
[01:21:39] Makefile:48: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:1a515e18
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Sat Apr 20 13:09:41 UTC 2019
---
travis_time:end:18f137aa:start=1555765783512906904,finish=1555765783519809476,duration=6902572
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:146e8d0e
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:078d4d37
travis_time:start:078d4d37
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:10cb4e4e
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@phansch

This comment has been minimized.

Copy link
Contributor Author

commented Apr 20, 2019

Looks like src/liballoc/tests/ is still missing #![deny(rust_2018_idioms)]. I'll see if I can fix it.

@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

commented Apr 20, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:02202400:start=1555769211527969977,finish=1555769212279229061,duration=751259084
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
travis_time:start:test_assembly
Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:13:53] 
[01:13:53] running 9 tests
[01:13:53] iiiiiiiii
[01:13:53] 
[01:13:53]  finished in 0.155
[01:13:53] travis_fold:end:test_assembly

---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:14:09] 
[01:14:09] running 121 tests
[01:14:35] .iiiii...i.....i..i...i..i.i.i..i.ii...i.....i..i....i..........iiii..........i...ii...i.......ii.i. 100/121
[01:14:39] i.i......iii.i.....ii
[01:14:39] 
[01:14:39]  finished in 30.219
[01:14:39] travis_fold:end:test_debuginfo

---
[01:24:35]    Compiling core v0.0.0 (/checkout/src/libcore)
[01:24:37] error: hidden lifetime parameters in types are deprecated
[01:24:37]    --> src/libcore/../libcore/tests/cell.rs:142:17
[01:24:37]     |
[01:24:37] 142 |         let b1: Ref<Option<u32>> = x.borrow();
[01:24:37]     |                 ^^^^^^^^^^^^^^^^ help: indicate the anonymous lifetime: `Ref<'_, Option<u32>>`
[01:24:37] error: hidden lifetime parameters in types are deprecated
[01:24:37]    --> src/libcore/../libcore/tests/cell.rs:146:21
[01:24:37]     |
[01:24:37]     |
[01:24:37] 146 |             let b2: Ref<u32> = Ref::map(b1, |o| o.as_ref().unwrap());
[01:24:37]     |                     ^^^^^^^^ help: indicate the anonymous lifetime: `Ref<'_, u32>`
[01:24:37] error: hidden lifetime parameters in types are deprecated
[01:24:37]    --> src/libcore/../libcore/tests/cell.rs:225:12
[01:24:37]     |
[01:24:37]     |
[01:24:37] 225 |     let d: Ref<u32> = x.accessor();
[01:24:37]     |            ^^^^^^^^ help: indicate the anonymous lifetime: `Ref<'_, u32>`
[01:24:37] error: hidden lifetime parameters in types are deprecated
[01:24:37]    --> src/libcore/../libcore/tests/cell.rs:220:31
[01:24:37]     |
[01:24:37]     |
[01:24:37] 220 |         fn accessor(&self) -> Ref<u32> {
[01:24:37]     |                               ^^^^^^^^ help: indicate the anonymous lifetime: `Ref<'_, u32>`
[01:24:37] error: hidden lifetime parameters in types are deprecated
[01:24:37]    --> src/libcore/../libcore/tests/cell.rs:239:20
[01:24:37]     |
[01:24:37]     |
[01:24:37] 239 |         let mut d: RefMut<u32> = x.accessor();
[01:24:37]     |                    ^^^^^^^^^^^ help: indicate the anonymous lifetime: `RefMut<'_, u32>`
[01:24:37] error: hidden lifetime parameters in types are deprecated
[01:24:37]    --> src/libcore/../libcore/tests/cell.rs:233:31
[01:24:37]     |
[01:24:37]     |
[01:24:37] 233 |         fn accessor(&self) -> RefMut<u32> {
[01:24:37]     |                               ^^^^^^^^^^^ help: indicate the anonymous lifetime: `RefMut<'_, u32>`
[01:24:37] error: hidden lifetime parameters in types are deprecated
[01:24:37]    --> src/libcore/../libcore/tests/cell.rs:336:26
[01:24:37]     |
[01:24:37]     |
[01:24:37] 336 |         let mut cellref: RefMut<[i32; 3]> = cell.borrow_mut();
[01:24:37]     |                          ^^^^^^^^^^^^^^^^ help: indicate the anonymous lifetime: `RefMut<'_, [i32; 3]>`
[01:24:37] error: hidden lifetime parameters in types are deprecated
[01:24:37]    --> src/libcore/../libcore/tests/cell.rs:338:26
[01:24:37]     |
[01:24:37]     |
[01:24:37] 338 |         let mut coerced: RefMut<[i32]> = cellref;
[01:24:37]     |                          ^^^^^^^^^^^^^ help: indicate the anonymous lifetime: `RefMut<'_, [i32]>`
[01:24:37] error: hidden lifetime parameters in types are deprecated
[01:24:37]    --> src/libcore/../libcore/tests/cell.rs:343:22
[01:24:37]     |
[01:24:37]     |
[01:24:37] 343 |         let cellref: Ref<[i32; 3]> = cell.borrow();
[01:24:37]     |                      ^^^^^^^^^^^^^ help: indicate the anonymous lifetime: `Ref<'_, [i32; 3]>`
[01:24:37] error: hidden lifetime parameters in types are deprecated
[01:24:37]    --> src/libcore/../libcore/tests/cell.rs:345:22
[01:24:37]     |
[01:24:37]     |
[01:24:37] 345 |         let coerced: Ref<[i32]> = cellref;
[01:24:37]     |                      ^^^^^^^^^^ help: indicate the anonymous lifetime: `Ref<'_, [i32]>`
[01:24:37] error: hidden lifetime parameters in types are deprecated
[01:24:37]  --> src/libcore/../libcore/tests/fmt/builders.rs:9:37
[01:24:37]   |
[01:24:37] 9 |             fn fmt(&self, fmt: &mut fmt::Formatter) -> fmt::Result {
---
[01:24:37] 
[01:24:37] error: hidden lifetime parameters in types are deprecated
[01:24:37]    --> src/libcore/../libcore/tests/iter.rs:575:32
[01:24:37]     |
[01:24:37] 575 | pub fn cycle<T>(data: &[T]) -> CycleIter<T> {
[01:24:37]     |                                ^^^^^^^^^^^^ help: indicate the anonymous lifetime: `CycleIter<'_, T>`
[01:24:49] error: unused extern crate
[01:24:49]   --> src/libcore/../libcore/tests/lib.rs:36:1
[01:24:49]    |
[01:24:49] 36 | extern crate core;
[01:24:49] 36 | extern crate core;
[01:24:49]    | ^^^^^^^^^^^^^^^^^^ help: remove it
[01:24:49]    |
[01:24:49]    = note: `-D unused-extern-crates` implied by `-D rust-2018-idioms`
[01:24:49] error: aborting due to 37 previous errors
[01:24:49] 
[01:24:49] error: Could not compile `core`.
[01:24:49] 
[01:24:49] 
[01:24:49] To learn more, run the command again with --verbose.
[01:24:49] 
[01:24:49] 
[01:24:49] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-p" "core" "--" "--quiet"
[01:24:49] 
[01:24:49] 
[01:24:49] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:24:49] Build completed unsuccessfully in 0:22:38
[01:24:49] Build completed unsuccessfully in 0:22:38
[01:24:49] make: *** [check] Error 1
[01:24:49] Makefile:48: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:184d34fc
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Sat Apr 20 15:31:52 UTC 2019
---
travis_time:end:0b3a4960:start=1555774314670690126,finish=1555774314676725493,duration=6035367
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:028cbe08
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:1aa65de0
travis_time:start:1aa65de0
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:10e82848
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Apr 20, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:0a8b9aa0:start=1555778769937170543,finish=1555778861195674319,duration=91258503776
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
travis_time:start:test_assembly
Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:13:59] 
[01:13:59] running 9 tests
[01:13:59] iiiiiiiii
[01:13:59] 
[01:13:59]  finished in 0.158
[01:13:59] travis_fold:end:test_assembly

---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:14:15] 
[01:14:15] running 121 tests
[01:14:40] .iiiii...i.....i..i...i..i.i.i..i.ii...i.....i..i....i..........iiii..........i...ii...i.......ii.i. 100/121
[01:14:44] i.i......iii.i.....ii
[01:14:44] 
[01:14:44]  finished in 29.577
[01:14:44] travis_fold:end:test_debuginfo

---
[01:39:01]   |
[01:39:01] 1 | extern crate serialize as rustc_serialize;
[01:39:01]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert it to a `use`
[01:39:01]   |
[01:39:01]   = note: `-D unused-extern-crates` implied by `-D rust-2018-idioms`
[01:39:01] error: aborting due to previous error
[01:39:01] 
[01:39:01] error: Could not compile `serialize`.
[01:39:01] warning: build failed, waiting for other jobs to finish...
[01:39:01] warning: build failed, waiting for other jobs to finish...
[01:39:01] error: `extern crate` is not idiomatic in the new edition
[01:39:01]  --> src/libserialize/tests/json.rs:1:1
[01:39:01]   |
[01:39:01] 1 | extern crate serialize as rustc_serialize;
[01:39:01]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert it to a `use`
[01:39:01]   |
[01:39:01]   = note: `-D unused-extern-crates` implied by `-D rust-2018-idioms`
[01:39:01] error: aborting due to previous error
[01:39:01] 
[01:39:01] error: Could not compile `serialize`.
[01:39:01] warning: build failed, waiting for other jobs to finish...
[01:39:01] warning: build failed, waiting for other jobs to finish...
[01:39:05] error: build failed
[01:39:05] 
[01:39:05] 
[01:39:05] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "-p" "serialize" "--" "--quiet"
[01:39:05] 
[01:39:05] 
[01:39:05] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:39:05] Build completed unsuccessfully in 0:36:54
[01:39:05] Build completed unsuccessfully in 0:36:54
[01:39:05] Makefile:48: recipe for target 'check' failed
[01:39:05] make: *** [check] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0047aa40
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Sat Apr 20 18:26:56 UTC 2019
---
travis_time:end:0e26b56b:start=1555784817622832312,finish=1555784817681360345,duration=58528033
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:08fbe04e
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:1f77a708
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@phansch phansch changed the title Deny rust_2018_idioms globally WIP: Deny rust_2018_idioms globally Apr 20, 2019

@Centril

This comment has been minimized.

Copy link
Member

commented Apr 20, 2019

@phansch phansch changed the title WIP: Deny rust_2018_idioms globally Deny rust_2018_idioms globally Apr 21, 2019

@phansch

This comment has been minimized.

Copy link
Contributor Author

commented Apr 21, 2019

I'm not sure if there are alternatives to 8e55559. Apart from that, I think this PR is ready.

@Centril

This comment has been minimized.

Copy link
Member

commented Apr 22, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 22, 2019

📌 Commit 8e55559 has been approved by Centril

@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 22, 2019

⌛️ Testing commit 8e55559 with merge 5452576...

bors added a commit that referenced this pull request Apr 22, 2019

@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 22, 2019

💔 Test failed - checks-travis

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Apr 22, 2019

The job asmjs of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[01:18:26] test [run-pass] run-pass/associated-types/associated-types-projection-in-supertrait.rs ... ok
[01:18:27] test [run-pass] run-pass/associated-types/associated-types-projection-in-where-clause.rs ... ok
[01:18:27] test [run-pass] run-pass/associated-types/associated-types-projection-to-unrelated-trait.rs ... ok
[01:18:28] test [run-pass] run-pass/associated-types/associated-types-qualified-path-with-trait-with-type-parameters.rs ... ok
No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Centril

This comment has been minimized.

Copy link
Member

commented Apr 22, 2019

@bors retry

@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 22, 2019

⌛️ Testing commit 8e55559 with merge a850a42...

bors added a commit that referenced this pull request Apr 22, 2019

@@ -7,6 +7,7 @@
#![feature(try_reserve)]
#![feature(unboxed_closures)]
#![feature(vecdeque_rotate)]
#![deny(rust_2018_idioms)]

This comment has been minimized.

Copy link
@petrochenkov

petrochenkov Apr 22, 2019

Contributor

I don't understand why it's denied here if it was denied in rustbuild already.
Also, why aren't all the deny(rust_2018_idioms)s in specific crates removed?

This comment has been minimized.

Copy link
@Centril

Centril Apr 22, 2019

Member

We can remove them in a follow up. However, I personally prefer to keep them as it works better when you cargo check a crate without x.py.

@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 22, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Centril
Pushing a850a42 to master...

@bors bors added the merged-by-bors label Apr 22, 2019

@bors bors merged commit 8e55559 into rust-lang:master Apr 22, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
homu Test successful
Details

@phansch phansch deleted the phansch:deny_rust_2018_idioms branch Apr 22, 2019


extern crate core;
extern crate test;

This comment has been minimized.

Copy link
@RalfJung

RalfJung Apr 23, 2019

Member

Any idea why you didn't also have to remove this line? It causes a build failure when building the tests "from the outside" at https://travis-ci.org/RalfJung/miri-test-libstd/builds/523334973.

This comment has been minimized.

Copy link
@phansch

phansch Apr 23, 2019

Author Contributor

I'm not really sure. Do you maybe have to pass --test in order for the crate to be used?

This comment has been minimized.

Copy link
@RalfJung

RalfJung Apr 23, 2019

Member

Hm, no... removing it actually makes it fail in x.py. But somehow it is considered redundant when compiled in a less magic environment?

This comment has been minimized.

Copy link
@phansch

phansch Apr 23, 2019

Author Contributor

I think adding #[allow(unused_extern_crates)] before extern crate test; should fix it (like here), but I won't be able to actually try it out until later today.

This comment has been minimized.

Copy link
@RalfJung

RalfJung Apr 23, 2019

Member

This should also work: #60201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.