Suggest dereferencing when Deref is implemented.
#60155
Conversation
This commit adds a test that demonstrates the current behaviour where suggestions to add a dereference aren't given for non-references.
This commit suggests dereferencing a type when it implements `Deref` with the correct `Output` associated type.
rust-highfive
added
the
S-waiting-on-review
src/librustc_typeck/check/demand.rs
Outdated
| @@ -463,6 +463,57 @@ impl<'a, 'gcx, 'tcx> FnCtxt<'a, 'gcx, 'tcx> { | |||
| } | |||
| } | |||
| } | |||
| _ if sp == expr.span => { | |||
| // If neither type is a reference, then check for `Deref` implementations by | |||
There was a problem hiding this comment.
Seems like a good place to refactor into function(s)?
|
General note: When I wrote the issue I hoped that we could deduplicate the logic on references with the new logic you wrote. References also implement |
I just tried this and I don't think it does, when I check if |
Maybe we need to try something different then. Check whether the type implements |
I have no idea what I was trying earlier, pushed a version that de-duplicates that logic. |
This commit makes the suggestion to dereference when a type implements `Deref` only apply if the dereference would succeed (ie. the type is `Copy`, otherwise a borrow check error would occur).
|
@bors r+ This is absolutely awesome! |
|
📌 Commit 7ab1bfd has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-travis, status-appveyor |
Fixes #59819.
r? @oli-obk
cc @estebank