Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix async fn lowering ICE with APIT. #60527

Merged
merged 1 commit into from May 4, 2019

Conversation

Projects
None yet
4 participants
@davidtwco
Copy link
Member

commented May 3, 2019

Fixes #60518.

This PR fixes an ICE where simple bindings (which aren't replaced with replacement arguments during async fn lowering) were not being visited in the def collector and thus caused an ICE during HIR lowering for types that use their DefId at that point - such as impl Trait.

r? @cramertj

Fix async fn lowering ICE with APIT.
This commit fixes an ICE where simple bindings (which aren't replaced
with replacement arguments during async fn lowering) were not being
visited in the def collector and thus caused an ICE during HIR lowering
for types that use their `DefId` at that point - such as `impl Trait`.
@cramertj

This comment has been minimized.

Copy link
Member

commented May 4, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented May 4, 2019

📌 Commit f346309 has been approved by cramertj

Centril added a commit to Centril/rust that referenced this pull request May 4, 2019

Rollup merge of rust-lang#60527 - davidtwco:issue-60518, r=cramertj
Fix async fn lowering ICE with APIT.

Fixes rust-lang#60518.

This PR fixes an ICE where simple bindings (which aren't replaced with replacement arguments during async fn lowering) were not being visited in the def collector and thus caused an ICE during HIR lowering for types that use their `DefId` at that point - such as `impl Trait`.

r? @cramertj

@Centril Centril referenced this pull request May 4, 2019

Merged

Rollup of 9 pull requests #60537

bors added a commit that referenced this pull request May 4, 2019

Auto merge of #60537 - Centril:rollup-42jxz82, r=Centril
Rollup of 9 pull requests

Successful merges:

 - #60429 (Account for paths in incorrect pub qualifier help)
 - #60449 (Constrain all regions in the concrete type for an opaque type)
 - #60486 (Place related refactors)
 - #60513 (Remove -Z borrowck=compare flag)
 - #60516 (Remove TypeckMir)
 - #60517 (Reword casting message)
 - #60520 (Add rustfmt toml)
 - #60521 (Migrate tidy to rust 2018 edition)
 - #60527 (Fix async fn lowering ICE with APIT.)

Failed merges:

r? @ghost
@bors

This comment has been minimized.

Copy link
Contributor

commented May 4, 2019

☔️ The latest upstream changes (presumably #60537) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors merged commit f346309 into rust-lang:master May 4, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@davidtwco davidtwco deleted the davidtwco:issue-60518 branch May 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.