Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the Alloc trait to AllocHandle #60591

Open
wants to merge 1 commit into
base: master
from

Conversation

@SimonSapin
Copy link
Contributor

commented May 6, 2019

This is a breaking change to an unstable API.
Fixes rust-lang/wg-allocators#8

This change has some consensus in its issue. Landing it now will hopefully help clarify the vocabulary, including for discussion within the Allocators WG itself.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented May 6, 2019

r? @Kimundi

(rust_highfive has picked a reviewer for you, use r? to override)

@SimonSapin

This comment has been minimized.

Copy link
Contributor Author

commented May 6, 2019

@alexcrichton My understanding of our process is that we have no strict requirement for making any change to unstable APIs. However this one has been around for a long time. How do you think we should proceed with changes like this?

Rename the Alloc trait to AllocHandle
This is a breaking change to an unstable API.
Fixes rust-lang/wg-allocators#8

This change has some consensus.
Landing it now will hopefully help clarify the vocabulary,
including for discussion within the Allocators WG itself.

@SimonSapin SimonSapin force-pushed the SimonSapin:handle branch from e4bdf48 to cad92e5 May 6, 2019

@cramertj

This comment has been minimized.

Copy link
Member

commented May 7, 2019

Perhaps adding a separately-feature-gated type alias would help with the transition?

@SimonSapin

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

This is a trait, not a type.

AFAIR stability and deprecation attributes have no effect on pub use reexports. Has that changed?

@alexcrichton

This comment has been minimized.

Copy link
Member

commented May 8, 2019

I don't personally have a preference for how the WG operates and lands code, I'd leave that up to y'all!

I would personally consider any modifications to any unstable code ok to land at any time in terms of "scope", but I'd leave it up to the WG to determine how exactly the mode of operation should be done.

@Dylan-DPC

This comment has been minimized.

Copy link
Member

commented May 20, 2019

ping from triage @rust-lang/libs any updates?

@alexcrichton

This comment has been minimized.

Copy link
Member

commented May 20, 2019

This is a blocked on a decision from the WG, so tagging as such.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.