Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize vecdeque_rotate #60678

Merged
merged 2 commits into from May 19, 2019

Conversation

Projects
None yet
5 participants
@DutchGhost
Copy link
Contributor

commented May 9, 2019

This PR stabilizes the vecdeque_rotate feature.
r? @scottmcm

Closes #56686

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented May 9, 2019

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @scottmcm (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@DutchGhost DutchGhost changed the title Stableize vecdeque_rotate Stabilize vecdeque_rotate May 9, 2019

@scottmcm scottmcm added the S-blocked label May 9, 2019

@scottmcm

This comment has been minimized.

Copy link
Member

commented May 9, 2019

Marked blocked on the FCP in the tracking issue (for another 9-ish days)

@Centril Centril added the T-libs label May 9, 2019

@Centril Centril added this to the 1.36 milestone May 9, 2019

@Centril Centril added relnotes and removed S-waiting-on-review labels May 9, 2019

@scottmcm

This comment has been minimized.

Copy link
Member

commented May 18, 2019

Looks like the FCP finished uneventfully (thanks for tag fixing @Centril), so

@bors r+ rollup

Thanks for the PR, @DutchGhost!

@bors

This comment has been minimized.

Copy link
Contributor

commented May 18, 2019

📌 Commit 4d03399 has been approved by scottmcm

@bors bors added S-waiting-on-bors and removed S-blocked labels May 18, 2019

Centril added a commit to Centril/rust that referenced this pull request May 19, 2019

Rollup merge of rust-lang#60678 - DutchGhost:master, r=scottmcm
Stabilize vecdeque_rotate

This PR stabilizes the vecdeque_rotate feature.
r? @scottmcm

Closes rust-lang#56686

bors added a commit that referenced this pull request May 19, 2019

Auto merge of #60949 - Centril:rollup-f918e1v, r=Centril
Rollup of 8 pull requests

Successful merges:

 - #60370 (Mark core::alloc::Layout::from_size_align_unchecked const)
 - #60678 (Stabilize vecdeque_rotate)
 - #60924 (Explain that ? converts the error type using From)
 - #60931 (Use iter() for iterating arrays by slice)
 - #60934 (Declare DefIndex with the newtype_index macro)
 - #60943 (fix copy-paste typo in docs for ptr::read_volatile)
 - #60945 (Simplify BufRead::fill_buf doc example using NLL)
 - #60947 (Fix typos in docs of GlobalAlloc)

Failed merges:

r? @ghost

@bors bors merged commit 4d03399 into rust-lang:master May 19, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.