Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more escaping ReScopes #60765

Merged
merged 3 commits into from May 13, 2019

Conversation

Projects
None yet
8 participants
@matthewjasper
Copy link
Contributor

commented May 12, 2019

Closes #58840

matthewjasper added some commits May 12, 2019

Don't allow any ReScope in impl trait types
This shouldn't be possible any more, but if it does happen, emit an
error rather than maybe panicking later when NLL finds a the ReScope.
Impl trait in bindings is sufficiently broken that I don't think this
breaks anything that works for it.
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented May 12, 2019

r? @oli-obk

(rust_highfive has picked a reviewer for you, use r? to override)

@oli-obk

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

📌 Commit 9a4f0ab has been approved by oli-obk

@bors

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

⌛️ Testing commit 9a4f0ab with merge 69ef8fb...

bors added a commit that referenced this pull request May 13, 2019

Auto merge of #60765 - matthewjasper:fix-more-escaping-rescopes, r=ol…
…i-obk

Fix more escaping ReScopes

Closes #58840
@bors

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing 69ef8fb to master...

@bors bors added the merged-by-bors label May 13, 2019

@bors bors merged commit 9a4f0ab into rust-lang:master May 13, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@jsgf

This comment has been minimized.

Copy link
Contributor

commented May 14, 2019

Will this be in 1.35?

@matthewjasper matthewjasper deleted the matthewjasper:fix-more-escaping-rescopes branch May 17, 2019

@pnkfelix

This comment has been minimized.

Copy link
Member

commented Jun 6, 2019

discussed in T-compiler meeting. Accepted for backport to stable channel.

@Centril

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

Discussed on T-release meeting; declining point release for now based on sum-total of stable-accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.