Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use `Symbol` more in lint APIs #60827

Merged
merged 1 commit into from May 27, 2019

Conversation

Projects
None yet
6 participants
@oli-obk
Copy link
Contributor

commented May 14, 2019

r? @nnethercote

This will cause clippy breakage, but super trivial to fix since we can then remove the hacky match_def_path function that I added and go back to calling rustc's match_def_path method.

@nnethercote

This comment has been minimized.

Copy link
Contributor

commented May 14, 2019

@bors r+

But we need to coordinate... I'm working on more Symbol changes, e.g. #60815. I'm doing some ad hoc profiling to work out which ones are likely to affect performance. If we have multiple people doing these conversions there's a good chance there will be overlap.

@bors

This comment has been minimized.

Copy link
Contributor

commented May 14, 2019

📌 Commit 1107158 has been approved by nnethercote

This was referenced May 15, 2019

bors added a commit that referenced this pull request May 15, 2019

Auto merge of #60844 - Centril:rollup-1g9brpm, r=Centril
Rollup of 6 pull requests

Successful merges:

 - #59276 (Cleanup (pretty) printing of `ty::Const`)
 - #60174 (Add match arm scopes and other scope fixes)
 - #60693 (refactor some `FnType` stuff to `rustc::ty::layout`)
 - #60763 (Move token tree related lexer state to a separate struct)
 - #60811 (Bump measureme dependency to 0.3)
 - #60832 (CMake: Do not print installation messages for up-to-date files)

Failed merges:

 - #60827 (Use `Symbol` more in lint APIs)

r? @ghost
@oli-obk

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

Yes, I tried not to touch anything else out of that reason. I did this just to remove hacks from clippy

Centril added a commit to Centril/rust that referenced this pull request May 15, 2019

Rollup merge of rust-lang#60827 - oli-obk:late_symbol, r=nnethercote
Use `Symbol` more in lint APIs

r? @nnethercote

This will cause clippy breakage, but super trivial to fix since we can then remove the hacky `match_def_path` function that I added and go back to calling rustc's `match_def_path` method.

bors added a commit that referenced this pull request May 15, 2019

Auto merge of #60859 - Centril:rollup-x7rcz9c, r=Centril
Rollup of 9 pull requests

Successful merges:

 - #59825 (string: implement From<&String> for String)
 - #59923 (Fix convert module's documentation links)
 - #60691 (Include expression to wait for to the span of Await)
 - #60763 (Move token tree related lexer state to a separate struct)
 - #60769 (Update rustc book CLI docs.)
 - #60811 (Bump measureme dependency to 0.3)
 - #60816 (README.md: Mention MSVC 2017+, not 2013(!))
 - #60827 (Use `Symbol` more in lint APIs)
 - #60851 (Move `box` from the stable keyword to unstable keywords list)

Failed merges:

r? @ghost
@Centril

This comment has been minimized.

Copy link
Member

commented May 15, 2019

Toolstate breakage in #60859 (comment), @bors r-

@bors

This comment has been minimized.

Copy link
Contributor

commented May 20, 2019

☔️ The latest upstream changes (presumably #60969) made this pull request unmergeable. Please resolve the merge conflicts.

@oli-obk oli-obk force-pushed the oli-obk:late_symbol branch from 1107158 to 254b924 May 25, 2019

@oli-obk

This comment has been minimized.

Copy link
Contributor Author

commented May 27, 2019

@bors r=nnethercote

@bors

This comment has been minimized.

Copy link
Contributor

commented May 27, 2019

📌 Commit 254b924 has been approved by nnethercote

@bors

This comment has been minimized.

Copy link
Contributor

commented May 27, 2019

☔️ The latest upstream changes (presumably #61035) made this pull request unmergeable. Please resolve the merge conflicts.

@oli-obk oli-obk force-pushed the oli-obk:late_symbol branch from 254b924 to d6ca34c May 27, 2019

@oli-obk

This comment has been minimized.

Copy link
Contributor Author

commented May 27, 2019

@bors r=nnethercote

@bors

This comment has been minimized.

Copy link
Contributor

commented May 27, 2019

📌 Commit d6ca34c has been approved by nnethercote

Centril added a commit to Centril/rust that referenced this pull request May 27, 2019

Rollup merge of rust-lang#60827 - oli-obk:late_symbol, r=nnethercote
Use `Symbol` more in lint APIs

r? @nnethercote

This will cause clippy breakage, but super trivial to fix since we can then remove the hacky `match_def_path` function that I added and go back to calling rustc's `match_def_path` method.
@bors

This comment has been minimized.

Copy link
Contributor

commented May 27, 2019

⌛️ Testing commit d6ca34c with merge fa40a11...

bors added a commit that referenced this pull request May 27, 2019

Auto merge of #60827 - oli-obk:late_symbol, r=nnethercote
Use `Symbol` more in lint APIs

r? @nnethercote

This will cause clippy breakage, but super trivial to fix since we can then remove the hacky `match_def_path` function that I added and go back to calling rustc's `match_def_path` method.

@bors bors referenced this pull request May 27, 2019

Merged

Bump nightly to 1.37.0 #61078

@bors

This comment has been minimized.

Copy link
Contributor

commented May 27, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: nnethercote
Pushing fa40a11 to master...

@bors bors added the merged-by-bors label May 27, 2019

@bors bors merged commit d6ca34c into rust-lang:master May 27, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented May 27, 2019

📣 Toolstate changed by #60827!

Tested on commit fa40a11.
Direct link to PR: #60827

💔 clippy-driver on windows: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
💔 clippy-driver on linux: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
💔 rls on windows: test-pass → build-fail (cc @Xanewok, @rust-lang/infra).
💔 rls on linux: test-pass → build-fail (cc @Xanewok, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request May 27, 2019

📣 Toolstate changed by rust-lang/rust#60827!
Tested on commit rust-lang/rust@fa40a11.
Direct link to PR: <rust-lang/rust#60827>

💔 clippy-driver on windows: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
💔 clippy-driver on linux: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
💔 rls on windows: test-pass → build-fail (cc @Xanewok, @rust-lang/infra).
💔 rls on linux: test-pass → build-fail (cc @Xanewok, @rust-lang/infra).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.