Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize RefCell::try_borrow_unguarded #60850

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@SimonSapin
Copy link
Contributor

commented May 15, 2019

Servo has been using this since servo/servo#23196 to add a runtime check to some unsafe code, as discussed in PR #59211. Stabilizing would help do more of the same in libraries that also have users on Stable.

Stabilize RefCell::try_borrow_unguarded
Servo has been using this since servo/servo#23196 to add a runtime check to some unsafe code, as discussed in PR #59211. Stabilizing would help do more of the same in libraries that also have users on Stable.
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented May 15, 2019

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@@ -984,7 +983,7 @@ impl<T: ?Sized> RefCell<T> {
/// assert!(unsafe { c.try_borrow_unguarded() }.is_ok());
/// }
/// ```
#[unstable(feature = "borrow_state", issue = "27733")]
#[stable(feature = "borrow_state", since = "1.37.0")]

This comment has been minimized.

Copy link
@SimonSapin

SimonSapin May 15, 2019

Author Contributor

The 1.37 cycle starts in less than the FCP’s ten days.

@SimonSapin

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

@rfcbot fcp merge

@rfcbot

This comment has been minimized.

Copy link

commented May 15, 2019

Team member @SimonSapin has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot

This comment has been minimized.

Copy link

commented May 19, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.