Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc: Improve type size assertions #60959

Merged
merged 1 commit into from May 21, 2019

Conversation

Projects
None yet
4 participants
@petrochenkov
Copy link
Contributor

commented May 19, 2019

Now they

  • Tell what the new size is, when it changes
  • Do not require passing an identifier
   ::: src\libsyntax\parse\token.rs:223:1
    |
223 |    static_assert_size!(Token, 123);
    |    -------------------------------- in this macro invocation
    |
    = note: expected type `[(); 123]`
               found type `[(); 16]`
Improve type size assertions
Now they
- Tell what the new size is, when it changes
- Do not require passing an identifier
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented May 19, 2019

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@estebank

This comment has been minimized.

Copy link
Contributor

commented May 20, 2019

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

commented May 20, 2019

📌 Commit 88fa5c6 has been approved by estebank

Centril added a commit to Centril/rust that referenced this pull request May 20, 2019

Rollup merge of rust-lang#60959 - petrochenkov:sassert, r=estebank
rustc: Improve type size assertions

Now they
- Tell what the new size is, when it changes
- Do not require passing an identifier

```
   ::: src\libsyntax\parse\token.rs:223:1
    |
223 |    static_assert_size!(Token, 123);
    |    -------------------------------- in this macro invocation
    |
    = note: expected type `[(); 123]`
               found type `[(); 16]`
```

bors added a commit that referenced this pull request May 20, 2019

Auto merge of #60986 - Centril:rollup-nhpgrfb, r=Centril
Rollup of 11 pull requests

Successful merges:

 - #60383 (Fix position source code files toggle)
 - #60453 (Fall back to `/dev/urandom` on `EPERM` for `getrandom`)
 - #60487 (Fix search sidebar width when no crate select is present)
 - #60511 (Fix intra-doc link resolution failure on re-exporting libstd)
 - #60823 (Fix incremental compilation of cdylib emitting spurious unused_attributes lint)
 - #60915 (stable hashing: Remove unused field and add documentation.)
 - #60942 (Misc changes to rustc_metadata)
 - #60952 (Document BinaryHeap time complexity)
 - #60959 (rustc: Improve type size assertions)
 - #60972 (remove confusing remarks about mixed volatile and non-volatile accesses)
 - #60983 (Set -funwind-tables and -fno-exceptions unconditionally for LLVM's libunwind)

Failed merges:

r? @ghost

@bors bors merged commit 88fa5c6 into rust-lang:master May 21, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@petrochenkov petrochenkov deleted the petrochenkov:sassert branch Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.