Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using gensyms in HIR lowering #60960

Merged
merged 1 commit into from May 20, 2019

Conversation

Projects
None yet
4 participants
@matthewjasper
Copy link
Contributor

commented May 19, 2019

These names aren't ever handled by resolve, so there's no reason to
make them gensyms.

Diagnostics wanting to behave differently for these variables should
inspect either the MatchSource/LocalSource or the Span. All
current diagnostics appear to do this.

r? @petrochenkov

Stop using gensyms in HIR lowering
These names aren't ever handled by resolve, so there's no reason to
make them gensyms.
@petrochenkov

This comment has been minimized.

Copy link
Contributor

commented May 19, 2019

Thanks!
@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented May 19, 2019

📌 Commit 6bb3980 has been approved by petrochenkov

Centril added a commit to Centril/rust that referenced this pull request May 19, 2019

Rollup merge of rust-lang#60960 - matthewjasper:remove-lowering-gensy…
…m, r=petrochenkov

Stop using gensyms in HIR lowering

These names aren't ever handled by resolve, so there's no reason to
make them gensyms.

Diagnostics wanting to behave differently for these variables should
inspect either the `MatchSource`/`LocalSource` or the `Span`. All
current diagnostics appear to do this.

r? @petrochenkov

bors added a commit that referenced this pull request May 20, 2019

Auto merge of #60969 - Centril:rollup-3j71mqj, r=Centril
Rollup of 6 pull requests

Successful merges:

 - #60590 (Test interaction of unions with non-zero/niche-filling optimization)
 - #60745 (Perform constant propagation into terminators)
 - #60895 (Enable thumbv7a-pc-windows-msvc target build end to end in rust/master)
 - #60908 (Fix lints handling in rustdoc)
 - #60960 (Stop using gensyms in HIR lowering)
 - #60962 (Fix data types indication)

Failed merges:

r? @ghost

@bors bors merged commit 6bb3980 into rust-lang:master May 20, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@matthewjasper matthewjasper deleted the matthewjasper:remove-lowering-gensym branch May 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.