Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaybeUninit doctest: remove unnecessary type ascription #61161

Merged
merged 1 commit into from May 26, 2019

Conversation

Projects
None yet
6 participants
@RalfJung
Copy link
Member

commented May 25, 2019

No description provided.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented May 25, 2019

r? @Kimundi

(rust_highfive has picked a reviewer for you, use r? to override)

@@ -1071,7 +1071,7 @@ impl<T: ?Sized> DerefMut for ManuallyDrop<T> {
/// optimizations, potentially resulting in a larger size:
///
/// ```rust
/// # use std::mem::{MaybeUninit, size_of, align_of};
/// # use std::mem::{MaybeUninit, size_of};

This comment has been minimized.

Copy link
@RalfJung

RalfJung May 25, 2019

Author Member

I had to fix this to make the tests pass... makes me wonder why are passing on CI.

This comment has been minimized.

Copy link
@ollie27

ollie27 May 25, 2019

Contributor

This was my mistake: #59940 (comment).

@Centril

This comment has been minimized.

Copy link
Member

commented May 25, 2019

r? @Centril @bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

commented May 25, 2019

📌 Commit 72145ea has been approved by Centril

@rust-highfive rust-highfive assigned Centril and unassigned Kimundi May 25, 2019

Centril added a commit to Centril/rust that referenced this pull request May 25, 2019

Rollup merge of rust-lang#61161 - RalfJung:maybe-uninit, r=Centril
MaybeUninit doctest: remove unnecessary type ascription

bors added a commit that referenced this pull request May 25, 2019

Auto merge of #61171 - Centril:rollup-8lkypo8, r=Centril
Rollup of 5 pull requests

Successful merges:

 - #61036 (PGO - Add a smoketest for combining PGO with cross-language LTO.)
 - #61077 (Don't arena-allocate static symbols.)
 - #61080 (Ship profiler with windows-gnu)
 - #61149 (Fix spelling in release notes)
 - #61161 (MaybeUninit doctest: remove unnecessary type ascription)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request May 25, 2019

Rollup merge of rust-lang#61161 - RalfJung:maybe-uninit, r=Centril
MaybeUninit doctest: remove unnecessary type ascription

Centril added a commit to Centril/rust that referenced this pull request May 25, 2019

Rollup merge of rust-lang#61161 - RalfJung:maybe-uninit, r=Centril
MaybeUninit doctest: remove unnecessary type ascription

bors added a commit that referenced this pull request May 25, 2019

Auto merge of #61178 - Centril:rollup-fis8hkk, r=Centril
Rollup of 7 pull requests

Successful merges:

 - #60928 (Changes the type `mir::Mir` into `mir::Body`)
 - #61036 (PGO - Add a smoketest for combining PGO with cross-language LTO.)
 - #61077 (Don't arena-allocate static symbols.)
 - #61080 (Ship profiler with windows-gnu)
 - #61149 (Fix spelling in release notes)
 - #61161 (MaybeUninit doctest: remove unnecessary type ascription)
 - #61173 (Auto-derive Encode and Decode implementations of DefPathTable)

Failed merges:

r? @ghost

bors added a commit that referenced this pull request May 25, 2019

Auto merge of #61178 - Centril:rollup-fis8hkk, r=Centril
Rollup of 7 pull requests

Successful merges:

 - #60928 (Changes the type `mir::Mir` into `mir::Body`)
 - #61036 (PGO - Add a smoketest for combining PGO with cross-language LTO.)
 - #61077 (Don't arena-allocate static symbols.)
 - #61080 (Ship profiler with windows-gnu)
 - #61149 (Fix spelling in release notes)
 - #61161 (MaybeUninit doctest: remove unnecessary type ascription)
 - #61173 (Auto-derive Encode and Decode implementations of DefPathTable)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request May 25, 2019

Rollup merge of rust-lang#61161 - RalfJung:maybe-uninit, r=Centril
MaybeUninit doctest: remove unnecessary type ascription

Centril added a commit to Centril/rust that referenced this pull request May 26, 2019

Rollup merge of rust-lang#61161 - RalfJung:maybe-uninit, r=Centril
MaybeUninit doctest: remove unnecessary type ascription

bors added a commit that referenced this pull request May 26, 2019

Auto merge of #61201 - Centril:rollup-975knrk, r=Centril
Rollup of 9 pull requests

Successful merges:

 - #61087 (Tweak `self` arg not as first argument of a method diagnostic)
 - #61114 (Vec: avoid creating slices to the elements)
 - #61144 (Suggest borrowing for loop head on move error)
 - #61149 (Fix spelling in release notes)
 - #61161 (MaybeUninit doctest: remove unnecessary type ascription)
 - #61173 (Auto-derive Encode and Decode implementations of DefPathTable)
 - #61184 (Add additional trace statements to the const propagator)
 - #61189 (Turn turbo 🐟 🍨 into an error)
 - #61193 (Add comment to explain why we change the layout for Projection)

Failed merges:

r? @ghost

bors added a commit that referenced this pull request May 26, 2019

Auto merge of #61201 - Centril:rollup-975knrk, r=Centril
Rollup of 9 pull requests

Successful merges:

 - #61087 (Tweak `self` arg not as first argument of a method diagnostic)
 - #61114 (Vec: avoid creating slices to the elements)
 - #61144 (Suggest borrowing for loop head on move error)
 - #61149 (Fix spelling in release notes)
 - #61161 (MaybeUninit doctest: remove unnecessary type ascription)
 - #61173 (Auto-derive Encode and Decode implementations of DefPathTable)
 - #61184 (Add additional trace statements to the const propagator)
 - #61189 (Turn turbo 🐟 🍨 into an error)
 - #61193 (Add comment to explain why we change the layout for Projection)

Failed merges:

r? @ghost

@bors bors merged commit 72145ea into rust-lang:master May 26, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@ollie27 ollie27 referenced this pull request Jun 26, 2019

Merged

[beta] Rollup backports #62065

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.