Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ellipsis_inclusive_range_patterns lint to warn #61342

Merged

Conversation

Projects
None yet
4 participants
@memoryruins
Copy link
Contributor

commented May 30, 2019

Continuing #54910, the ellipsis_inclusive_range_patterns lint is set to warn.

r? @Centril

@Centril

This comment has been minimized.

Copy link
Member

commented May 30, 2019

@rust-lang/lang N.B. This transitions a Rust 2018 idiom lint towards Warn by default instead of Allow. The justification was given by @aturon in #28237 (comment).

I believe @joshtriplett's comment in #61203 (comment) applies here as well:

Note that under normal circumstances, I'd say we need a crater run to assess the impact of even a new warning, as that can cause build failures (deny(warnings)). However, as this was announced and advertised as part of the Rust 2018 edition, I think we can reasonably introduce it as an idiom lint, to be enabled as part of that family of lints.

This is probably less widespread than dyn Trait also, so we should be good.

@memoryruins memoryruins force-pushed the memoryruins:ellipsis_inclusive_range_patterns branch from a982d59 to e18885e May 30, 2019

@Centril
Copy link
Member

left a comment

Thanks! r=me rollup with green travis.

@memoryruins

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

@bors r=Centril rollup

@bors

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

@memoryruins: 🔑 Insufficient privileges: not in try users

@bors

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

@memoryruins: 🔑 Insufficient privileges: Not in reviewers

@memoryruins

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

It was worth a shot :)

@Centril

This comment has been minimized.

Copy link
Member

commented May 30, 2019

Hehe :)

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

📌 Commit e18885e has been approved by Centril

Centril added a commit to Centril/rust that referenced this pull request May 30, 2019

Rollup merge of rust-lang#61342 - memoryruins:ellipsis_inclusive_rang…
…e_patterns, r=Centril

Set ellipsis_inclusive_range_patterns lint to warn

Continuing rust-lang#54910, the `ellipsis_inclusive_range_patterns` lint is set to warn.

r? @Centril

Centril added a commit to Centril/rust that referenced this pull request May 30, 2019

Rollup merge of rust-lang#61342 - memoryruins:ellipsis_inclusive_rang…
…e_patterns, r=Centril

Set ellipsis_inclusive_range_patterns lint to warn

Continuing rust-lang#54910, the `ellipsis_inclusive_range_patterns` lint is set to warn.

r? @Centril

Centril added a commit to Centril/rust that referenced this pull request May 30, 2019

Rollup merge of rust-lang#61342 - memoryruins:ellipsis_inclusive_rang…
…e_patterns, r=Centril

Set ellipsis_inclusive_range_patterns lint to warn

Continuing rust-lang#54910, the `ellipsis_inclusive_range_patterns` lint is set to warn.

r? @Centril

bors added a commit that referenced this pull request May 31, 2019

Auto merge of #61379 - Centril:rollup-hx912ts, r=Centril
Rollup of 10 pull requests

Successful merges:

 - #60897 (error: remove StringError from Debug output)
 - #61278 (Miri: give machine the chance to tag all allocations)
 - #61304 (Speed up Azure CI installing Windows dependencies)
 - #61342 (Set ellipsis_inclusive_range_patterns lint to warn)
 - #61344 (Add regression test for const generics ICE)
 - #61359 (Fix links in Deref documentation)
 - #61363 (Stabilize iter_nth_back feature)
 - #61369 (Fixed lifetime misspelling)
 - #61372 (Migrate some books to mdbook version 0.2)
 - #61374 (Explicitly suggest 'type_ascription' feature)

Failed merges:

r? @ghost

bors added a commit that referenced this pull request May 31, 2019

Auto merge of #61379 - Centril:rollup-hx912ts, r=Centril
Rollup of 10 pull requests

Successful merges:

 - #60897 (error: remove StringError from Debug output)
 - #61278 (Miri: give machine the chance to tag all allocations)
 - #61304 (Speed up Azure CI installing Windows dependencies)
 - #61342 (Set ellipsis_inclusive_range_patterns lint to warn)
 - #61344 (Add regression test for const generics ICE)
 - #61359 (Fix links in Deref documentation)
 - #61363 (Stabilize iter_nth_back feature)
 - #61369 (Fixed lifetime misspelling)
 - #61372 (Migrate some books to mdbook version 0.2)
 - #61374 (Explicitly suggest 'type_ascription' feature)

Failed merges:

r? @ghost

pietroalbini added a commit to pietroalbini/rust that referenced this pull request May 31, 2019

Rollup merge of rust-lang#61342 - memoryruins:ellipsis_inclusive_rang…
…e_patterns, r=Centril

Set ellipsis_inclusive_range_patterns lint to warn

Continuing rust-lang#54910, the `ellipsis_inclusive_range_patterns` lint is set to warn.

r? @Centril

bors added a commit that referenced this pull request May 31, 2019

Auto merge of #61394 - pietroalbini:rollup-lzugnb4, r=pietroalbini
Rollup of 11 pull requests

Successful merges:

 - #60897 (error: remove StringError from Debug output)
 - #61304 (Speed up Azure CI installing Windows dependencies)
 - #61319 (Swap order of `unsafe async fn` to `async unsafe fn`)
 - #61342 (Set ellipsis_inclusive_range_patterns lint to warn)
 - #61344 (Add regression test for const generics ICE)
 - #61359 (Fix links in Deref documentation)
 - #61363 (Stabilize iter_nth_back feature)
 - #61369 (Fixed lifetime misspelling)
 - #61372 (Migrate some books to mdbook version 0.2)
 - #61374 (Explicitly suggest 'type_ascription' feature)
 - #61382 (Fixed a typo in core::convert::AsMut)

Failed merges:

r? @ghost

bors added a commit that referenced this pull request May 31, 2019

Auto merge of #61394 - pietroalbini:rollup-lzugnb4, r=pietroalbini
Rollup of 11 pull requests

Successful merges:

 - #60897 (error: remove StringError from Debug output)
 - #61304 (Speed up Azure CI installing Windows dependencies)
 - #61319 (Swap order of `unsafe async fn` to `async unsafe fn`)
 - #61342 (Set ellipsis_inclusive_range_patterns lint to warn)
 - #61344 (Add regression test for const generics ICE)
 - #61359 (Fix links in Deref documentation)
 - #61363 (Stabilize iter_nth_back feature)
 - #61369 (Fixed lifetime misspelling)
 - #61372 (Migrate some books to mdbook version 0.2)
 - #61374 (Explicitly suggest 'type_ascription' feature)
 - #61382 (Fixed a typo in core::convert::AsMut)

Failed merges:

r? @ghost

bors added a commit that referenced this pull request Jun 1, 2019

Auto merge of #61394 - pietroalbini:rollup-lzugnb4, r=pietroalbini
Rollup of 11 pull requests

Successful merges:

 - #60897 (error: remove StringError from Debug output)
 - #61304 (Speed up Azure CI installing Windows dependencies)
 - #61319 (Swap order of `unsafe async fn` to `async unsafe fn`)
 - #61342 (Set ellipsis_inclusive_range_patterns lint to warn)
 - #61344 (Add regression test for const generics ICE)
 - #61359 (Fix links in Deref documentation)
 - #61363 (Stabilize iter_nth_back feature)
 - #61369 (Fixed lifetime misspelling)
 - #61372 (Migrate some books to mdbook version 0.2)
 - #61374 (Explicitly suggest 'type_ascription' feature)
 - #61382 (Fixed a typo in core::convert::AsMut)

Failed merges:

r? @ghost

@bors bors merged commit e18885e into rust-lang:master Jun 1, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

phansch added a commit to phansch/rust-clippy that referenced this pull request Jun 1, 2019

bors added a commit to rust-lang/rust-clippy that referenced this pull request Jun 1, 2019

Auto merge of #4158 - phansch:rustup_tests, r=Manishearth
Fix ellipsis_inclusive_range_patterns lint warnings

Changed from `allow` to `warn` in rust-lang/rust#61342

changelog: none

@memoryruins memoryruins deleted the memoryruins:ellipsis_inclusive_range_patterns branch Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.