Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize exact_size_is_empty feature #61366

Open
wants to merge 1 commit into
base: master
from

Conversation

@lzutao
Copy link
Contributor

commented May 30, 2019

FCP done in #35428 (comment)

Closes #35428

r? @Centril

@lzutao

This comment was marked as resolved.

Copy link
Contributor Author

commented May 30, 2019

@rustbot modify labels: T-libs

@rustbot rustbot added the T-libs label May 30, 2019

@jonas-schievink jonas-schievink added this to the 1.37 milestone May 30, 2019

@Centril

This comment has been minimized.

Copy link
Member

commented May 30, 2019

r? @SimonSapin

cc @rust-lang/libs
cc @scottmcm -- you had concerns?

@rust-highfive rust-highfive assigned SimonSapin and unassigned Centril May 30, 2019

@scottmcm

This comment has been minimized.

Copy link
Member

commented May 31, 2019

Note that the PR referenced in the OP here is over two years old, and is_empty was explicitly removed from stabilization due to concerns raised (#35428 (comment)), so I don't think this PR is a fait accompli.

I continue to feel that .is_empty() is too useful to be limited to just ExactSizeIterators.

@SimonSapin

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

At a risk of rehashing the previous thread, please expand on what you would prefer instead. If it should not be limited to that, then what should it be? That plus methods on other existing trait(s) and/or inherent methods on some types? A dedicated trait? Why? Would a dedicated trait be used in a bound in a generic context?

Having someone champion and argue for a counter-proposal could be a way to unblock this.

@lzutao lzutao force-pushed the lzutao:stabilize-exact_size_is_empty branch from 54699aa to 2974a70 Jul 9, 2019

@Centril Centril modified the milestones: 1.38, 1.39 Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.