Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LLVM to include fmin/fmax optimisations #61384

Merged
merged 1 commit into from Jun 2, 2019

Conversation

Projects
None yet
5 participants
@varkor
Copy link
Member

commented May 31, 2019

This will enable us to test if the optimisation issues mentioned in #18384 really are fixed. Unfortunately, using the intrinsics immediately is problematic due to the libcore/libstd split (see #50145).

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented May 31, 2019

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented May 31, 2019

⚠️ Warning ⚠️

  • These commits modify submodules.
@varkor

This comment has been minimized.

Copy link
Member Author

commented May 31, 2019

@alexcrichton

This comment has been minimized.

Copy link
Member

commented May 31, 2019

@bors: r+

@bors

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

📌 Commit f2210a9 has been approved by alexcrichton

@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 2, 2019

⌛️ Testing commit f2210a9 with merge 538e17a...

bors added a commit that referenced this pull request Jun 2, 2019

Auto merge of #61384 - varkor:fmin-fmax-llvm-opt, r=alexcrichton
Update LLVM to include fmin/fmax optimisations

This will enable us to test if the optimisation issues mentioned in #18384 really are fixed. Unfortunately, using the intrinsics immediately is problematic due to the libcore/libstd split (see #50145).
@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 2, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: alexcrichton
Pushing 538e17a to master...

@bors bors added the merged-by-bors label Jun 2, 2019

@bors bors merged commit f2210a9 into rust-lang:master Jun 2, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
homu Test successful
Details

bors added a commit that referenced this pull request Jun 7, 2019

Auto merge of #61408 - varkor:fmin-fmax-llvm-intrinsics, r=alexcrichton
Use LLVM intrinsics for floating-point min/max

Resurrection of #46926, now that the optimisation issues are fixed. I've confirmed locally that #61384 solves the issues.

I'm not sure if we're allowed to move the `min`/`max` methods from libcore to libstd: I can't quite tell what the status is from #50145. However, this is necessary to use the intrinsics.

Fixes #18384.

r? @SimonSapin
cc @rkruppe @nikic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.