Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codegen: change `$6d$` to `$u6d$` #61423

Merged
merged 1 commit into from Jun 2, 2019

Conversation

Projects
None yet
4 participants
@davidtwco
Copy link
Member

commented Jun 1, 2019

This changes a mistake introduced in #61195 where the mangling
workaround used was incorrect, resolving this comment from @eddyb.

r? @eddyb

codegen: change `$6d$` to `$u6d$`
This changes a mistake introduced in #61195 where the mangling
workaround used was incorrect.
@eddyb

This comment has been minimized.

Copy link
Member

commented Jun 1, 2019

cc @alexcrichton looks like the $u...$ demangler (for the legacy mangling) has a few special-cases and doesn't do arbitrary characters, would you mind if I added support for that, later?

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 1, 2019

📌 Commit e71f466 has been approved by eddyb

Centril added a commit to Centril/rust that referenced this pull request Jun 2, 2019

Rollup merge of rust-lang#61423 - davidtwco:correct-symbol-mangling, …
…r=eddyb

codegen: change `$6d$` to `$u6d$`

This changes a mistake introduced in rust-lang#61195 where the mangling
workaround used was incorrect, resolving [this comment](rust-lang#61195 (comment)) from @eddyb.

r? @eddyb

@Centril Centril referenced this pull request Jun 2, 2019

Merged

Rollup of 6 pull requests #61460

bors added a commit that referenced this pull request Jun 2, 2019

Auto merge of #61460 - Centril:rollup-8txhjx4, r=Centril
Rollup of 6 pull requests

Successful merges:

 - #61380 (Fix some issues with `unwrap_usize` instead of `assert_usize`)
 - #61423 (codegen: change `$6d$` to `$u6d$`)
 - #61438 (Point at individual type args on arg count mismatch)
 - #61441 (Tweak wording when encountering `fn` call in pattern)
 - #61451 (Fix missing semicolon in doc)
 - #61458 (Fix typo in AsRef doc)

Failed merges:

r? @ghost

@bors bors merged commit e71f466 into rust-lang:master Jun 2, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@davidtwco davidtwco deleted the davidtwco:correct-symbol-mangling branch Jun 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.