Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librustc_errors: Add some more documentation #61686

Merged
merged 2 commits into from Jun 12, 2019

Conversation

@phansch
Copy link
Member

commented Jun 9, 2019

@Centril
Copy link
Member

left a comment

Mostly proof reading :)

src/librustc_errors/lib.rs Outdated Show resolved Hide resolved
src/librustc_errors/diagnostic_builder.rs Outdated Show resolved Hide resolved
src/librustc/session/config.rs Outdated Show resolved Hide resolved
src/librustc/session/config.rs Outdated Show resolved Hide resolved
@estebank

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

R=me with the comments addressed

@phansch phansch force-pushed the phansch:librustc_errors_docs branch from c58813b to 9b63ab8 Jun 10, 2019

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

commented Jun 10, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:21ad94c6:start=1560157429923116981,finish=1560157518466111594,duration=88542994613
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
[00:06:24]    Compiling synstructure v0.10.2
[00:06:37]    Compiling rustc_macros v0.1.0 (/checkout/src/librustc_macros)
[00:06:44]    Compiling syntax_pos v0.0.0 (/checkout/src/libsyntax_pos)
[00:06:48]    Compiling rustc_errors v0.0.0 (/checkout/src/librustc_errors)
[00:06:48] error[E0658]: `crate` visibility modifier is experimental
[00:06:48]     |
[00:06:48]     |
[00:06:48] 351 |     crate fn new_with_code(handler: &'a Handler,
[00:06:48]     |
[00:06:48]     = note: for more information, see https://github.com/rust-lang/rust/issues/53120
[00:06:48]     = note: for more information, see https://github.com/rust-lang/rust/issues/53120
[00:06:48]     = help: add #![feature(crate_visibility_modifier)] to the crate attributes to enable
[00:06:48] error: aborting due to previous error
[00:06:48] 
[00:06:48] For more information about this error, try `rustc --explain E0658`.
[00:06:48] error: Could not compile `rustc_errors`.
---
travis_time:end:00415a31:start=1560157949288741887,finish=1560157949293517436,duration=4775549
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:00034b17
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:08bbe3f3
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/a

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@phansch phansch force-pushed the phansch:librustc_errors_docs branch from 9b63ab8 to bc2b8d0 Jun 10, 2019

phansch and others added 2 commits Jun 9, 2019
Address review comments
Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>

@phansch phansch force-pushed the phansch:librustc_errors_docs branch from bc2b8d0 to 33137ff Jun 10, 2019

@phansch

This comment has been minimized.

Copy link
Member Author

commented Jun 10, 2019

@bors r=estebank

@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

@phansch: 🔑 Insufficient privileges: Not in reviewers

@Centril

This comment has been minimized.

Copy link
Member

commented Jun 10, 2019

@bors r=estebank

@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

📌 Commit 33137ff has been approved by estebank

Centril added a commit to Centril/rust that referenced this pull request Jun 11, 2019
Rollup merge of rust-lang#61686 - phansch:librustc_errors_docs, r=est…
…ebank

librustc_errors: Add some more documentation

r? @estebank
Centril added a commit to Centril/rust that referenced this pull request Jun 11, 2019
Rollup merge of rust-lang#61686 - phansch:librustc_errors_docs, r=est…
…ebank

librustc_errors: Add some more documentation

r? @estebank
bors added a commit that referenced this pull request Jun 11, 2019
Auto merge of #61737 - Centril:rollup-wsgxnyq, r=Centril
Rollup of 11 pull requests

Successful merges:

 - #61526 (move some tests into subfolders)
 - #61550 (Windows 10 SDK is also required now.)
 - #61606 (Remove some legacy proc macro flavors)
 - #61639 (Bootstrap cleanup)
 - #61686 (librustc_errors: Add some more documentation)
 - #61698 (typeck: Fix const generic in repeat param ICE.)
 - #61707 (Azure: retry failed awscli installs)
 - #61715 (make sure make_ascii_lowercase actually leaves upper-case non-ASCII characters alone)
 - #61720 (std: Remove internal definitions of `cfg_if!` macro)
 - #61724 (core: use memcmp optimization for 128 bit integer slices)
 - #61726 (Use `for_each` in `Iterator::partition`)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Jun 11, 2019
Rollup merge of rust-lang#61686 - phansch:librustc_errors_docs, r=est…
…ebank

librustc_errors: Add some more documentation

r? @estebank
bors added a commit that referenced this pull request Jun 11, 2019
Auto merge of #61741 - Centril:rollup-fgro5kz, r=Centril
Rollup of 11 pull requests

Successful merges:

 - #61518 (Add loops to doc list of things not stable in const fn)
 - #61526 (move some tests into subfolders)
 - #61550 (Windows 10 SDK is also required now.)
 - #61606 (Remove some legacy proc macro flavors)
 - #61652 (Mention slice patterns in array)
 - #61686 (librustc_errors: Add some more documentation)
 - #61698 (typeck: Fix const generic in repeat param ICE.)
 - #61707 (Azure: retry failed awscli installs)
 - #61715 (make sure make_ascii_lowercase actually leaves upper-case non-ASCII characters alone)
 - #61724 (core: use memcmp optimization for 128 bit integer slices)
 - #61726 (Use `for_each` in `Iterator::partition`)

Failed merges:

r? @ghost
bors added a commit that referenced this pull request Jun 11, 2019
Auto merge of #61741 - Centril:rollup-fgro5kz, r=Centril
Rollup of 11 pull requests

Successful merges:

 - #61518 (Add loops to doc list of things not stable in const fn)
 - #61526 (move some tests into subfolders)
 - #61550 (Windows 10 SDK is also required now.)
 - #61606 (Remove some legacy proc macro flavors)
 - #61652 (Mention slice patterns in array)
 - #61686 (librustc_errors: Add some more documentation)
 - #61698 (typeck: Fix const generic in repeat param ICE.)
 - #61707 (Azure: retry failed awscli installs)
 - #61715 (make sure make_ascii_lowercase actually leaves upper-case non-ASCII characters alone)
 - #61724 (core: use memcmp optimization for 128 bit integer slices)
 - #61726 (Use `for_each` in `Iterator::partition`)

Failed merges:

r? @ghost

@bors bors merged commit 33137ff into rust-lang:master Jun 12, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.