Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librustc_errors: Add some more documentation #61686

Merged
merged 2 commits into from
Jun 12, 2019

Conversation

phansch
Copy link
Member

@phansch phansch commented Jun 9, 2019

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 9, 2019
Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly proof reading :)

src/librustc_errors/lib.rs Outdated Show resolved Hide resolved
src/librustc_errors/diagnostic_builder.rs Outdated Show resolved Hide resolved
src/librustc/session/config.rs Outdated Show resolved Hide resolved
src/librustc/session/config.rs Outdated Show resolved Hide resolved
@estebank
Copy link
Contributor

R=me with the comments addressed

@rust-highfive

This comment has been minimized.

phansch and others added 2 commits June 10, 2019 11:46
Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
@phansch
Copy link
Member Author

phansch commented Jun 10, 2019

@bors r=estebank

@bors
Copy link
Contributor

bors commented Jun 10, 2019

@phansch: 🔑 Insufficient privileges: Not in reviewers

@Centril
Copy link
Contributor

Centril commented Jun 10, 2019

@bors r=estebank

@bors
Copy link
Contributor

bors commented Jun 10, 2019

📌 Commit 33137ff has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 10, 2019
Centril added a commit to Centril/rust that referenced this pull request Jun 11, 2019
…ebank

librustc_errors: Add some more documentation

r? @estebank
Centril added a commit to Centril/rust that referenced this pull request Jun 11, 2019
…ebank

librustc_errors: Add some more documentation

r? @estebank
Centril added a commit to Centril/rust that referenced this pull request Jun 11, 2019
…ebank

librustc_errors: Add some more documentation

r? @estebank
bors added a commit that referenced this pull request Jun 11, 2019
Rollup of 11 pull requests

Successful merges:

 - #61518 (Add loops to doc list of things not stable in const fn)
 - #61526 (move some tests into subfolders)
 - #61550 (Windows 10 SDK is also required now.)
 - #61606 (Remove some legacy proc macro flavors)
 - #61652 (Mention slice patterns in array)
 - #61686 (librustc_errors: Add some more documentation)
 - #61698 (typeck: Fix const generic in repeat param ICE.)
 - #61707 (Azure: retry failed awscli installs)
 - #61715 (make sure make_ascii_lowercase actually leaves upper-case non-ASCII characters alone)
 - #61724 (core: use memcmp optimization for 128 bit integer slices)
 - #61726 (Use `for_each` in `Iterator::partition`)

Failed merges:

r? @ghost
bors added a commit that referenced this pull request Jun 11, 2019
Rollup of 11 pull requests

Successful merges:

 - #61518 (Add loops to doc list of things not stable in const fn)
 - #61526 (move some tests into subfolders)
 - #61550 (Windows 10 SDK is also required now.)
 - #61606 (Remove some legacy proc macro flavors)
 - #61652 (Mention slice patterns in array)
 - #61686 (librustc_errors: Add some more documentation)
 - #61698 (typeck: Fix const generic in repeat param ICE.)
 - #61707 (Azure: retry failed awscli installs)
 - #61715 (make sure make_ascii_lowercase actually leaves upper-case non-ASCII characters alone)
 - #61724 (core: use memcmp optimization for 128 bit integer slices)
 - #61726 (Use `for_each` in `Iterator::partition`)

Failed merges:

r? @ghost
@bors bors merged commit 33137ff into rust-lang:master Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants