Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't ICE on mutable zst slices #62094

Merged
merged 4 commits into from Jun 25, 2019

Conversation

Projects
None yet
6 participants
@oli-obk
Copy link
Contributor

commented Jun 24, 2019

fixes #62045

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Jun 24, 2019

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@oli-obk

This comment has been minimized.

Copy link
Contributor Author

commented Jun 24, 2019

@rust-highfive rust-highfive assigned RalfJung and unassigned estebank Jun 24, 2019

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Jun 24, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:307074a0:start=1561383579154496625,finish=1561383580046512124,duration=892015499
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---

[00:03:52] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:03:53] tidy error: /checkout/src/test/ui/consts/issue-62045.rs: too many trailing newlines (2)
[00:03:53] tidy error: /checkout/src/test/ui/consts/miri_unleashed/mutable_references_ice.rs:6: line longer than 100 chars
[00:03:54] some tidy checks failed
[00:03:54] 
[00:03:54] 
[00:03:54] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
[00:03:54] 
[00:03:54] 
[00:03:54] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:03:54] Build completed unsuccessfully in 0:01:08
---
travis_time:end:1a816260:start=1561383825352390344,finish=1561383825356783691,duration=4393347
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:17d7fafa
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:236863e7
travis_time:start:236863e7
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0536828d
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@eddyb

eddyb approved these changes Jun 24, 2019

@eddyb

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2019

📌 Commit 91a15e2 has been approved by eddyb

@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 25, 2019

⌛️ Testing commit 91a15e2 with merge 10deeae...

bors added a commit that referenced this pull request Jun 25, 2019

Auto merge of #62094 - oli-obk:zst_intern, r=eddyb
 Don't ICE on mutable zst slices

fixes #62045
@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 25, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: eddyb
Pushing 10deeae to master...

@bors bors added the merged-by-bors label Jun 25, 2019

@bors bors merged commit 91a15e2 into rust-lang:master Jun 25, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
pr Build #20190624.23 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.